mbox series

[SRU,OEM-5.10,0/1] micmute led init state is not correct on a lenovo machine

Message ID 20210318050002.10468-1-hui.wang@canonical.com
Headers show
Series micmute led init state is not correct on a lenovo machine | expand

Message

Hui Wang March 18, 2021, 5 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1919952

Since this patch cced to stable and only oem project needs this
fix urgently, only send the sru to oem-5.10 kernel, other ubuntu
kernels will merge this patch with stable update.

[Impact]
On a lenovo machine, the micmute led init state is not correct, after
freshly installing the os and boot up, the mic is not muted, but the
micmute led is on.

[Fix]
backport a patch from upstream.

[Test]
Booting the system with patched kernel, the micmute led
init state is correct. If mic is mute, the led is on, if
the mic is not mute, the led is off.


[Where problems could occur]
This could introduce the micmute led wrong init state on other
machines, we tested this patch on many lenovo machines, no regression
found so far.


Hui Wang (1):
  ALSA: hda: generic: Fix the micmute led init state

 sound/pci/hda/hda_generic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tim Gardner March 18, 2021, 11:31 a.m. UTC | #1 
Acked-by: Tim Gardner <tim.gardner@canonical.com>

On 3/17/21 11:00 PM, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1919952
> 
> Since this patch cced to stable and only oem project needs this
> fix urgently, only send the sru to oem-5.10 kernel, other ubuntu
> kernels will merge this patch with stable update.
> 
> [Impact]
> On a lenovo machine, the micmute led init state is not correct, after
> freshly installing the os and boot up, the mic is not muted, but the
> micmute led is on.
> 
> [Fix]
> backport a patch from upstream.
> 
> [Test]
> Booting the system with patched kernel, the micmute led
> init state is correct. If mic is mute, the led is on, if
> the mic is not mute, the led is off.
> 
> 
> [Where problems could occur]
> This could introduce the micmute led wrong init state on other
> machines, we tested this patch on many lenovo machines, no regression
> found so far.
> 
> 
> Hui Wang (1):
>    ALSA: hda: generic: Fix the micmute led init state
> 
>   sound/pci/hda/hda_generic.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
Timo Aaltonen March 18, 2021, 7:21 p.m. UTC | #2 
On 18.3.2021 7.00, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1919952
> 
> Since this patch cced to stable and only oem project needs this
> fix urgently, only send the sru to oem-5.10 kernel, other ubuntu
> kernels will merge this patch with stable update.
> 
> [Impact]
> On a lenovo machine, the micmute led init state is not correct, after
> freshly installing the os and boot up, the mic is not muted, but the
> micmute led is on.
> 
> [Fix]
> backport a patch from upstream.
> 
> [Test]
> Booting the system with patched kernel, the micmute led
> init state is correct. If mic is mute, the led is on, if
> the mic is not mute, the led is off.
> 
> 
> [Where problems could occur]
> This could introduce the micmute led wrong init state on other
> machines, we tested this patch on many lenovo machines, no regression
> found so far.
> 
> 
> Hui Wang (1):
>    ALSA: hda: generic: Fix the micmute led init state
> 
>   sound/pci/hda/hda_generic.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

applied to oem-5.10, thanks