From patchwork Thu Mar 18 04:39:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hui Wang X-Patchwork-Id: 1455079 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4F1Dnt44qtz9sWK; Thu, 18 Mar 2021 15:39:30 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1lMkRT-0001d0-DR; Thu, 18 Mar 2021 04:39:27 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lMkRR-0001cp-RW for kernel-team@lists.ubuntu.com; Thu, 18 Mar 2021 04:39:25 +0000 Received: from 61-220-137-34.hinet-ip.hinet.net ([61.220.137.34] helo=localhost.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lMkRQ-0000KI-QH for kernel-team@lists.ubuntu.com; Thu, 18 Mar 2021 04:39:25 +0000 From: Hui Wang To: kernel-team@lists.ubuntu.com Subject: [SRU][H/G/OEM-5.10][PATCH v2 0/6] power off stress test will hang on the TGL machines Date: Thu, 18 Mar 2021 12:39:10 +0800 Message-Id: <20210318043918.9900-1-hui.wang@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/1919930 Intel suggested that we do 2 actions to fix this problem, the 1st is merging 5 kernel patches, this only applies to H and OEM-5.10 since there is no tgl.c in the groovy kernel yet. the 2nd is change a kernel config, this change applies to H, G and OEM-5.10. https://github.com/thesofproject/linux/issues/2781 [Impact] When we run poweroff/on stress test on some lenovo TGL laptop, the system will randomly hang, and when this issue happens, the dmesg shows the sof audio driver fails. [Fix] Intel recommend that we backport 5 kernel patches and change a kernel config. [Test] After applying the changes, and test on TGL/cml/whl machines, the audio function works as good as before, and the poweroff stress test didn't hang anymore. [Where problems could occur] The kernel patches probably could introduce issues when system powre off or reboot on TGL machines, but this possibility is low since we have tested these patches on different TGL machines. the kernel option change could introduce power consumption regression, but it only affects power saving and package_cstate values when any capture stream is active, while no impact if all capture streams are inactive. that is to say, in theory it will not impact the power consumption in short idle or long idle. And I checked the system cound enter package_c10 after this change. Hui Wang (1): UBUNTU: [Config] set SND_SOC_SOF_HDA_ALWAYS_ENABLE_DMI_L1 to n Keyon Jie (4): ASoC: SOF: add .shutdown() callback to snd_sof_dsp_ops ASoC: SOF: add snd_sof_device_shutdown() helper for shutdown ASoC: SOF: sof-pci-dev: add .shutdown() callback ASoC: SOF: Intel: tgl: do thorough remove at .shutdown() callback Libin Yang (1): UBUNTU: SAUCE: ASoC: SOF: Intel: TGL: set shutdown callback to hda_dsp_shutdown debian.master/config/annotations | 3 ++- debian.master/config/config.common.ubuntu | 2 +- sound/soc/sof/core.c | 8 ++++++++ sound/soc/sof/intel/hda-dsp.c | 6 ++++++ sound/soc/sof/intel/hda.h | 1 + sound/soc/sof/intel/tgl.c | 3 ++- sound/soc/sof/ops.h | 8 ++++++++ sound/soc/sof/sof-pci-dev.c | 6 ++++++ sound/soc/sof/sof-priv.h | 4 +++- 9 files changed, 37 insertions(+), 4 deletions(-) Acked-by: Tim Gardner