| Message ID | 20210302111939.4669-1-colin.king@canonical.com |
|---|---|
| Headers | show |
| Series | Revert SiFive Unleashed CPUFreq (LP: #1917433 | expand |
On Tue, Mar 02, 2021 at 11:19:37AM +0000, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > == SRU Justifcation Groovy/Hirsute RISCV == > > The SiFive Unleashed board with the current Ubuntu cpufreq default > config can hang on boot with CPU freq enabled with the latest device > tree settings. It is known that the cpufreq can be problematic so > the recommended way forward is to currently revert the cpufreq > enablement commit. > > commit 3949df6ecdca04339bc8a3925c2ba7f881cf82b1 > Author: David Abdurachmanov <david.abdurachmanov@sifive.com> > Date: Tue Jan 28 02:55:56 2020 -0800 > > SiFive Unleashed CPUFreq > > == The fix(es) == > > Revert commit "SiFive Unleashed CPUFreq" > > == Test Case == > > Boot with the latest DT. It should now boot. Boot without the latest DT, it should also boot. > > == Where problems could occur == > > Users expecting CPU freq scaling now don't have this working option. > This is deemed to be acceptable as without the fix their systems are > likely to be unbootable with the updated DT. > > Colin Ian King (2): > Revert "SiFive Unleashed CPUFreq" > UBUNTU: [Config] Update annotations for CPUFreq revert > > arch/riscv/Kconfig | 8 ----- > arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 5 --- > .../boot/dts/sifive/hifive-unleashed-a00.dts | 34 ------------------- > arch/riscv/configs/defconfig | 5 --- > debian.riscv/config/annotations | 3 +- > 5 files changed, 2 insertions(+), 53 deletions(-) > > -- > 2.29.2 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team Acked-by: William Breathitt Gray <william.gray@canonical.com>
On 3/2/21 4:19 AM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > == SRU Justifcation Groovy/Hirsute RISCV == > > The SiFive Unleashed board with the current Ubuntu cpufreq default > config can hang on boot with CPU freq enabled with the latest device > tree settings. It is known that the cpufreq can be problematic so > the recommended way forward is to currently revert the cpufreq > enablement commit. > > commit 3949df6ecdca04339bc8a3925c2ba7f881cf82b1 > Author: David Abdurachmanov <david.abdurachmanov@sifive.com> > Date: Tue Jan 28 02:55:56 2020 -0800 > > SiFive Unleashed CPUFreq > > == The fix(es) == > > Revert commit "SiFive Unleashed CPUFreq" > > == Test Case == > > Boot with the latest DT. It should now boot. Boot without the latest DT, it should also boot. > > == Where problems could occur == > > Users expecting CPU freq scaling now don't have this working option. > This is deemed to be acceptable as without the fix their systems are > likely to be unbootable with the updated DT. > > Colin Ian King (2): > Revert "SiFive Unleashed CPUFreq" > UBUNTU: [Config] Update annotations for CPUFreq revert > > arch/riscv/Kconfig | 8 ----- > arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 5 --- > .../boot/dts/sifive/hifive-unleashed-a00.dts | 34 ------------------- > arch/riscv/configs/defconfig | 5 --- > debian.riscv/config/annotations | 3 +- > 5 files changed, 2 insertions(+), 53 deletions(-) > Shouldn't these 2 patches be applied in the reverse order in which they are presented to preserve bisectibility ? Otherwise: Acked-by: Tim Gardner <tim.gardner@canonical.com> ----------- Tim Gardner Canonical, Inc
On 02.03.21 12:19, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > == SRU Justifcation Groovy/Hirsute RISCV == > > The SiFive Unleashed board with the current Ubuntu cpufreq default > config can hang on boot with CPU freq enabled with the latest device > tree settings. It is known that the cpufreq can be problematic so > the recommended way forward is to currently revert the cpufreq > enablement commit. > > commit 3949df6ecdca04339bc8a3925c2ba7f881cf82b1 > Author: David Abdurachmanov <david.abdurachmanov@sifive.com> > Date: Tue Jan 28 02:55:56 2020 -0800 > > SiFive Unleashed CPUFreq > > == The fix(es) == > > Revert commit "SiFive Unleashed CPUFreq" > > == Test Case == > > Boot with the latest DT. It should now boot. Boot without the latest DT, it should also boot. > > == Where problems could occur == > > Users expecting CPU freq scaling now don't have this working option. > This is deemed to be acceptable as without the fix their systems are > likely to be unbootable with the updated DT. > > Colin Ian King (2): > Revert "SiFive Unleashed CPUFreq" > UBUNTU: [Config] Update annotations for CPUFreq revert > > arch/riscv/Kconfig | 8 ----- > arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 5 --- > .../boot/dts/sifive/hifive-unleashed-a00.dts | 34 ------------------- > arch/riscv/configs/defconfig | 5 --- > debian.riscv/config/annotations | 3 +- > 5 files changed, 2 insertions(+), 53 deletions(-) > Applied to groovy:linux-riscv/master. Thanks. Colin, I did adjust the bug report to use the linux-riscv source (that is more clearly saying that this should not go into the main kernel, if that is correct). This unfortunately is not very clear from the bug report and the mailing list subject. -Stefan
From: Colin Ian King <colin.king@canonical.com> == SRU Justifcation Groovy/Hirsute RISCV == The SiFive Unleashed board with the current Ubuntu cpufreq default config can hang on boot with CPU freq enabled with the latest device tree settings. It is known that the cpufreq can be problematic so the recommended way forward is to currently revert the cpufreq enablement commit. commit 3949df6ecdca04339bc8a3925c2ba7f881cf82b1 Author: David Abdurachmanov <david.abdurachmanov@sifive.com> Date: Tue Jan 28 02:55:56 2020 -0800 SiFive Unleashed CPUFreq == The fix(es) == Revert commit "SiFive Unleashed CPUFreq" == Test Case == Boot with the latest DT. It should now boot. Boot without the latest DT, it should also boot. == Where problems could occur == Users expecting CPU freq scaling now don't have this working option. This is deemed to be acceptable as without the fix their systems are likely to be unbootable with the updated DT. Colin Ian King (2): Revert "SiFive Unleashed CPUFreq" UBUNTU: [Config] Update annotations for CPUFreq revert arch/riscv/Kconfig | 8 ----- arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 5 --- .../boot/dts/sifive/hifive-unleashed-a00.dts | 34 ------------------- arch/riscv/configs/defconfig | 5 --- debian.riscv/config/annotations | 3 +- 5 files changed, 2 insertions(+), 53 deletions(-)