| Message ID | 20201218095014.9958-1-po-hsu.lin@canonical.com |
|---|---|
| Headers | show |
| Series | [F/G/H/Unstable,SRU,1/1] selftests/powerpc/eeh: disable kselftest timeout setting for eeh-basic | expand |
On Fri, Dec 18, 2020 at 05:50:13PM +0800, Po-Hsu Lin wrote: > [Impact] > The breakable devices test is hardware-dependent. In our test pool > it will take about: > * 30 seconds to run on a Power8 system that with 5 breakable devices, > * 60 seconds to run on a Power9 system that with 4 breakable devices. > > The default 45 seconds kselftest framework timeout is not enough to > allow this test to finish on some nodes. Thus causing this test to > fail with TIMEOUT error. > > [Fix] > * f5eca0b279117f ("selftests/powerpc/eeh: disable kselftest timeout > setting for eeh-basic") > > We have this testcase since Focal, and this patch can be cherry-picked > into all affected releases. > > [Test case] > Run this test on P9 node baltar, on which this timeout issue can be > 100% reproduced. With this patch applied, the test can finish without > being terminated by the default timeout. > > [Where problems could occur] > This will make test takes longer to finish, but it's still being > controlled by the timeout mechanism both in the test case and > kselftest framework. It's unlikely to make the test hang forever. > > Po-Hsu Lin (1): > selftests/powerpc/eeh: disable kselftest timeout setting for eeh-basic Acked-by: Seth Forshee <seth.forshee@canonical.com> Applied to unstable/master, thanks!
On 18.12.20 10:50, Po-Hsu Lin wrote: > [Impact] > The breakable devices test is hardware-dependent. In our test pool > it will take about: > * 30 seconds to run on a Power8 system that with 5 breakable devices, > * 60 seconds to run on a Power9 system that with 4 breakable devices. > > The default 45 seconds kselftest framework timeout is not enough to > allow this test to finish on some nodes. Thus causing this test to > fail with TIMEOUT error. > > [Fix] > * f5eca0b279117f ("selftests/powerpc/eeh: disable kselftest timeout > setting for eeh-basic") > > We have this testcase since Focal, and this patch can be cherry-picked > into all affected releases. > > [Test case] > Run this test on P9 node baltar, on which this timeout issue can be > 100% reproduced. With this patch applied, the test can finish without > being terminated by the default timeout. > > [Where problems could occur] > This will make test takes longer to finish, but it's still being > controlled by the timeout mechanism both in the test case and > kselftest framework. It's unlikely to make the test hang forever. > > Po-Hsu Lin (1): > selftests/powerpc/eeh: disable kselftest timeout setting for eeh-basic > > tools/testing/selftests/powerpc/eeh/Makefile | 2 +- > tools/testing/selftests/powerpc/eeh/settings | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > create mode 100644 tools/testing/selftests/powerpc/eeh/settings > Acked-by: Stefan Bader <stefan.bader@canonical.com>
Applied to F/G master-next. thank you! -Kelsey On 2020-12-18 17:50:13 , Po-Hsu Lin wrote: > [Impact] > The breakable devices test is hardware-dependent. In our test pool > it will take about: > * 30 seconds to run on a Power8 system that with 5 breakable devices, > * 60 seconds to run on a Power9 system that with 4 breakable devices. > > The default 45 seconds kselftest framework timeout is not enough to > allow this test to finish on some nodes. Thus causing this test to > fail with TIMEOUT error. > > [Fix] > * f5eca0b279117f ("selftests/powerpc/eeh: disable kselftest timeout > setting for eeh-basic") > > We have this testcase since Focal, and this patch can be cherry-picked > into all affected releases. > > [Test case] > Run this test on P9 node baltar, on which this timeout issue can be > 100% reproduced. With this patch applied, the test can finish without > being terminated by the default timeout. > > [Where problems could occur] > This will make test takes longer to finish, but it's still being > controlled by the timeout mechanism both in the test case and > kselftest framework. It's unlikely to make the test hang forever. > > Po-Hsu Lin (1): > selftests/powerpc/eeh: disable kselftest timeout setting for eeh-basic > > tools/testing/selftests/powerpc/eeh/Makefile | 2 +- > tools/testing/selftests/powerpc/eeh/settings | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > create mode 100644 tools/testing/selftests/powerpc/eeh/settings > > -- > 2.7.4 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team
[Impact] The breakable devices test is hardware-dependent. In our test pool it will take about: * 30 seconds to run on a Power8 system that with 5 breakable devices, * 60 seconds to run on a Power9 system that with 4 breakable devices. The default 45 seconds kselftest framework timeout is not enough to allow this test to finish on some nodes. Thus causing this test to fail with TIMEOUT error. [Fix] * f5eca0b279117f ("selftests/powerpc/eeh: disable kselftest timeout setting for eeh-basic") We have this testcase since Focal, and this patch can be cherry-picked into all affected releases. [Test case] Run this test on P9 node baltar, on which this timeout issue can be 100% reproduced. With this patch applied, the test can finish without being terminated by the default timeout. [Where problems could occur] This will make test takes longer to finish, but it's still being controlled by the timeout mechanism both in the test case and kselftest framework. It's unlikely to make the test hang forever. Po-Hsu Lin (1): selftests/powerpc/eeh: disable kselftest timeout setting for eeh-basic tools/testing/selftests/powerpc/eeh/Makefile | 2 +- tools/testing/selftests/powerpc/eeh/settings | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 tools/testing/selftests/powerpc/eeh/settings