From patchwork Wed Aug 5 03:02:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hui Wang X-Patchwork-Id: 1341064 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BLxJG0RRfz9sRK; Wed, 5 Aug 2020 13:02:52 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1k39hV-0000br-0L; Wed, 05 Aug 2020 03:02:45 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1k39hU-0000bk-3n for kernel-team@lists.ubuntu.com; Wed, 05 Aug 2020 03:02:44 +0000 Received: from [114.252.213.24] (helo=localhost.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1k39hT-0004ZT-4A for kernel-team@lists.ubuntu.com; Wed, 05 Aug 2020 03:02:43 +0000 From: Hui Wang To: kernel-team@lists.ubuntu.com Subject: [SRU][OEM-5.6][PATCH 0/1] alsa: should not load sof driver if the internal mic connects to the codec Date: Wed, 5 Aug 2020 11:02:27 +0800 Message-Id: <20200805030228.15386-1-hui.wang@canonical.com> X-Mailer: git-send-email 2.17.1 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/1890231 This issue was introduced by #1872916 ("Support Intel Soundwire in 5.6-OEM Kernel 20.04"), so focal and groovy kernels don't need this fix. [Impact] We found the sof driver instead of hda driver is enabled on a dell machine without soundwire and dmic. This will make gnome show dummy output and users have no audio device to use. [Fix] When we integrated fix for #1872916, we backported 2 patches, these 2 patches enable the sof driver unconditionally for Dell comet lake machines. There is an upstream patch to fix it, let the sof driver enable conditionally on comet lake machines. [Test Case] Boot the kernel with this patch on that dell machine, check the gnome-control-center, all audio devices exist, playback and recording work well. [Regression Risk] On the Dell comet lake machines with dmic, the sof driver should enable. Without this patch, the sof driver will enable unconditionally, but with this patch, the sof driver will enable conditionally, so it is possible to introduce a regression that on Dell comet machines, the sof driver doesn't enable even the machine has dmic. I have tested this patch on a Dell comet lake dmic machines, it worked well. Pierre-Louis Bossart (1): ALSA: hda: add autodetection for SoundWire sound/hda/intel-dsp-config.c | 23 ++++++++++++++++++----- 1 file changed, 18 insertions(+), 5 deletions(-)