Message ID | 20200730065500.13525-1-ike.pan@canonical.com |
---|---|
Headers | show |
Series | Update SEC driver parameter | expand |
On Thu, Jul 30, 2020 at 02:55:00PM +0800, Ike Panhc wrote: > BugLink: https://launchpad.net/bugs/1867900 Acked-by: Paolo Pisati <paolo.pisati@canonical.com>
On 30.07.20 08:55, Ike Panhc wrote: > BugLink: https://launchpad.net/bugs/1867900 > > We have a patch sent to upstream mailing list to enlarge SEC driver > capability from 2 to 256 so that cpu stress-ng test passed. This > patch has been tested and hit no issue with cpu stress test. > > This patch has not yet hit mainline kernel but has been ACK from > maintainer. Though it does not have stable hash number but this patch > is really simple, only 2 define number changed. > > On focal kernel, hisi_sec2 has been disable temporarily so that > cpu stress test will use no accelerator and pass. First patch is > to revert that so that on d06 system we will have accelerator and > for focal kernel only. > > Second patch is to enlarge the capability for SEC driver and > expect to hit mainline kernel in 5.9 merge window. I am happy to > send this patchset again when stable hash available if it makes > ubuntu delta much easy to maintain. > > Ike Panhc (2): > Revert "UBUNTU: [Config] Disable hisi_sec2 temporarily" > crypto: hisilicon - update SEC driver module parameter > > debian.master/abi/5.4.0-41.45/arm64/generic.modules | 1 + > debian.master/config/annotations | 2 +- > debian.master/config/config.common.ubuntu | 2 +- > drivers/crypto/hisilicon/sec2/sec_main.c | 6 +++--- > 4 files changed, 6 insertions(+), 5 deletions(-) > The testcase was fixed at least in Focal with 5.4.0-40.44. Now you want to re-enable things. This is not the same bug and you cannot just reset the old bug report and submit new changes within the other thread. Open a new bug report and start a new submission thread on the mailing list. -Stefan
On 30/07/2020 10:25, Stefan Bader wrote: > On 30.07.20 08:55, Ike Panhc wrote: >> BugLink: https://launchpad.net/bugs/1867900 >> >> We have a patch sent to upstream mailing list to enlarge SEC driver >> capability from 2 to 256 so that cpu stress-ng test passed. This >> patch has been tested and hit no issue with cpu stress test. >> >> This patch has not yet hit mainline kernel but has been ACK from >> maintainer. Though it does not have stable hash number but this patch >> is really simple, only 2 define number changed. >> >> On focal kernel, hisi_sec2 has been disable temporarily so that >> cpu stress test will use no accelerator and pass. First patch is >> to revert that so that on d06 system we will have accelerator and >> for focal kernel only. >> >> Second patch is to enlarge the capability for SEC driver and >> expect to hit mainline kernel in 5.9 merge window. I am happy to >> send this patchset again when stable hash available if it makes >> ubuntu delta much easy to maintain. >> >> Ike Panhc (2): >> Revert "UBUNTU: [Config] Disable hisi_sec2 temporarily" >> crypto: hisilicon - update SEC driver module parameter >> >> debian.master/abi/5.4.0-41.45/arm64/generic.modules | 1 + >> debian.master/config/annotations | 2 +- >> debian.master/config/config.common.ubuntu | 2 +- >> drivers/crypto/hisilicon/sec2/sec_main.c | 6 +++--- >> 4 files changed, 6 insertions(+), 5 deletions(-) >> > The testcase was fixed at least in Focal with 5.4.0-40.44. Now you want to > re-enable things. This is not the same bug and you cannot just reset the old bug > report and submit new changes within the other thread. > Open a new bug report and start a new submission thread on the mailing list. > > -Stefan > > Good point Stefan. I was looking at the technicalities and overlooked this. Colin