| Message ID | 20200413023335.6629-1-hui.wang@canonical.com |
|---|---|
| Headers | show |
| Series | alsa/sof: headphone can't be detected when sof driver enters rt_suspend | expand |
LGTM. Acked-by: Kamal Mostafa <kamal@canonical.com> -Kamal On Mon, Apr 13, 2020 at 10:33:31AM +0800, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1872380 > > This patchset is already in the linux-oem-osp1 and focal, so only eoan > kernel needs this patchset > > > [Impact] > When users plug a headset/headphone into the audio jack, the driver > can't detect them, if users open the gnome-sound-setting, then the > driver could detect them. > > [Fix] > Before driver enters runtime_suspend, need to set the WAKEEN, then > the plug/unplugging will trigger unsol event to the driver. > > [Test Case] > boot the kenrel, plug/unplug the headset/headphone, run amixer contents > to check the "Jack Headpone" state > > [Regression Risk] > Low, those patches come from mainline kernel, I have tested those patches > on Dell and Lenovo machines, they all worked well. > > Fred Oh (1): > ASoC: SOF: remove unused state variable in suspend function > > Keyon Jie (1): > ASoC: SOF: Intel: hda: correct ROM state mask > > Rander Wang (2): > ASoC: SOF: Intel: hda: reduce ifdef usage for hda > ASoC: SOF: Intel: hda: Enable jack detection > > sound/soc/sof/intel/hda-codec.c | 44 +++++++++++++++++++++++++++-- > sound/soc/sof/intel/hda-dsp.c | 49 ++++++++++++++++----------------- > sound/soc/sof/intel/hda.h | 8 ++++-- > sound/soc/sof/ops.h | 9 +++--- > sound/soc/sof/pm.c | 4 +-- > sound/soc/sof/sof-priv.h | 5 ++-- > 6 files changed, 78 insertions(+), 41 deletions(-) > > -- > 2.17.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team
On 13.04.20 04:33, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1872380 > > This patchset is already in the linux-oem-osp1 and focal, so only eoan > kernel needs this patchset > > > [Impact] > When users plug a headset/headphone into the audio jack, the driver > can't detect them, if users open the gnome-sound-setting, then the > driver could detect them. > > [Fix] > Before driver enters runtime_suspend, need to set the WAKEEN, then > the plug/unplugging will trigger unsol event to the driver. > > [Test Case] > boot the kenrel, plug/unplug the headset/headphone, run amixer contents > to check the "Jack Headpone" state > > [Regression Risk] > Low, those patches come from mainline kernel, I have tested those patches > on Dell and Lenovo machines, they all worked well. > > Fred Oh (1): > ASoC: SOF: remove unused state variable in suspend function > > Keyon Jie (1): > ASoC: SOF: Intel: hda: correct ROM state mask > > Rander Wang (2): > ASoC: SOF: Intel: hda: reduce ifdef usage for hda > ASoC: SOF: Intel: hda: Enable jack detection > > sound/soc/sof/intel/hda-codec.c | 44 +++++++++++++++++++++++++++-- > sound/soc/sof/intel/hda-dsp.c | 49 ++++++++++++++++----------------- > sound/soc/sof/intel/hda.h | 8 ++++-- > sound/soc/sof/ops.h | 9 +++--- > sound/soc/sof/pm.c | 4 +-- > sound/soc/sof/sof-priv.h | 5 ++-- > 6 files changed, 78 insertions(+), 41 deletions(-) > Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
On 2020-04-13 10:33:31 , Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1872380 > > This patchset is already in the linux-oem-osp1 and focal, so only eoan > kernel needs this patchset > > > [Impact] > When users plug a headset/headphone into the audio jack, the driver > can't detect them, if users open the gnome-sound-setting, then the > driver could detect them. > > [Fix] > Before driver enters runtime_suspend, need to set the WAKEEN, then > the plug/unplugging will trigger unsol event to the driver. > > [Test Case] > boot the kenrel, plug/unplug the headset/headphone, run amixer contents > to check the "Jack Headpone" state > > [Regression Risk] > Low, those patches come from mainline kernel, I have tested those patches > on Dell and Lenovo machines, they all worked well. > > Fred Oh (1): > ASoC: SOF: remove unused state variable in suspend function > > Keyon Jie (1): > ASoC: SOF: Intel: hda: correct ROM state mask > > Rander Wang (2): > ASoC: SOF: Intel: hda: reduce ifdef usage for hda > ASoC: SOF: Intel: hda: Enable jack detection > > sound/soc/sof/intel/hda-codec.c | 44 +++++++++++++++++++++++++++-- > sound/soc/sof/intel/hda-dsp.c | 49 ++++++++++++++++----------------- > sound/soc/sof/intel/hda.h | 8 ++++-- > sound/soc/sof/ops.h | 9 +++--- > sound/soc/sof/pm.c | 4 +-- > sound/soc/sof/sof-priv.h | 5 ++-- > 6 files changed, 78 insertions(+), 41 deletions(-) > Applied to Eoan/master-next. Thank you! -Kelsey > -- > 2.17.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team