| Message ID | 20200407071448.16335-1-hui.wang@canonical.com |
|---|---|
| Headers | show |
| Series | alsa: make the dmic detection align to the mainline kernel-5.6 | expand |
On Tue, Apr 07, 2020 at 03:14:36PM +0800, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1871284 > > This patchset is already in the upstream kernel-5.6, so no need to > send for unstable. > And this patchset will remove an existing kernel module and add a new > kernel module, so need to change the ABI/modules.ignore manually. > The module removed: snd-intel-nhlt.ko > The module added: snd-intel-dspcfg.ko > > [Impact] > There is already dmic detection code in the eoan and focal kernel, it > works well on CNL/WHL and later Intel platforms, but it doesn't work > on KBL, SKL and old Intel machines. > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1869799/comments/14 > > [Fix] > The upstream kernel updated the dmic detection code, it will exclude the > old intel machines by default. Then the old machines will use legacy hda > driver like before. > > [Test Case] > Install the testing kernel to Dell/LENOVO WHL/CNL and later machines, > they work as well as before. > > And a user verifed the testing kernel work on his KBL machine. > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1869799/comments/17 > > [Regression Risk] > Low, those patches come from mainline kernel, I have tested those patches > on the WHL/CNL and later machiens, a user tested it on a KBL machine. On the config change, it looks like you forgot to run updateconfigs (as I see additional changes when running it), and the annotations file does not carry annotations for options which are not user selectable. Since these options are only selected by other options, you should enforce the required user-selectable options instead. Applied to focal/master-next, with the last patch updated with the results of running updateconfigs and removing the annotations changes. Thanks!
On 2020/4/8 上午3:51, Seth Forshee wrote: > On Tue, Apr 07, 2020 at 03:14:36PM +0800, Hui Wang wrote: >> BugLink: https://bugs.launchpad.net/bugs/1871284 >> >> This patchset is already in the upstream kernel-5.6, so no need to >> send for unstable. >> And this patchset will remove an existing kernel module and add a new >> kernel module, so need to change the ABI/modules.ignore manually. >> The module removed: snd-intel-nhlt.ko >> The module added: snd-intel-dspcfg.ko >> >> [Impact] >> There is already dmic detection code in the eoan and focal kernel, it >> works well on CNL/WHL and later Intel platforms, but it doesn't work >> on KBL, SKL and old Intel machines. >> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1869799/comments/14 >> >> [Fix] >> The upstream kernel updated the dmic detection code, it will exclude the >> old intel machines by default. Then the old machines will use legacy hda >> driver like before. >> >> [Test Case] >> Install the testing kernel to Dell/LENOVO WHL/CNL and later machines, >> they work as well as before. >> >> And a user verifed the testing kernel work on his KBL machine. >> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1869799/comments/17 >> >> [Regression Risk] >> Low, those patches come from mainline kernel, I have tested those patches >> on the WHL/CNL and later machiens, a user tested it on a KBL machine. > On the config change, it looks like you forgot to run updateconfigs (as > I see additional changes when running it), and the annotations file does > not carry annotations for options which are not user selectable. Since > these options are only selected by other options, you should enforce the > required user-selectable options instead. > > Applied to focal/master-next, with the last patch updated with the > results of running updateconfigs and removing the annotations changes. OK, got it, Thanks. > Thanks!
Acked-by: Sultan Alsawaf <sultan.alsawaf@canonical.com> On Tue, Apr 07, 2020 at 03:14:36PM +0800, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1871284 > > This patchset is already in the upstream kernel-5.6, so no need to > send for unstable. > And this patchset will remove an existing kernel module and add a new > kernel module, so need to change the ABI/modules.ignore manually. > The module removed: snd-intel-nhlt.ko > The module added: snd-intel-dspcfg.ko > > [Impact] > There is already dmic detection code in the eoan and focal kernel, it > works well on CNL/WHL and later Intel platforms, but it doesn't work > on KBL, SKL and old Intel machines. > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1869799/comments/14 > > [Fix] > The upstream kernel updated the dmic detection code, it will exclude the > old intel machines by default. Then the old machines will use legacy hda > driver like before. > > [Test Case] > Install the testing kernel to Dell/LENOVO WHL/CNL and later machines, > they work as well as before. > > And a user verifed the testing kernel work on his KBL machine. > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1869799/comments/17 > > [Regression Risk] > Low, those patches come from mainline kernel, I have tested those patches > on the WHL/CNL and later machiens, a user tested it on a KBL machine. > > > > Hui Wang (1): > UBUNTU: [Config] SND_INTEL_DSP_CONFIG=m > > Jaroslav Kysela (1): > ALSA: hda: add Intel DSP configuration / probe code > > Pierre-Louis Bossart (1): > ALSA: hda: fix intel DSP config > > Takashi Iwai (3): > ALSA: hda: Allow non-Intel device probe gracefully > ALSA: hda: More constifications > ALSA: hda: Rename back to dmic_detect option > > debian.master/config/annotations | 5 + > debian.master/config/config.common.ubuntu | 3 +- > include/sound/intel-dsp-config.h | 34 +++ > sound/hda/Kconfig | 10 +- > sound/hda/Makefile | 5 +- > sound/hda/hdac_device.c | 4 +- > sound/hda/hdmi_chmap.c | 2 +- > sound/hda/intel-dsp-config.c | 357 ++++++++++++++++++++++ > sound/hda/intel-nhlt.c | 5 +- > sound/pci/hda/Kconfig | 11 +- > sound/pci/hda/hda_codec.c | 6 +- > sound/pci/hda/hda_eld.c | 6 +- > sound/pci/hda/hda_intel.c | 58 ++-- > sound/pci/hda/hda_proc.c | 2 +- > sound/pci/hda/hda_sysfs.c | 2 +- > sound/pci/hda/patch_analog.c | 2 +- > sound/pci/hda/patch_ca0132.c | 18 +- > sound/soc/intel/Kconfig | 2 +- > sound/soc/intel/skylake/skl.c | 19 +- > sound/soc/sof/intel/Kconfig | 2 +- > sound/soc/sof/sof-pci-dev.c | 6 + > 21 files changed, 465 insertions(+), 94 deletions(-) > create mode 100644 include/sound/intel-dsp-config.h > create mode 100644 sound/hda/intel-dsp-config.c > > -- > 2.17.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team
On 07.04.20 09:14, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1871284 > > This patchset is already in the upstream kernel-5.6, so no need to > send for unstable. > And this patchset will remove an existing kernel module and add a new > kernel module, so need to change the ABI/modules.ignore manually. > The module removed: snd-intel-nhlt.ko > The module added: snd-intel-dspcfg.ko > > [Impact] > There is already dmic detection code in the eoan and focal kernel, it > works well on CNL/WHL and later Intel platforms, but it doesn't work > on KBL, SKL and old Intel machines. > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1869799/comments/14 > > [Fix] > The upstream kernel updated the dmic detection code, it will exclude the > old intel machines by default. Then the old machines will use legacy hda > driver like before. > > [Test Case] > Install the testing kernel to Dell/LENOVO WHL/CNL and later machines, > they work as well as before. > > And a user verifed the testing kernel work on his KBL machine. > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1869799/comments/17 > > [Regression Risk] > Low, those patches come from mainline kernel, I have tested those patches > on the WHL/CNL and later machiens, a user tested it on a KBL machine. > > > > Hui Wang (1): > UBUNTU: [Config] SND_INTEL_DSP_CONFIG=m > > Jaroslav Kysela (1): > ALSA: hda: add Intel DSP configuration / probe code > > Pierre-Louis Bossart (1): > ALSA: hda: fix intel DSP config > > Takashi Iwai (3): > ALSA: hda: Allow non-Intel device probe gracefully > ALSA: hda: More constifications > ALSA: hda: Rename back to dmic_detect option > > debian.master/config/annotations | 5 + > debian.master/config/config.common.ubuntu | 3 +- > include/sound/intel-dsp-config.h | 34 +++ > sound/hda/Kconfig | 10 +- > sound/hda/Makefile | 5 +- > sound/hda/hdac_device.c | 4 +- > sound/hda/hdmi_chmap.c | 2 +- > sound/hda/intel-dsp-config.c | 357 ++++++++++++++++++++++ > sound/hda/intel-nhlt.c | 5 +- > sound/pci/hda/Kconfig | 11 +- > sound/pci/hda/hda_codec.c | 6 +- > sound/pci/hda/hda_eld.c | 6 +- > sound/pci/hda/hda_intel.c | 58 ++-- > sound/pci/hda/hda_proc.c | 2 +- > sound/pci/hda/hda_sysfs.c | 2 +- > sound/pci/hda/patch_analog.c | 2 +- > sound/pci/hda/patch_ca0132.c | 18 +- > sound/soc/intel/Kconfig | 2 +- > sound/soc/intel/skylake/skl.c | 19 +- > sound/soc/sof/intel/Kconfig | 2 +- > sound/soc/sof/sof-pci-dev.c | 6 + > 21 files changed, 465 insertions(+), 94 deletions(-) > create mode 100644 include/sound/intel-dsp-config.h > create mode 100644 sound/hda/intel-dsp-config.c > Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
On 2020-04-07 15:14:36 , Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1871284 > > This patchset is already in the upstream kernel-5.6, so no need to > send for unstable. > And this patchset will remove an existing kernel module and add a new > kernel module, so need to change the ABI/modules.ignore manually. > The module removed: snd-intel-nhlt.ko > The module added: snd-intel-dspcfg.ko > > [Impact] > There is already dmic detection code in the eoan and focal kernel, it > works well on CNL/WHL and later Intel platforms, but it doesn't work > on KBL, SKL and old Intel machines. > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1869799/comments/14 > > [Fix] > The upstream kernel updated the dmic detection code, it will exclude the > old intel machines by default. Then the old machines will use legacy hda > driver like before. > > [Test Case] > Install the testing kernel to Dell/LENOVO WHL/CNL and later machines, > they work as well as before. > > And a user verifed the testing kernel work on his KBL machine. > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1869799/comments/17 > > [Regression Risk] > Low, those patches come from mainline kernel, I have tested those patches > on the WHL/CNL and later machiens, a user tested it on a KBL machine. > > Applied to Eoan/master-next. Made the same changes to the last commit as Seth which was to updateconfigs, remove annotations changes, and add snd-intel-nhlt to modules.ignore. Thanks! -Kelsey > > Hui Wang (1): > UBUNTU: [Config] SND_INTEL_DSP_CONFIG=m > > Jaroslav Kysela (1): > ALSA: hda: add Intel DSP configuration / probe code > > Pierre-Louis Bossart (1): > ALSA: hda: fix intel DSP config > > Takashi Iwai (3): > ALSA: hda: Allow non-Intel device probe gracefully > ALSA: hda: More constifications > ALSA: hda: Rename back to dmic_detect option > > debian.master/config/annotations | 5 + > debian.master/config/config.common.ubuntu | 3 +- > include/sound/intel-dsp-config.h | 34 +++ > sound/hda/Kconfig | 10 +- > sound/hda/Makefile | 5 +- > sound/hda/hdac_device.c | 4 +- > sound/hda/hdmi_chmap.c | 2 +- > sound/hda/intel-dsp-config.c | 357 ++++++++++++++++++++++ > sound/hda/intel-nhlt.c | 5 +- > sound/pci/hda/Kconfig | 11 +- > sound/pci/hda/hda_codec.c | 6 +- > sound/pci/hda/hda_eld.c | 6 +- > sound/pci/hda/hda_intel.c | 58 ++-- > sound/pci/hda/hda_proc.c | 2 +- > sound/pci/hda/hda_sysfs.c | 2 +- > sound/pci/hda/patch_analog.c | 2 +- > sound/pci/hda/patch_ca0132.c | 18 +- > sound/soc/intel/Kconfig | 2 +- > sound/soc/intel/skylake/skl.c | 19 +- > sound/soc/sof/intel/Kconfig | 2 +- > sound/soc/sof/sof-pci-dev.c | 6 + > 21 files changed, 465 insertions(+), 94 deletions(-) > create mode 100644 include/sound/intel-dsp-config.h > create mode 100644 sound/hda/intel-dsp-config.c > > -- > 2.17.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team