mbox series

[0/1,Focal] Remove the iw_cxgb3 module from kernel

Message ID 20200312092520.14855-1-ike.pan@canonical.com
Headers show
Series Remove the iw_cxgb3 module from kernel | expand

Message

Ike Panhc March 12, 2020, 9:25 a.m. UTC 
Upstream commit 30e0f6cf5acb39cd04316d1eecbf4c6087c7ee02

There is no project related. When I work on RDMA/hns
patches and find out iw_cxgb3 is removed from kernel
as the corresponding HW Chelsio T3 has reached EOL.

Since we won't have any support and update from upstream,
I believe to remove from focal kernel is also a good idea.

This patch is built against the pull request I sent for
RDMA/hns.

Potnuri Bharat Teja (1):
  RDMA/iw_cxgb3: Remove the iw_cxgb3 module from kernel

 .../ABI/stable/sysfs-class-infiniband         |   19 -
 MAINTAINERS                                   |    8 -
 drivers/infiniband/Kconfig                    |    1 -
 drivers/infiniband/hw/Makefile                |    1 -
 drivers/infiniband/hw/cxgb3/Kconfig           |   19 -
 drivers/infiniband/hw/cxgb3/Makefile          |    7 -
 drivers/infiniband/hw/cxgb3/cxio_hal.c        | 1312 ----------
 drivers/infiniband/hw/cxgb3/cxio_hal.h        |  204 --
 drivers/infiniband/hw/cxgb3/cxio_resource.c   |  344 ---
 drivers/infiniband/hw/cxgb3/cxio_resource.h   |   69 -
 drivers/infiniband/hw/cxgb3/cxio_wr.h         |  802 ------
 drivers/infiniband/hw/cxgb3/iwch.c            |  282 --
 drivers/infiniband/hw/cxgb3/iwch.h            |  155 --
 drivers/infiniband/hw/cxgb3/iwch_cm.c         | 2258 -----------------
 drivers/infiniband/hw/cxgb3/iwch_cm.h         |  233 --
 drivers/infiniband/hw/cxgb3/iwch_cq.c         |  230 --
 drivers/infiniband/hw/cxgb3/iwch_ev.c         |  232 --
 drivers/infiniband/hw/cxgb3/iwch_mem.c        |  101 -
 drivers/infiniband/hw/cxgb3/iwch_provider.c   | 1321 ----------
 drivers/infiniband/hw/cxgb3/iwch_provider.h   |  347 ---
 drivers/infiniband/hw/cxgb3/iwch_qp.c         | 1082 --------
 drivers/infiniband/hw/cxgb3/tcb.h             |  632 -----
 include/uapi/rdma/cxgb3-abi.h                 |   82 -
 include/uapi/rdma/rdma_user_ioctl_cmds.h      |    1 -
 24 files changed, 9742 deletions(-)
 delete mode 100644 drivers/infiniband/hw/cxgb3/Kconfig
 delete mode 100644 drivers/infiniband/hw/cxgb3/Makefile
 delete mode 100644 drivers/infiniband/hw/cxgb3/cxio_hal.c
 delete mode 100644 drivers/infiniband/hw/cxgb3/cxio_hal.h
 delete mode 100644 drivers/infiniband/hw/cxgb3/cxio_resource.c
 delete mode 100644 drivers/infiniband/hw/cxgb3/cxio_resource.h
 delete mode 100644 drivers/infiniband/hw/cxgb3/cxio_wr.h
 delete mode 100644 drivers/infiniband/hw/cxgb3/iwch.c
 delete mode 100644 drivers/infiniband/hw/cxgb3/iwch.h
 delete mode 100644 drivers/infiniband/hw/cxgb3/iwch_cm.c
 delete mode 100644 drivers/infiniband/hw/cxgb3/iwch_cm.h
 delete mode 100644 drivers/infiniband/hw/cxgb3/iwch_cq.c
 delete mode 100644 drivers/infiniband/hw/cxgb3/iwch_ev.c
 delete mode 100644 drivers/infiniband/hw/cxgb3/iwch_mem.c
 delete mode 100644 drivers/infiniband/hw/cxgb3/iwch_provider.c
 delete mode 100644 drivers/infiniband/hw/cxgb3/iwch_provider.h
 delete mode 100644 drivers/infiniband/hw/cxgb3/iwch_qp.c
 delete mode 100644 drivers/infiniband/hw/cxgb3/tcb.h
 delete mode 100644 include/uapi/rdma/cxgb3-abi.h

Comments

Seth Forshee March 21, 2020, 12:45 a.m. UTC | #1 
On Thu, Mar 12, 2020 at 05:25:20PM +0800, Ike Panhc wrote:
> Upstream commit 30e0f6cf5acb39cd04316d1eecbf4c6087c7ee02
> 
> There is no project related. When I work on RDMA/hns
> patches and find out iw_cxgb3 is removed from kernel
> as the corresponding HW Chelsio T3 has reached EOL.
> 
> Since we won't have any support and update from upstream,
> I believe to remove from focal kernel is also a good idea.
> 
> This patch is built against the pull request I sent for
> RDMA/hns.

I'm not fully convinced that we should do this. The driver is still in
the upstream 5.4 LTS, so it's likely to receive at least some basic
level of support there, even if only CVE fixes. Is there any other
reason to remove it other than the fact that it was removed upstream?

Thanks,
Seth
Ike Panhc March 23, 2020, 2:07 a.m. UTC | #2 
On 3/21/20 8:45 AM, Seth Forshee wrote:
> On Thu, Mar 12, 2020 at 05:25:20PM +0800, Ike Panhc wrote:
>> Upstream commit 30e0f6cf5acb39cd04316d1eecbf4c6087c7ee02
>>
>> There is no project related. When I work on RDMA/hns
>> patches and find out iw_cxgb3 is removed from kernel
>> as the corresponding HW Chelsio T3 has reached EOL.
>>
>> Since we won't have any support and update from upstream,
>> I believe to remove from focal kernel is also a good idea.
>>
>> This patch is built against the pull request I sent for
>> RDMA/hns.
> 
> I'm not fully convinced that we should do this. The driver is still in
> the upstream 5.4 LTS, so it's likely to receive at least some basic
> level of support there, even if only CVE fixes. Is there any other
> reason to remove it other than the fact that it was removed upstream?
> 
> Thanks,
> Seth
> 

No other reason. Feel free to NAK.

--
Ike
Seth Forshee March 24, 2020, 12:25 p.m. UTC | #3 
On Thu, Mar 12, 2020 at 05:25:20PM +0800, Ike Panhc wrote:
> Upstream commit 30e0f6cf5acb39cd04316d1eecbf4c6087c7ee02
> 
> There is no project related. When I work on RDMA/hns
> patches and find out iw_cxgb3 is removed from kernel
> as the corresponding HW Chelsio T3 has reached EOL.
> 
> Since we won't have any support and update from upstream,
> I believe to remove from focal kernel is also a good idea.
> 
> This patch is built against the pull request I sent for
> RDMA/hns.

I don't see a strong argument for removing this driver, so NAK.