mbox series

[0/4,SRU,B-HWE,D,V3] fix i386 boot crashes, LP: #1838115

Message ID 20190729111922.8611-1-colin.king@canonical.com
Headers show
Series fix i386 boot crashes, LP: #1838115 | expand

Message

Colin Ian King July 29, 2019, 11:19 a.m. UTC
From: Colin Ian King <colin.king@canonical.com>

BugLink: https://bugs.launchpad.net/bugs/1838115

Fix i386 boot crashes and i915 graphics corruption. Upstream fix
3f8fd02b1bf1d7b (" mm/vmalloc: Sync unmappings in 
__purge_vmap_area_lazy()") fixes the core issue, and pull in 3
other prerequesits to allow patch to apply cleanly w/o any
backporting.

Tested on Ubuntu Bionic i386 and amd64 with some stress-testing
with stress-ng --vm 4 --brk 1 for 5 minutes.

Joerg Roedel (3):
  x86/mm: Check for pfn instead of page in vmalloc_sync_one()
  x86/mm: Sync also unmappings in vmalloc_sync_all()
  mm/vmalloc: Sync unmappings in __purge_vmap_area_lazy()

Uladzislau Rezki (Sony) (1):
  mm/vmalloc.c: add priority threshold to __purge_vmap_area_lazy()

 arch/x86/mm/fault.c | 15 ++++++---------
 mm/vmalloc.c        | 27 +++++++++++++++++++++------
 2 files changed, 27 insertions(+), 15 deletions(-)

Comments

Stefan Bader July 29, 2019, 11:38 a.m. UTC | #1
On 29.07.19 13:19, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1838115
> 
> Fix i386 boot crashes and i915 graphics corruption. Upstream fix
> 3f8fd02b1bf1d7b (" mm/vmalloc: Sync unmappings in 
> __purge_vmap_area_lazy()") fixes the core issue, and pull in 3
> other prerequesits to allow patch to apply cleanly w/o any
> backporting.
> 
> Tested on Ubuntu Bionic i386 and amd64 with some stress-testing
> with stress-ng --vm 4 --brk 1 for 5 minutes.
> 
> Joerg Roedel (3):
>   x86/mm: Check for pfn instead of page in vmalloc_sync_one()
>   x86/mm: Sync also unmappings in vmalloc_sync_all()
>   mm/vmalloc: Sync unmappings in __purge_vmap_area_lazy()
> 
> Uladzislau Rezki (Sony) (1):
>   mm/vmalloc.c: add priority threshold to __purge_vmap_area_lazy()
> 
>  arch/x86/mm/fault.c | 15 ++++++---------
>  mm/vmalloc.c        | 27 +++++++++++++++++++++------
>  2 files changed, 27 insertions(+), 15 deletions(-)
> 
I guess that additional pick is not directly related but a little bit feels like
it could help to make kernels survive stress testing somewhat better.
All looking ok to me.

Acked-by: Stefan Bader <stefan.bader@canonical.com>
Stefan Bader July 29, 2019, 2:48 p.m. UTC | #2
On 29.07.19 13:19, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1838115
> 
> Fix i386 boot crashes and i915 graphics corruption. Upstream fix
> 3f8fd02b1bf1d7b (" mm/vmalloc: Sync unmappings in 
> __purge_vmap_area_lazy()") fixes the core issue, and pull in 3
> other prerequesits to allow patch to apply cleanly w/o any
> backporting.
> 
> Tested on Ubuntu Bionic i386 and amd64 with some stress-testing
> with stress-ng --vm 4 --brk 1 for 5 minutes.
> 
> Joerg Roedel (3):
>   x86/mm: Check for pfn instead of page in vmalloc_sync_one()
>   x86/mm: Sync also unmappings in vmalloc_sync_all()
>   mm/vmalloc: Sync unmappings in __purge_vmap_area_lazy()
> 
> Uladzislau Rezki (Sony) (1):
>   mm/vmalloc.c: add priority threshold to __purge_vmap_area_lazy()
> 
>  arch/x86/mm/fault.c | 15 ++++++---------
>  mm/vmalloc.c        | 27 +++++++++++++++++++++------
>  2 files changed, 27 insertions(+), 15 deletions(-)
> 
Applied to disco/master for re-spin (2019.07.01-13). Thanks.

-Stefan
Colin Ian King July 30, 2019, 8:36 a.m. UTC | #3
And also for Bionic (4.15) too please.

On 29/07/2019 12:19, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1838115
> 
> Fix i386 boot crashes and i915 graphics corruption. Upstream fix
> 3f8fd02b1bf1d7b (" mm/vmalloc: Sync unmappings in 
> __purge_vmap_area_lazy()") fixes the core issue, and pull in 3
> other prerequesits to allow patch to apply cleanly w/o any
> backporting.
> 
> Tested on Ubuntu Bionic i386 and amd64 with some stress-testing
> with stress-ng --vm 4 --brk 1 for 5 minutes.
> 
> Joerg Roedel (3):
>   x86/mm: Check for pfn instead of page in vmalloc_sync_one()
>   x86/mm: Sync also unmappings in vmalloc_sync_all()
>   mm/vmalloc: Sync unmappings in __purge_vmap_area_lazy()
> 
> Uladzislau Rezki (Sony) (1):
>   mm/vmalloc.c: add priority threshold to __purge_vmap_area_lazy()
> 
>  arch/x86/mm/fault.c | 15 ++++++---------
>  mm/vmalloc.c        | 27 +++++++++++++++++++++------
>  2 files changed, 27 insertions(+), 15 deletions(-)
>
Seth Forshee July 30, 2019, 3:51 p.m. UTC | #4
On Mon, Jul 29, 2019 at 12:19:18PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1838115
> 
> Fix i386 boot crashes and i915 graphics corruption. Upstream fix
> 3f8fd02b1bf1d7b (" mm/vmalloc: Sync unmappings in 
> __purge_vmap_area_lazy()") fixes the core issue, and pull in 3
> other prerequesits to allow patch to apply cleanly w/o any
> backporting.
> 
> Tested on Ubuntu Bionic i386 and amd64 with some stress-testing
> with stress-ng --vm 4 --brk 1 for 5 minutes.

Applied patches 1, 2, and 4 to eoan/master-next. Patch 3 was in 5.2 and
thus already present in eoan. Thanks!
Stefan Bader Aug. 12, 2019, 1:02 p.m. UTC | #5
On 30.07.19 10:36, Colin Ian King wrote:
> And also for Bionic (4.15) too please.

Nearly missed that. Maybe next time ping someone to add a reminder for the next
cycle. Or submit again for the older release(s). Looking at the bug report there
are people claiming this should go into Xenial, too.

Applied to bionic/master-next. Thanks.

-Stefan
> 
> On 29/07/2019 12:19, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> BugLink: https://bugs.launchpad.net/bugs/1838115
>>
>> Fix i386 boot crashes and i915 graphics corruption. Upstream fix
>> 3f8fd02b1bf1d7b (" mm/vmalloc: Sync unmappings in 
>> __purge_vmap_area_lazy()") fixes the core issue, and pull in 3
>> other prerequesits to allow patch to apply cleanly w/o any
>> backporting.
>>
>> Tested on Ubuntu Bionic i386 and amd64 with some stress-testing
>> with stress-ng --vm 4 --brk 1 for 5 minutes.
>>
>> Joerg Roedel (3):
>>   x86/mm: Check for pfn instead of page in vmalloc_sync_one()
>>   x86/mm: Sync also unmappings in vmalloc_sync_all()
>>   mm/vmalloc: Sync unmappings in __purge_vmap_area_lazy()
>>
>> Uladzislau Rezki (Sony) (1):
>>   mm/vmalloc.c: add priority threshold to __purge_vmap_area_lazy()
>>
>>  arch/x86/mm/fault.c | 15 ++++++---------
>>  mm/vmalloc.c        | 27 +++++++++++++++++++++------
>>  2 files changed, 27 insertions(+), 15 deletions(-)
>>
> 
>