mbox series

[disco,0/3] Fix bfp test_verifier

Message ID 20190201194217.20152-1-cascardo@canonical.com
Headers show
Series Fix bfp test_verifier | expand

Message

Thadeu Lima de Souza Cascardo Feb. 1, 2019, 7:42 p.m. UTC 
The upstream stable release process allow fixes to the bpf verifier without
requiring that the bpf test_verifier selftest still PASS.

That is very unfortunate to our testing process, as we want to make sure we
don't introduce regressions ourselves.

Instead of blindly accepting any failures, I took the path of looking at the
test changes upstream. Clean cherry picks were not always possible, so, in some
cases, I decided to go failure by failure, and fixing up the test with a change
that was already present upstream.

That will make cherry picks even harder in the future, but that's the cost of
maintaining something upstream doesn't care about.

Alexei Starovoitov (1):
  bpf: improve verifier branch analysis

Andrey Ignatov (1):
  selftests/bpf: Test narrow loads with off > 0 in test_verifier

Daniel Borkmann (1):
  bpf: add various test cases to selftests

 tools/testing/selftests/bpf/test_verifier.c | 71 +++++++++++++++++----
 1 file changed, 59 insertions(+), 12 deletions(-)

Comments

Seth Forshee Feb. 1, 2019, 10:27 p.m. UTC | #1 
On Fri, Feb 01, 2019 at 05:42:14PM -0200, Thadeu Lima de Souza Cascardo wrote:
> The upstream stable release process allow fixes to the bpf verifier without
> requiring that the bpf test_verifier selftest still PASS.
> 
> That is very unfortunate to our testing process, as we want to make sure we
> don't introduce regressions ourselves.
> 
> Instead of blindly accepting any failures, I took the path of looking at the
> test changes upstream. Clean cherry picks were not always possible, so, in some
> cases, I decided to go failure by failure, and fixing up the test with a change
> that was already present upstream.
> 
> That will make cherry picks even harder in the future, but that's the cost of
> maintaining something upstream doesn't care about.

Applied, thanks!