From patchwork Fri Jan 18 09:11:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Po-Hsu Lin X-Patchwork-Id: 1027186 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43gwDV37F4z9sLt; Fri, 18 Jan 2019 20:11:37 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1gkQBT-0002RZ-2E; Fri, 18 Jan 2019 09:11:27 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.86_2) (envelope-from ) id 1gkQBR-0002RN-MM for kernel-team@lists.ubuntu.com; Fri, 18 Jan 2019 09:11:25 +0000 Received: from mail-pf1-f198.google.com ([209.85.210.198]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1gkQBR-0005VY-Am for kernel-team@lists.ubuntu.com; Fri, 18 Jan 2019 09:11:25 +0000 Received: by mail-pf1-f198.google.com with SMTP id 82so9607595pfs.20 for ; Fri, 18 Jan 2019 01:11:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=nqkatJ7uLURsbjHVa9jNvjyuTiwSkwPGDCc+BPa4Tmg=; b=Wkycgiwx3RIS2n9FQICjvIBz7u+HOB/oiA0WxfkfG6Vq6clGyGmNy2Px5zIJ9BVNW4 Sk1EpcUPi/8yy0VAempWMfhEfndyE9nuqu06zFmvXUfZ4T8ufPcrT44GUykF+1HnfvIF IzbDFpQ+X04vy4RG6Y2pnW3zmghn0HuzAe5kJdmjBVttA1S4nxbMAL9RzOiCkT3CllN3 5XldszJBCxvQFLxXR+suhhBKJg9mRsAXHYlhOnd1Vm5zcAnHSiDKFEoGpTJsK/Obq4NM fmPM0mTXamNiwBmeDwNnqMDm+Vszv8C8K4WitpXv1xRVJNUlR/lvST0k4iDu5n85LaIv 3T5Q== X-Gm-Message-State: AJcUuke9RWbWjLIXg6CtNv8txgs+l9kpsI0nnbEUdd9rdRm6tj5qunV5 gPCZSVy0Cxg9WetqljU0C6Nt55RBos2EmX5OQNxRYBxH8fpvMNaZEAkmzvw5BdPa4reziUS4E7a gcMktYjqB/f3UcISi4tgGKS1VmOh2H7achj4wPShz X-Received: by 2002:a63:c0f:: with SMTP id b15mr17021644pgl.314.1547802683610; Fri, 18 Jan 2019 01:11:23 -0800 (PST) X-Google-Smtp-Source: ALg8bN4mm44MAIdWfWavpF0IuZoEzA4IsYIq7Zc8Iu0Q3IbcshigS63kEr1m/rHPCkmhYJriE+ifeA== X-Received: by 2002:a63:c0f:: with SMTP id b15mr17021632pgl.314.1547802683222; Fri, 18 Jan 2019 01:11:23 -0800 (PST) Received: from Leggiero.taipei.internal (61-220-137-37.HINET-IP.hinet.net. [61.220.137.37]) by smtp.gmail.com with ESMTPSA id 128sm6738299pfu.129.2019.01.18.01.11.21 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Jan 2019 01:11:22 -0800 (PST) From: Po-Hsu Lin To: kernel-team@lists.ubuntu.com Subject: [B][SRU][PATCH 0/3] selftests: user: return Kselftest Skip code for skipped tests Date: Fri, 18 Jan 2019 17:11:16 +0800 Message-Id: <20190118091119.9108-1-po-hsu.lin@canonical.com> X-Mailer: git-send-email 2.17.1 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/1812198 == Justification == This user_copy test has failed while attempting to insert the test_user_copy module, but this module does not exist in the Bionic KVM kernel as the CONFIG_TEST_USER_COPY was not enabled. # modprobe test_user_copy modprobe: FATAL: Module test_user_copy not found in directory /lib/modules/4.15.0-1028-kvm == Fix == d7d5311 (selftests: user: return Kselftest Skip code for skipped tests) 3c07aae (selftests: kselftest: change KSFT_SKIP=4 instead of KSFT_PASS) c31d02d (selftests: kselftest: Remove outdated comment) This fix will make the test return a skipped retun code if the test_user_copy module does not exist. This patch set can be cherry-picked into Bionic, and we already have it in Cosmic / Disco. For Xenial, it already got d7d5311 and does not need the other two. == Test == With this patch, the test will return "skipped" as expected: $ sudo ./test_user_copy.sh user: module test_user_copy is not found [SKIP] $ echo $? 4 Note that the test framework will need another fix to treat the SKIP return code properly. (bug 1812352) == Regression potential == None, this patch just change the code for the testing tool. Shuah Khan (Samsung OSG) (2): selftests: user: return Kselftest Skip code for skipped tests selftests: kselftest: change KSFT_SKIP=4 instead of KSFT_PASS Thiago Jung Bauermann (1): selftests: kselftest: Remove outdated comment tools/testing/selftests/kselftest.h | 3 +-- tools/testing/selftests/user/test_user_copy.sh | 7 +++++++ 2 files changed, 8 insertions(+), 2 deletions(-) Acked-by: Stefan Bader Acked-by: Kleber Sacilotto de Souza