From patchwork Fri Oct 28 13:57:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bodong Wang X-Patchwork-Id: 1696126 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=m8SrY9P3; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4MzPJ837pCz23kY for ; Sat, 29 Oct 2022 00:57:43 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1ooPrZ-00006f-RU; Fri, 28 Oct 2022 13:57:33 +0000 Received: from mail-co1nam11on2070.outbound.protection.outlook.com ([40.107.220.70] helo=NAM11-CO1-obe.outbound.protection.outlook.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1ooPrX-00006U-6I for kernel-team@lists.ubuntu.com; Fri, 28 Oct 2022 13:57:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aVmePk8N7okA10Rar8HO8vIvbggFoikr+Fw5ONCe92mDxTYzd085If6lO2XmY/adFKhkPfEk5NL3VXpnOqGs2CSctF8nRXezLw0CT8usG0O23gYlbk6KDgpOqKKoNG0yGTgirs1gRAm5sO8aEH7fS5sS4GTRVbkzQ36kgCN853zm+L3iFHv0BSuzLKwRvDuEfa2V24cXQVyZ817b5m6JCqVPGdGPwW/O0wu+bSUOdk1L26ZUCS1fV9HQMIld4PFyDlIoBi+rZD2cwE/DcKl/5GEB9jsoKm8vs8KrGnMiCHe/92XXzGY4AJ5HsVeoxn48qbYnLI1/LKY2UiUTeYARqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4w3FmiWsEWkZnIdpX2S0SWPGus4QxqK0pwtAN1MTm6A=; b=SezjwQZa2q35/Ee73R5/Victka4V/16KvdcU2tUI/iuYpseOHCNzqhTIiRusMli4estWA7m5BPq/NKSwjlyyY0IL2SkkZL+HeeMvTBnLrqZheXxQ+J3x2ui70mU1O/Vu7yW/mePwr8E8I3fjhdssJI7xZVcvoRUQFDx6DzQGDc6XKPbWLI72rZnGcpxJTgHtHNUefQ1FNDxbqboCarpfwiG2LMLM5TdK8/q2llPFrlf2tjm73sqbnw6DsLLQ9ASNJiReU6pNWbwu1/5TCrN4fODq6Gbpxe8JmQrve6lqbG1jhdE9FTLnKzF/Aqgzb70ZWb6/FlaMfYmb6ErfBePXgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=lists.ubuntu.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4w3FmiWsEWkZnIdpX2S0SWPGus4QxqK0pwtAN1MTm6A=; b=m8SrY9P3zWWd6EbqZuZM8IjzGsZo7UqOcu5c3SKJDBM0aAsdFAE+zAtwqUbSraJtjNoT+3SjZzrEc0P0APPWPR/TiNTQGHAhULWmkM649JNPnq+CdlR4vMt1HpmiZXzVzmEJ2aSN2fVP4hej52ByJsuRXbZwUAkb8l+i7+JPhWgEyaOmNUJ4A5EjVqKxse4ATRppLPC6I9AZXbqBDiV8WZSNq1RO9knxbxFL43n8TLH8WwsBlvCAIp5CrkmcBDdqtCrhEymPd78fOrhbdYa7FSCCFiXJ6lOY6eooxtohudz0Orsih7n16QlFjy9ZmU18LOwQDQwy9pyRcc7sYxxKlg== Received: from DS7PR03CA0041.namprd03.prod.outlook.com (2603:10b6:5:3b5::16) by LV2PR12MB5989.namprd12.prod.outlook.com (2603:10b6:408:171::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Fri, 28 Oct 2022 13:57:27 +0000 Received: from DM6NAM11FT038.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b5:cafe::b5) by DS7PR03CA0041.outlook.office365.com (2603:10b6:5:3b5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.29 via Frontend Transport; Fri, 28 Oct 2022 13:57:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DM6NAM11FT038.mail.protection.outlook.com (10.13.173.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.14 via Frontend Transport; Fri, 28 Oct 2022 13:57:26 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Fri, 28 Oct 2022 06:57:24 -0700 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Fri, 28 Oct 2022 06:57:24 -0700 Received: from mtl123.mtl.labs.mlnx (10.127.8.10) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29 via Frontend Transport; Fri, 28 Oct 2022 06:57:23 -0700 Received: from sw-mtx-hparm-006.mtx.labs.mlnx. (sw-mtx-hparm-006.mtx.labs.mlnx [10.9.151.93]) by mtl123.mtl.labs.mlnx (8.14.4/8.14.4) with ESMTP id 29SDvKXX024340; Fri, 28 Oct 2022 16:57:21 +0300 From: Bodong Wang To: Subject: [SRU][F:linux-bluefield][PATCH 00/10] Increase stability with connection tracking offload Date: Fri, 28 Oct 2022 08:57:10 -0500 Message-ID: <1666965440-94070-1-git-send-email-bodong@nvidia.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT038:EE_|LV2PR12MB5989:EE_ X-MS-Office365-Filtering-Correlation-Id: ba264087-60f6-4f6d-d053-08dab8ec58fe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cYB9kMZw1gebrL+ahhXqWZlZ0GLG8ACEk98Vj0ketxLf0BaQoHKqy2oZWz+ohR4yCHVWkAf0Z2GRrGS4Zn2AnLWyCq9YHhveOu9sV1T/voH0Bp4TXDznOJ8ftypV2wvys8/u/eQsE9jk0NKbhveWjQqUhwzXZ9WsnMCXa7APmDF69x9+ggv9kfYf7jWZHHQtK2Hf+hr3MixmcB3xX3bWiFPkgBr8aELnJt2yW1HSV4ZwsDKBPrd9gbWeEoOwstI0ir9fgZXtMwUArd47kjmMHZYFBG3I8mCNt8B4WACcYzv8qUs7QA53E6gXa1DjgKG1zFrL4La6M8tEaO3E2CTzPOkLfp68KDbgnABSGE2LobNyJXJ6L50sCNB6YXqoIHzyauNArfor9V6jefcMcLIYxx6VStAhAfn7wKgdwkoq55uqHGWuggvg1MXDEVwaANpJy4VqZiY8dFXeCrlfWSjh5wD1rHhixg6SXrSLtjbDs/2SkpblHZXH9/yoxzwCBwm7iRK1S09/pPjPq/Ii+d5y0Xlgj35QoQ9ewXSsrpOLpO99SF1Xp0ylsuF3TZBQc3PeWhW7gHaOdDbV5sxkge7SHVzoXcQ/9npjuJQ6mn3m8RTVDecAUH7CXPilXyfjWxVo4lErAd2FR2d2Xz/n94JSFbF+kPH5W5LS1ZEUAGNbFoDsQJNAp5Ri81fRow84iWlRoMx+iFfabPB7aZRYkE0T1Ks2vzMWf7mXx60c3U3jNtvZ6lxfvrkZQGq37SXEHBtqALpqUxkKMnEspMIbDA1Xxw== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(346002)(39860400002)(136003)(376002)(396003)(451199015)(46966006)(40470700004)(36840700001)(2616005)(356005)(336012)(83380400001)(7636003)(36860700001)(86362001)(82740400003)(8936002)(5660300002)(2906002)(47076005)(70586007)(186003)(107886003)(82310400005)(6666004)(26005)(40480700001)(40460700003)(54906003)(316002)(478600001)(6916009)(8676002)(70206006)(4326008)(41300700001)(36756003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 13:57:26.9671 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ba264087-60f6-4f6d-d053-08dab8ec58fe X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT038.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5989 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vlad@nvidia.com, bodong@nvidia.com Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" Currently qdisc ingress handling (sch_handle_ingress()) doesn't set a return value and it is left to the old return value of the caller (__netif_receive_skb_core()) which is RX drop, so if the packet is consumed, caller will stop and return this value as if the packet was dropped. Also, include set of patches to increase stability with connection tracking offload, including reduced cpu load and possible deadlock on cleanup. Eric Dumazet (1): netfilter: conntrack: annotate data-races around ct->timeout Felix Fietkau (1): netfilter: flowtable: fix excessive hw offload attempts after failure Florian Westphal (2): netfilter: conntrack: remove unneeded nf_ct_put netfilter: conntrack: convert to refcount_t api Pablo Neira Ayuso (4): netfilter: flowtable: avoid possible false sharing netfilter: nf_flowtable: expose nf_flow_table_gc_cleanup() netfilter: flowtable: add function to invoke garbage collection immediately netfilter: flowtable: fix stuck flows on cleanup due to pending work Paul Blakey (1): net: Fix return value of qdisc ingress handling on success Yinjun Zhang (1): netfilter: flowtable: Make sure GC works periodically in idle system include/linux/netfilter/nf_conntrack_common.h | 8 +++--- include/net/netfilter/nf_conntrack.h | 6 ++--- include/net/netfilter/nf_flow_table.h | 5 ++++ net/core/dev.c | 4 +++ net/netfilter/nf_conntrack_core.c | 39 +++++++++++++-------------- net/netfilter/nf_conntrack_expect.c | 4 +-- net/netfilter/nf_conntrack_netlink.c | 8 +++--- net/netfilter/nf_conntrack_standalone.c | 4 +-- net/netfilter/nf_flow_table_core.c | 38 ++++++++++++++++---------- net/netfilter/nf_flow_table_offload.c | 8 ++++++ net/netfilter/nf_synproxy_core.c | 1 - net/netfilter/nft_ct.c | 4 +-- net/netfilter/xt_CT.c | 3 +-- net/openvswitch/conntrack.c | 1 - net/sched/act_ct.c | 1 - 15 files changed, 77 insertions(+), 57 deletions(-)