mbox series

[SRU,F:linux-bluefield,0/2] Fix byte count on fragmented packets in tc ct action

Message ID 1633734216-7613-1-git-send-email-bodong@nvidia.com
Headers show
Series Fix byte count on fragmented packets in tc ct action | expand

Message

Bodong Wang Oct. 8, 2021, 11:03 p.m. UTC 
First fragmented packets (frag offset = 0) byte len is zeroed
when stolen by ip_defrag(). And since act_ct update the stats
only afterwards (at end of execute), bytes aren't correctly
accounted for such packets. 1st patch fixed this issue. 2nd patch
from upstream is needed for 1st patch to work.

Paul Blakey (1):
  UBUNTU: SAUCE: net/sched: act_ct: Fix byte count on fragmented packets

wenxu (1):
  net/sched: act_ct: add miss tcf_lastuse_update.

 net/sched/act_ct.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Kleber Sacilotto de Souza Oct. 11, 2021, 10:02 a.m. UTC | #1 
On 09.10.21 01:03, Bodong Wang wrote:
> First fragmented packets (frag offset = 0) byte len is zeroed
> when stolen by ip_defrag(). And since act_ct update the stats
> only afterwards (at end of execute), bytes aren't correctly
> accounted for such packets. 1st patch fixed this issue. 2nd patch
> from upstream is needed for 1st patch to work.
> 
> Paul Blakey (1):
>    UBUNTU: SAUCE: net/sched: act_ct: Fix byte count on fragmented packets
> 
> wenxu (1):
>    net/sched: act_ct: add miss tcf_lastuse_update.
> 
>   net/sched/act_ct.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

Thanks
Stefan Bader Oct. 12, 2021, 7:58 a.m. UTC | #2 
On 09.10.21 01:03, Bodong Wang wrote:
> First fragmented packets (frag offset = 0) byte len is zeroed
> when stolen by ip_defrag(). And since act_ct update the stats
> only afterwards (at end of execute), bytes aren't correctly
> accounted for such packets. 1st patch fixed this issue. 2nd patch
> from upstream is needed for 1st patch to work.
> 
> Paul Blakey (1):
>    UBUNTU: SAUCE: net/sched: act_ct: Fix byte count on fragmented packets
> 
> wenxu (1):
>    net/sched: act_ct: add miss tcf_lastuse_update.
> 
>   net/sched/act_ct.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Luke Nowakowski-Krijger Oct. 13, 2021, 6:38 p.m. UTC | #3 
On Fri, Oct 8, 2021 at 4:10 PM Bodong Wang <bodong@nvidia.com> wrote:

> First fragmented packets (frag offset = 0) byte len is zeroed
> when stolen by ip_defrag(). And since act_ct update the stats
> only afterwards (at end of execute), bytes aren't correctly
> accounted for such packets. 1st patch fixed this issue. 2nd patch
> from upstream is needed for 1st patch to work.
>
> Paul Blakey (1):
>   UBUNTU: SAUCE: net/sched: act_ct: Fix byte count on fragmented packets
>
> wenxu (1):
>   net/sched: act_ct: add miss tcf_lastuse_update.
>
>  net/sched/act_ct.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> --
> 1.8.3.1
>
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>