mbox series

[SRU,F:linux-bluefield,0/1] UBUNTU: SAUCE: pka: Use memory addresses defined in ACPI table

Message ID 1613762559-30398-1-git-send-email-mahantesh@nvidia.com
Headers show
Series UBUNTU: SAUCE: pka: Use memory addresses defined in ACPI table | expand

Message

Mahantesh Salimath Feb. 19, 2021, 7:22 p.m. UTC
Buglink: https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/1916274

SRU Justification:

[Impact]
* ACPI definitions are updated for PKA (public key accelerator) HW on Bluefield platforms (by Mellnox/Nvidia).
* ACPI update requires PKA driver update, else kernel traces will be seen on startup.
* PKA driver won't be loaded and PKA HW will be inaccessible.

[Fix]
* "pka: Use memory addresses defined in ACPI table"

[Testcase]
* On bluefield system startup check if PKA driver is loaded without any errors. Ex:#dmesg | grep -i pka

[Regression Potential]
* For systems where the ACPI update is not applied but PKA driver update is
 applied, will see kernel traces as driver will try to read definitions from
 ACPI which are not present. This will lead to failure in loading of PKA driver
 and PKA HW will be inaccessible. Solution to this is to update ACPI. All new
 bluefield images will have updated ACPI definitions.
* Example kernel trace: [ 9.970155] Call trace:
                        [ 9.972625] pka_drv_probe+0x41c/0x5f0 [mlxbf_pka]

Comments

Stefan Bader Feb. 26, 2021, 8:59 a.m. UTC | #1
On 19.02.21 20:22, Mahantesh Salimath wrote:
> Buglink: https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/1916274
> 
> SRU Justification:
> 
> [Impact]
> * ACPI definitions are updated for PKA (public key accelerator) HW on Bluefield platforms (by Mellnox/Nvidia).
> * ACPI update requires PKA driver update, else kernel traces will be seen on startup.
> * PKA driver won't be loaded and PKA HW will be inaccessible.
> 
> [Fix]
> * "pka: Use memory addresses defined in ACPI table"
> 
> [Testcase]
> * On bluefield system startup check if PKA driver is loaded without any errors. Ex:#dmesg | grep -i pka
> 
> [Regression Potential]
> * For systems where the ACPI update is not applied but PKA driver update is
>  applied, will see kernel traces as driver will try to read definitions from
>  ACPI which are not present. This will lead to failure in loading of PKA driver
>  and PKA HW will be inaccessible. Solution to this is to update ACPI. All new
>  bluefield images will have updated ACPI definitions.
> * Example kernel trace: [ 9.970155] Call trace:
>                         [ 9.972625] pka_drv_probe+0x41c/0x5f0 [mlxbf_pka]
> 
Applied to focal:linux-bluefield/master-next. Thanks.

-Stefan