diff mbox series

lib: add crc16.o if CONFIG_MMC_SPI_CRC_ON for SPL build

Message ID mvmh7foz6mh.fsf@suse.de
State Awaiting Upstream
Delegated to: Tom Rini
Headers show
Series lib: add crc16.o if CONFIG_MMC_SPI_CRC_ON for SPL build | expand

Commit Message

Andreas Schwab Aug. 17, 2021, 10:51 a.m. UTC 
CONFIG_MMC_SPI_CRC_ON needs the crc16 functions, but it was not included
in an SPL build.  For non-SPL builds, crc16.o is already added
unconditionally.  This also removes CONFIG_SPL_YMODEM_SUPPORT from the
sifive board configs, which is only relevant for some ARM boards and was
only set for its side effect of adding crc16.o.
---
 configs/sifive_unleashed_defconfig | 1 -
 configs/sifive_unmatched_defconfig | 1 -
 lib/Makefile                       | 1 +
 3 files changed, 1 insertion(+), 2 deletions(-)

Comments

Tom Rini Sept. 2, 2021, 10:42 p.m. UTC | #1 
On Tue, Aug 17, 2021 at 12:51:34PM +0200, Andreas Schwab wrote:

> CONFIG_MMC_SPI_CRC_ON needs the crc16 functions, but it was not included
> in an SPL build.  For non-SPL builds, crc16.o is already added
> unconditionally.  This also removes CONFIG_SPL_YMODEM_SUPPORT from the
> sifive board configs, which is only relevant for some ARM boards and was
> only set for its side effect of adding crc16.o.

Applied to u-boot/next, thanks!
Bin Meng Sept. 3, 2021, 12:52 a.m. UTC | #2 
On Fri, Sep 3, 2021 at 6:42 AM Tom Rini <trini@konsulko.com> wrote:
>
> On Tue, Aug 17, 2021 at 12:51:34PM +0200, Andreas Schwab wrote:
>
> > CONFIG_MMC_SPI_CRC_ON needs the crc16 functions, but it was not included
> > in an SPL build.  For non-SPL builds, crc16.o is already added
> > unconditionally.  This also removes CONFIG_SPL_YMODEM_SUPPORT from the
> > sifive board configs, which is only relevant for some ARM boards and was
> > only set for its side effect of adding crc16.o.
>
> Applied to u-boot/next, thanks!

I thought I replied this email, but it seems not.

This patch is missing SoB tag.

Regards,
Bin
Tom Rini Sept. 3, 2021, 12:54 a.m. UTC | #3 
On Fri, Sep 03, 2021 at 08:52:18AM +0800, Bin Meng wrote:
> On Fri, Sep 3, 2021 at 6:42 AM Tom Rini <trini@konsulko.com> wrote:
> >
> > On Tue, Aug 17, 2021 at 12:51:34PM +0200, Andreas Schwab wrote:
> >
> > > CONFIG_MMC_SPI_CRC_ON needs the crc16 functions, but it was not included
> > > in an SPL build.  For non-SPL builds, crc16.o is already added
> > > unconditionally.  This also removes CONFIG_SPL_YMODEM_SUPPORT from the
> > > sifive board configs, which is only relevant for some ARM boards and was
> > > only set for its side effect of adding crc16.o.
> >
> > Applied to u-boot/next, thanks!
> 
> I thought I replied this email, but it seems not.
> 
> This patch is missing SoB tag.

Yes, I also saw, but it's also small / obvious enough that it's not
worrisome.  By which I also mean, if you check through the linux kernel,
there's still an occasional no-SoB tag commit.  Not often, but non-zero.
diff mbox series

Patch

diff --git a/configs/sifive_unleashed_defconfig b/configs/sifive_unleashed_defconfig
index fd686dfadc..d6448dbf5e 100644
--- a/configs/sifive_unleashed_defconfig
+++ b/configs/sifive_unleashed_defconfig
@@ -22,7 +22,6 @@  CONFIG_SPL_SEPARATE_BSS=y
 CONFIG_SPL_DM_SPI_FLASH=y
 CONFIG_SPL_DM_RESET=y
 CONFIG_SPL_SPI_LOAD=y
-CONFIG_SPL_YMODEM_SUPPORT=y
 CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_SPL_DM_SEQ_ALIAS=y
 CONFIG_SPL_CLK=y
diff --git a/configs/sifive_unmatched_defconfig b/configs/sifive_unmatched_defconfig
index 6c40a35bc2..59c4a383e0 100644
--- a/configs/sifive_unmatched_defconfig
+++ b/configs/sifive_unmatched_defconfig
@@ -20,7 +20,6 @@  CONFIG_DISPLAY_BOARDINFO=y
 CONFIG_DISPLAY_BOARDINFO_LATE=y
 CONFIG_SPL_SEPARATE_BSS=y
 CONFIG_SPL_DM_RESET=y
-CONFIG_SPL_YMODEM_SUPPORT=y
 CONFIG_CMD_EEPROM=y
 CONFIG_CMD_MEMINFO=y
 CONFIG_CMD_PWM=y
diff --git a/lib/Makefile b/lib/Makefile
index 8ba745faa0..2d29cdad1e 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -88,6 +88,7 @@  endif
 ifdef CONFIG_SPL_BUILD
 obj-$(CONFIG_SPL_YMODEM_SUPPORT) += crc16.o
 obj-$(CONFIG_$(SPL_TPL_)HASH_SUPPORT) += crc16.o
+obj-$(CONFIG_MMC_SPI_CRC_ON) += crc16.o
 obj-y += net_utils.o
 endif
 obj-$(CONFIG_ADDR_MAP) += addr_map.o