diff mbox

[U-Boot,v2,13/16] apalis/colibri_t20/t30: increase tftp blocksize

Message ID f763594b159964a96f461d13d674cf7e86939356.1437426110.git.marcel.ziswiler@toradex.com
State Superseded
Delegated to: Tom Warren
Headers show

Commit Message

Marcel Ziswiler July 20, 2015, 10:35 p.m. UTC
From: Max Krummenacher <max.krummenacher@toradex.com>

Enable CONFIG_IP_DEFRAG and set CONFIG_TFTP_BLOCKSIZE to 16384.
This increases the tftp download speed considerably.

While at it enable CONFIG_TFTP_TSIZE which limits the progress bar to
fifty '#' independent of the downloaded file size.

Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
Changes in v2:
Only limit it to 1536 bytes on Colibri T20 to avoid issues observed
otherwise.

 include/configs/apalis_t30.h  | 3 +++
 include/configs/colibri_t20.h | 3 +++
 include/configs/colibri_t30.h | 3 +++
 3 files changed, 9 insertions(+)

Comments

Stephen Warren July 27, 2015, 7:46 p.m. UTC | #1
On 07/20/2015 04:35 PM, Marcel Ziswiler wrote:
> From: Max Krummenacher <max.krummenacher@toradex.com>
>
> Enable CONFIG_IP_DEFRAG and set CONFIG_TFTP_BLOCKSIZE to 16384.
> This increases the tftp download speed considerably.
>
> While at it enable CONFIG_TFTP_TSIZE which limits the progress bar to
> fifty '#' independent of the downloaded file size.

Does it make sense to enable this feature for all Tegra boards? No point 
in speeding up just a couple of boards ut leaving everything else slow.
Marcel Ziswiler July 28, 2015, 1:38 a.m. UTC | #2
On 27 July 2015 21:46:34 CEST, Stephen Warren <swarren@wwwdotorg.org> wrote:
>On 07/20/2015 04:35 PM, Marcel Ziswiler wrote:
>> From: Max Krummenacher <max.krummenacher@toradex.com>
>>
>> Enable CONFIG_IP_DEFRAG and set CONFIG_TFTP_BLOCKSIZE to 16384.
>> This increases the tftp download speed considerably.
>>
>> While at it enable CONFIG_TFTP_TSIZE which limits the progress bar to
>> fifty '#' independent of the downloaded file size.
>
>Does it make sense to enable this feature for all Tegra boards? No
>point 
>in speeding up just a couple of boards ut leaving everything else slow.

I do agree but unfortunately the same 16 k size does not seem to work on Colibri T20 despite using the exact same ASIX USB to Ethernet chip. I tried to pinpoint the exact reason behind this but so far could not figure it out. I fear it has something to do with this Gizmo/bus arbitration stuff on T20 which has been fixed/improved on T30. Would be interesting to try on a Trimslice but unfortunately we never got our iron back from service.
diff mbox

Patch

diff --git a/include/configs/apalis_t30.h b/include/configs/apalis_t30.h
index 898ccdf..8f7f833 100644
--- a/include/configs/apalis_t30.h
+++ b/include/configs/apalis_t30.h
@@ -60,6 +60,9 @@ 
 
 /* General networking support */
 #define CONFIG_CMD_DHCP
+#define CONFIG_IP_DEFRAG
+#define CONFIG_TFTP_BLOCKSIZE		16384
+#define CONFIG_TFTP_TSIZE
 
 /* Miscellaneous commands */
 #define CONFIG_FAT_WRITE
diff --git a/include/configs/colibri_t20.h b/include/configs/colibri_t20.h
index 4c45ef8..65c4bee 100644
--- a/include/configs/colibri_t20.h
+++ b/include/configs/colibri_t20.h
@@ -48,6 +48,9 @@ 
 
 /* General networking support */
 #define CONFIG_CMD_DHCP
+#define CONFIG_IP_DEFRAG
+#define CONFIG_TFTP_BLOCKSIZE		1536
+#define CONFIG_TFTP_TSIZE
 
 /* LCD support */
 #define CONFIG_LCD
diff --git a/include/configs/colibri_t30.h b/include/configs/colibri_t30.h
index 3ef4778..f91c2e2 100644
--- a/include/configs/colibri_t30.h
+++ b/include/configs/colibri_t30.h
@@ -53,6 +53,9 @@ 
 
 /* General networking support */
 #define CONFIG_CMD_DHCP
+#define CONFIG_IP_DEFRAG
+#define CONFIG_TFTP_BLOCKSIZE		16384
+#define CONFIG_TFTP_TSIZE
 
 /* Miscellaneous commands */
 #define CONFIG_FAT_WRITE