From patchwork Wed Mar 31 08:17:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Simek X-Patchwork-Id: 1460397 X-Patchwork-Delegate: monstr@monstr.eu Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=monstr-eu.20150623.gappssmtp.com header.i=@monstr-eu.20150623.gappssmtp.com header.a=rsa-sha256 header.s=20150623 header.b=rcHa0Ls+; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4F9K1x6wV8z9sW4 for ; Wed, 31 Mar 2021 19:17:57 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C091E828BC; Wed, 31 Mar 2021 10:17:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=monstr-eu.20150623.gappssmtp.com header.i=@monstr-eu.20150623.gappssmtp.com header.b="rcHa0Ls+"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3F034805B4; Wed, 31 Mar 2021 10:17:35 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7C048801FC for ; Wed, 31 Mar 2021 10:17:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=monstr@monstr.eu Received: by mail-ej1-x632.google.com with SMTP id r12so28743338ejr.5 for ; Wed, 31 Mar 2021 01:17:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wJKQuaWItad3RZt6a/rpNya9Adtg3k2hqPLiyZrq0gc=; b=rcHa0Ls+c0n6qyX0PTT923ri0ME6ieE3qZIQqCKFk/qShRWV7jMO86Cxr3eGFZJGkd 7Ob+Q51FoyyJTMgWKDdU5LNlH0XJ+OfFkdYR99JFT2o24YqoRN7+Vt13U7w9ebbl4RSL PiSBOM5x6psTpoTtyqKOjt35Hb8aIlCDAcp0EC4ynFWjlSj4D3P9alt8JXcPkToJoWgo UgYfP7yXPBBmgxGYAHOdgkL+tgKIgHQeHO5wfSwJprALqgj9r36Jh5kjRpuEFmu1P9RF bjMY1nof0D+NLcnZoqhjHsbxuScDBquivjfxxhC8SSlnrbQ3n+ypac8sArOBCUKNTmSV Atpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=wJKQuaWItad3RZt6a/rpNya9Adtg3k2hqPLiyZrq0gc=; b=TKB4Hmrp7s9Zp8BsboaCY8ZlquxhNloMNlOh5P3ixzwdljrhaU7Fj93XHd+gzI3qYM 4+iczTLjDL8Qs5xl7JvO48eMgOYNg4Rhqvk/EzERruqCL6yj37sOZ9SNFkyqIO5ZoGVY mUWM4c4xTkM6JXDiiiMhTUSjmaO9NbIQG8GY5mh8rhP2gkYABvBe7Uk1J69upDsEbqor 46G27gI29k6ttrVsjFQDbHINPq+dPcqtUSluqYoRWt8bjeLCAMdnc2aAW+RoFH8Wu5vd G6sn6AK4OhKpg4EzXB6dTj2KmCuJ2ALm1gKpUrTch2Y+I/chq5vgKzEkDn8WJuGdBQSW KXww== X-Gm-Message-State: AOAM530Qm8/SNXv1DTFSePipmHfOSBOT0dhRtSz0IYDSU4k32Myz1eqR Fo/kOYjahKycpJJ3sb8pVi5Z1n0MGHIijGxv X-Google-Smtp-Source: ABdhPJyIvuX+We9aWVTHjYFf7QT1WUO8CU+8AazZWbJtN6VWtihCGOZY6San1LvEeIV0Ng3kAIdkuQ== X-Received: by 2002:a17:906:358c:: with SMTP id o12mr2325054ejb.156.1617178651886; Wed, 31 Mar 2021 01:17:31 -0700 (PDT) Received: from localhost ([2a02:768:2307:40d6::e05]) by smtp.gmail.com with ESMTPSA id r4sm679060ejd.125.2021.03.31.01.17.31 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 31 Mar 2021 01:17:31 -0700 (PDT) From: Michal Simek To: u-boot@lists.denx.de, git@xilinx.com Cc: Lukasz Majewski Subject: [PATCH 1/6] cmd: dfu: Propagate error if dfu gadget fails Date: Wed, 31 Mar 2021 10:17:20 +0200 Message-Id: X-Mailer: git-send-email 2.31.0 In-Reply-To: References: MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean On systems without usb gadget dfu core fails which was reported by error but command itself returns pass which breaks any usage in a script. That's why propagate error from run_usb_dnl_gadget(). Fixes: 16297cfb2a20 ("usb: new board-specific USB init interface") Signed-off-by: Michal Simek --- Before this patch ZynqMP> run bootcmd_usb_dfu0 No USB device found usb_gadget_initialize failed DFU0: Trying to boot script at 0x20000000 Wrong image format for "source" command DFU0: SCRIPT FAILED: continuing... After ZynqMP> run bootcmd_usb_dfu0 No USB device found usb_gadget_initialize failed DFU0: SCRIPT FAILED: continuing... --- cmd/dfu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/dfu.c b/cmd/dfu.c index ef4f897ce070..4a288f74c2c2 100644 --- a/cmd/dfu.c +++ b/cmd/dfu.c @@ -68,7 +68,7 @@ static int do_dfu(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]) int controller_index = simple_strtoul(usb_controller, NULL, 0); bool retry = false; do { - run_usb_dnl_gadget(controller_index, "usb_dnl_dfu"); + ret = run_usb_dnl_gadget(controller_index, "usb_dnl_dfu"); if (dfu_reinit_needed) { dfu_free_entities();