diff mbox series

mmc: zynq_sdhci: Add weak function prototype

Message ID c60655a509956b8fc3a81671a7dc51157f3973db.1651048030.git.michal.simek@xilinx.com
State Accepted
Commit 155353234ec2259efae88c9973f81a53a2b9afb5
Delegated to: Michal Simek
Headers show
Series mmc: zynq_sdhci: Add weak function prototype | expand

Commit Message

Michal Simek April 27, 2022, 8:27 a.m. UTC 
From: T Karthik Reddy <t.karthik.reddy@xilinx.com>

zynqmp_pm_is_function_supported() which checks feature support on som,
which is implemented in firmware_zynqmp.c driver. As mini configuration
does not use firmware driver, so create a weak function to avoid
compilation error on zynqmp mini configuration.

Signed-off-by: T Karthik Reddy <t.karthik.reddy@xilinx.com>
Acked-by: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 drivers/mmc/zynq_sdhci.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Michal Simek May 3, 2022, 7:15 a.m. UTC | #1 
st 27. 4. 2022 v 10:27 odesílatel Michal Simek <michal.simek@xilinx.com> napsal:
>
> From: T Karthik Reddy <t.karthik.reddy@xilinx.com>
>
> zynqmp_pm_is_function_supported() which checks feature support on som,
> which is implemented in firmware_zynqmp.c driver. As mini configuration
> does not use firmware driver, so create a weak function to avoid
> compilation error on zynqmp mini configuration.
>
> Signed-off-by: T Karthik Reddy <t.karthik.reddy@xilinx.com>
> Acked-by: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
>  drivers/mmc/zynq_sdhci.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mmc/zynq_sdhci.c b/drivers/mmc/zynq_sdhci.c
> index a59d96c6bdad..e978b6798854 100644
> --- a/drivers/mmc/zynq_sdhci.c
> +++ b/drivers/mmc/zynq_sdhci.c
> @@ -79,6 +79,11 @@ __weak int xilinx_pm_request(u32 api_id, u32 arg0, u32 arg1, u32 arg2,
>         return 0;
>  }
>
> +__weak int zynqmp_pm_is_function_supported(const u32 api_id, const u32 id)
> +{
> +       return 1;
> +}
> +
>  #if defined(CONFIG_ARCH_ZYNQMP) || defined(CONFIG_ARCH_VERSAL)
>  /* Default settings for ZynqMP Clock Phases */
>  static const u32 zynqmp_iclk_phases[] = {0, 63, 63, 0, 63,  0,
> --
> 2.36.0
>

Applied.
M
Jaehoon Chung May 6, 2022, 9:30 a.m. UTC | #2 
On 4/27/22 17:27, Michal Simek wrote:
> From: T Karthik Reddy <t.karthik.reddy@xilinx.com>
> 
> zynqmp_pm_is_function_supported() which checks feature support on som,
> which is implemented in firmware_zynqmp.c driver. As mini configuration
> does not use firmware driver, so create a weak function to avoid
> compilation error on zynqmp mini configuration.
> 
> Signed-off-by: T Karthik Reddy <t.karthik.reddy@xilinx.com>
> Acked-by: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>

Reviewed-by: Jaehoon Chung <jh80.chung@samsuhng.com>

Best Regards,
Jaehoon Chung

> ---
> 
>  drivers/mmc/zynq_sdhci.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/mmc/zynq_sdhci.c b/drivers/mmc/zynq_sdhci.c
> index a59d96c6bdad..e978b6798854 100644
> --- a/drivers/mmc/zynq_sdhci.c
> +++ b/drivers/mmc/zynq_sdhci.c
> @@ -79,6 +79,11 @@ __weak int xilinx_pm_request(u32 api_id, u32 arg0, u32 arg1, u32 arg2,
>  	return 0;
>  }
>  
> +__weak int zynqmp_pm_is_function_supported(const u32 api_id, const u32 id)
> +{
> +	return 1;
> +}
> +
>  #if defined(CONFIG_ARCH_ZYNQMP) || defined(CONFIG_ARCH_VERSAL)
>  /* Default settings for ZynqMP Clock Phases */
>  static const u32 zynqmp_iclk_phases[] = {0, 63, 63, 0, 63,  0,
diff mbox series

Patch

diff --git a/drivers/mmc/zynq_sdhci.c b/drivers/mmc/zynq_sdhci.c
index a59d96c6bdad..e978b6798854 100644
--- a/drivers/mmc/zynq_sdhci.c
+++ b/drivers/mmc/zynq_sdhci.c
@@ -79,6 +79,11 @@  __weak int xilinx_pm_request(u32 api_id, u32 arg0, u32 arg1, u32 arg2,
 	return 0;
 }
 
+__weak int zynqmp_pm_is_function_supported(const u32 api_id, const u32 id)
+{
+	return 1;
+}
+
 #if defined(CONFIG_ARCH_ZYNQMP) || defined(CONFIG_ARCH_VERSAL)
 /* Default settings for ZynqMP Clock Phases */
 static const u32 zynqmp_iclk_phases[] = {0, 63, 63, 0, 63,  0,