From patchwork Mon Apr 25 11:26:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 1621880 X-Patchwork-Delegate: marek.vasut@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=siemens.com header.i=@siemens.com header.a=rsa-sha256 header.s=selector2 header.b=a41mnoFx; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Kn2m56Ttvz9s0B for ; Mon, 25 Apr 2022 21:27:01 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 56FA583A96; Mon, 25 Apr 2022 13:26:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=siemens.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=siemens.com header.i=@siemens.com header.b="a41mnoFx"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 990C483A96; Mon, 25 Apr 2022 13:26:52 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2062d.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe1a::62d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4EF0383B4C for ; Mon, 25 Apr 2022 13:26:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=siemens.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jan.kiszka@siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mORvlrR/jYIMblt5tA4Umu4H9zxJsXStSubPsW4d045rAwQGF0v2BJBL4/4Qqj4p7R+A6oK7E3f9hgXg+cupNv4Z40Y5+zsSu6/8xEX+Y2istmR+sS4rNsN4KP0V3U2gBYRxl5WbYFVRtEhIZLb/yn7hytFtnE32en6oM7nfwZzk9gMBshHx4z07JDKMybcx+sklNR0OHrh0HBru+pukunN7bTTG//mZpeSbjFtOZocXmGmM7WoP7hFIVcBL6E3FDIiwnTfu+xrdLIVxeBy+whHy7QgvMlPuDHwQ+GCvM3uE8+oF3x8bxAjLHP+WRuibHGaup2voLQe/zW52B4AVZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LCbYQnfRQjZyYwMJWXxXbG1OqrPbqqCXP+mz74/psww=; b=mc6uMQM+3C4D3Zz1LNcVmC5PafpmwaDarsNQAhxgYxKPlYujUYCsiJSRkQeMIy9Alih331Fx66HvA0Ix1X1xsTXddDPUeYlIFNnwhPGAOBAvUJbf5lJmU83hxOTyBeHFCKF4cuJ/8Sk0ltEp4ZRgDdt09NvGr6lghy7/dcm9qGcYOGI9Kbu3y5Y3q+xUtjBpY8MqfHGrOk0VG0CeCc7elKrd2aoi9C8yHKA3DMPlGcOzRMtVYuIaQrsirttHwyozAnt2S/AWWz/TVkCQUIMRXeRgMKsoosopMMZKUFMTOn8pvhOhO/lDKC6pR6miiXHXbHoznEynQYWS4pVSsGaOhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 194.138.21.73) smtp.rcpttodomain=xilinx.com smtp.mailfrom=siemens.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=siemens.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LCbYQnfRQjZyYwMJWXxXbG1OqrPbqqCXP+mz74/psww=; b=a41mnoFxz6NYpWKeIqe9LuQHBOe7bFAnezhgcQ1HV4V/iHnk4d5pClO+HhuGXhYjcxHYyUOu6nRmFvineE090l9WKEB0C22R0BfNXrte61ZUjAJvS7lvbljb9KGXspAZBoQzwGZg4rMSPUCLANkpo7q+R3Gs2Go45Zyem3n7Kx6rYCv80CpWStnBYBAg3xQU1bdw5NwtYrmad29eSWB0rj4kPo4FLwYvZy3BwrhjqnyRTm8nf8A+e0kRW3p9jDBgOHPQcyGfBZZIZNr7piqIAxBZL2VSuDnSZPAYFgYl9NJM30CWrNJjPb077YTu6AmDoJjYVHTKBi3jF7nwFCa9DA== Received: from AS9PR06CA0481.eurprd06.prod.outlook.com (2603:10a6:20b:49b::6) by PR3PR10MB4112.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:af::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Mon, 25 Apr 2022 11:26:48 +0000 Received: from VE1EUR01FT016.eop-EUR01.prod.protection.outlook.com (2603:10a6:20b:49b:cafe::5a) by AS9PR06CA0481.outlook.office365.com (2603:10a6:20b:49b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15 via Frontend Transport; Mon, 25 Apr 2022 11:26:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 194.138.21.73) smtp.mailfrom=siemens.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=siemens.com; Received-SPF: Pass (protection.outlook.com: domain of siemens.com designates 194.138.21.73 as permitted sender) receiver=protection.outlook.com; client-ip=194.138.21.73; helo=hybrid.siemens.com; Received: from hybrid.siemens.com (194.138.21.73) by VE1EUR01FT016.mail.protection.outlook.com (10.152.2.227) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5186.14 via Frontend Transport; Mon, 25 Apr 2022 11:26:47 +0000 Received: from DEMCHDC89XA.ad011.siemens.net (139.25.226.103) by DEMCHDC9SNA.ad011.siemens.net (194.138.21.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 25 Apr 2022 13:26:47 +0200 Received: from [167.87.72.120] (167.87.72.120) by DEMCHDC89XA.ad011.siemens.net (139.25.226.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 25 Apr 2022 13:26:46 +0200 Message-ID: Date: Mon, 25 Apr 2022 13:26:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 From: Jan Kiszka Subject: [PATCH] usb: dwc3: Fix non-usb3 configurations Content-Language: en-US To: Michal Simek , Marek Vasut , U-Boot Mailing List CC: Angus Ainslie , Kunihiko Hayashi , Simon Glass X-Originating-IP: [167.87.72.120] X-ClientProxiedBy: DEMCHDC89XA.ad011.siemens.net (139.25.226.103) To DEMCHDC89XA.ad011.siemens.net (139.25.226.103) X-TM-AS-Product-Ver: SMEX-14.0.0.3080-8.6.1018-26680.007 X-TM-AS-Result: No-10--10.796700-8.000000 X-TMASE-MatchedRID: 7b4J4c6pmNAE3F90EtBrvV26jZ9TnVh4dhbrF28nm8wPe5gzF3TVt2DP bOrcMjcJUHcBn70iJQcDdOkEWgameDvtgB+lCbJU83XySx28aDY31SSnyvm0TnycvC6I0dJIS1z wNuiBtITfUZT83lbkENP+kXNq5kuZNO35RR31ybMkrBjqqIzVOI9oUcx9VMLgOX/V8P8ail1yZ8 zcONpAscRB0bsfrpPIqxB32o9eGcn/ita+mP1RyAsbkVb+hQfZ3kcllDt5nWjFV540ajXY/pdGX r4AXOyKxc4NWZpLz4s= X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--10.796700-8.000000 X-TMASE-Version: SMEX-14.0.0.3080-8.6.1018-26680.007 X-TM-SNTS-SMTP: 533AB7A5841D151C6D0F7B206F3DC7A75AC5733E4BAF410D99FCB5A9C52D77332000:8 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d8e7f69e-fc4b-456c-3610-08da26ae7c47 X-MS-TrafficTypeDiagnostic: PR3PR10MB4112:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l5mjvgtd1QQ+CF5d7JPT+56QRPGIN3/VANCscWnLDjSXVzUMuXLNbOEhos8HSBJ42/7YxOzWBsqbPjNUMFzD+3ZHUzMObV5PoVIUnqpddMbnaed9TU56/Ik1mdiJmXHAav1iZikwUaefboHpBuycrpNh2YKAPQOh2QtPElNYlIocyNMUdB0fA28PjXf2Mas3pYJ94kXdonnZTPAwSj7IaPLnWRi5nzvwiszwjwXrVac7u1sodzAuInXPPklukDg5zx4lQz2v13rPg2YNu8MAFtRyZZxoGuiUlL/ogEpD8gmaa4ksqRn6jUjyOp16JowFD5tGvirzfPlCCnz5EaHgIdbvVW78xnQzb3qCfEIorRRctQbC5e3fwYgx/krfasEsbLxXZ/yGbFqAjl6NOHkR7uawcb8x0Z+/TwD49Jb5zO3PDl9K0og8s+TAOyf9FLRayKgmuQLlFvZTGwX1uTVhj1aJRFafGXwrNPMTqakkeOTDoA/OaGdJodr+Zoz6iN1CwOTBmggUme9QXueD03esATPTpf6cNC+b54KaP1D2FxtpK1cLTgLa3Qi/b8QwKG7YAt1C4rYV9quGJcL2iwTRA/3gDbaTO28funA1yzMAYx/1Zlq03YQ8YHm0P3FPOkdHLGTo9CEahIOG8QNQm2q3hc002tw3+2KJEY5opXWfqCZ5JVmF22+Sbf4y4sS74I+w9wk2qu+RSMuKVIzLCzbAtXG04tEQmOHzscDGM1UmgPxYU/m6EZjsP4fwF54bFWgpqVyzJSPqQQlcaq0CqULRfg== X-Forefront-Antispam-Report: CIP:194.138.21.73; CTRY:DE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:hybrid.siemens.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(36860700001)(70586007)(4326008)(8676002)(70206006)(82310400005)(16526019)(4744005)(31686004)(508600001)(8936002)(83380400001)(86362001)(26005)(186003)(31696002)(2906002)(6706004)(40460700003)(81166007)(36756003)(5660300002)(54906003)(44832011)(316002)(16576012)(110136005)(956004)(2616005)(47076005)(336012)(356005)(82960400001)(3940600001)(36900700001)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 11:26:47.7014 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d8e7f69e-fc4b-456c-3610-08da26ae7c47 X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38ae3bcd-9579-4fd4-adda-b42e1495d55a; Ip=[194.138.21.73]; Helo=[hybrid.siemens.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR01FT016.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR10MB4112 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean From: Jan Kiszka Missing nodes may also be signaled via -ENODATA. We need to check for that to prevent failing in non-usb3 setups. Furthermore, dev.phy must be NULL'ed in case usb3-phy was not found. Fixes: 142d50fbce7c ("usb: dwc3: Add support for usb3-phy PHY configuration") Signed-off-by: Jan Kiszka Reviewed-by: Michal Simek --- drivers/usb/dwc3/dwc3-generic.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/dwc3-generic.c b/drivers/usb/dwc3/dwc3-generic.c index 6e1a1d066b4..c5310e465cb 100644 --- a/drivers/usb/dwc3/dwc3-generic.c +++ b/drivers/usb/dwc3/dwc3-generic.c @@ -468,9 +468,11 @@ static int dwc3_glue_probe(struct udevice *dev) ret = generic_phy_init(&phy); if (ret) return ret; - } else if (ret != -ENOENT) { + } else if (ret != -ENOENT && ret != -ENODATA) { debug("could not get phy (err %d)\n", ret); return ret; + } else { + phy.dev = NULL; } glue->regs = dev_read_addr(dev);