| Message ID | b3e976bd3b9bbe7061fec5ba0a3b4e78fdd78394.1634556602.git.michal.simek@xilinx.com |
|---|---|
| State | Accepted |
| Commit | f510927d55e44bc06a742cd774515197b5c6c128 |
| Delegated to: | Michal Simek |
| Headers | show |
| Series | xilinx: zynqmp: Handle fallthrough statement properly | expand |
On Mon, Oct 18, 2021 at 2:30 PM Michal Simek <michal.simek@xilinx.com> wrote: > > Now intentional fallthrough in switch-case should be labelled that's why > convert comment. > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov@foundries.io> > --- > > board/xilinx/zynqmp/zynqmp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/board/xilinx/zynqmp/zynqmp.c b/board/xilinx/zynqmp/zynqmp.c > index 064788c89db1..286874ab0597 100644 > --- a/board/xilinx/zynqmp/zynqmp.c > +++ b/board/xilinx/zynqmp/zynqmp.c > @@ -711,7 +711,7 @@ int board_late_init(void) > break; > case SD1_LSHFT_MODE: > puts("LVL_SHFT_"); > - /* fall through */ > + fallthrough; > case SD_MODE1: > puts("SD_MODE1\n"); > if (uclass_get_device_by_name(UCLASS_MMC, > -- > 2.33.1 > -- Best regards, Oleksandr Suvorov Software Engineer T: +380 63 8489656 E: oleksandr.suvorov@foundries.io W: www.foundries.io
On 10/18/21 13:30, Michal Simek wrote: > Now intentional fallthrough in switch-case should be labelled that's why > convert comment. > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > board/xilinx/zynqmp/zynqmp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/board/xilinx/zynqmp/zynqmp.c b/board/xilinx/zynqmp/zynqmp.c > index 064788c89db1..286874ab0597 100644 > --- a/board/xilinx/zynqmp/zynqmp.c > +++ b/board/xilinx/zynqmp/zynqmp.c > @@ -711,7 +711,7 @@ int board_late_init(void) > break; > case SD1_LSHFT_MODE: > puts("LVL_SHFT_"); > - /* fall through */ > + fallthrough; > case SD_MODE1: > puts("SD_MODE1\n"); > if (uclass_get_device_by_name(UCLASS_MMC, > applied. M
diff --git a/board/xilinx/zynqmp/zynqmp.c b/board/xilinx/zynqmp/zynqmp.c index 064788c89db1..286874ab0597 100644 --- a/board/xilinx/zynqmp/zynqmp.c +++ b/board/xilinx/zynqmp/zynqmp.c @@ -711,7 +711,7 @@ int board_late_init(void) break; case SD1_LSHFT_MODE: puts("LVL_SHFT_"); - /* fall through */ + fallthrough; case SD_MODE1: puts("SD_MODE1\n"); if (uclass_get_device_by_name(UCLASS_MMC,
Now intentional fallthrough in switch-case should be labelled that's why convert comment. Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- board/xilinx/zynqmp/zynqmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)