| Message ID | Yd9GYTFKMKlNwdtN@ryzen.fritz.box |
|---|---|
| State | Superseded |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | arm64: imx8mq/imx8mm: cleanup binman configuration | expand |
Hi, > --- a/arch/arm/dts/imx8mm-u-boot.dtsi > +++ b/arch/arm/dts/imx8mm-u-boot.dtsi > @@ -39,7 +39,7 @@ > filename = "u-boot-spl.bin"; > }; > > - 1d-imem { > + 1d_imem { I think it is the other way around. Device tree node names should contain hyphens and not underscores. I couldn't find any references in dtschema though. Maybe I haven't looked hard enough. But you can see linux commit 28d7f0f3f10b, for example. -michael
On Thu, Jan 13, 2022 at 12:42:50PM +0100, Michael Walle wrote: > Hi, > > > --- a/arch/arm/dts/imx8mm-u-boot.dtsi > > +++ b/arch/arm/dts/imx8mm-u-boot.dtsi > > @@ -39,7 +39,7 @@ > > filename = "u-boot-spl.bin"; > > }; > > > > - 1d-imem { > > + 1d_imem { > > I think it is the other way around. Device tree node names should contain > hyphens and not underscores. > > I couldn't find any references in dtschema though. Maybe I haven't looked > hard enough. > > But you can see linux commit 28d7f0f3f10b, for example. > > -michael Hi, I don't know what's right, but every other of these in the i.MX8MM file use _ instead of -, so if at all this makes it consistenly wrong, but at least now it's consistent. ;) If it's wrong, I'm sure someone will step up and rectify it. Cheers, Patrick
Am 2022-01-13 14:16, schrieb Patrick Wildt: > On Thu, Jan 13, 2022 at 12:42:50PM +0100, Michael Walle wrote: >> Hi, >> >> > --- a/arch/arm/dts/imx8mm-u-boot.dtsi >> > +++ b/arch/arm/dts/imx8mm-u-boot.dtsi >> > @@ -39,7 +39,7 @@ >> > filename = "u-boot-spl.bin"; >> > }; >> > >> > - 1d-imem { >> > + 1d_imem { >> >> I think it is the other way around. Device tree node names should >> contain >> hyphens and not underscores. >> >> I couldn't find any references in dtschema though. Maybe I haven't >> looked >> hard enough. >> >> But you can see linux commit 28d7f0f3f10b, for example. >> >> -michael > > Hi, > > I don't know what's right, but every other of these in the i.MX8MM file > use _ instead of -, so if at all this makes it consistenly wrong, but > at least now it's consistent. ;) > > If it's wrong, I'm sure someone will step up and rectify it. Why don't you just change it to the correct naming then? -michael
Hi Patrick,
On 13/01/2022 10:29, Michael Walle wrote:
> Why don't you just change it to the correct naming then?
I agree with Michael: node names should use a dash instead of the
underscore.
dtc complains about it when building with W=2:
arch/arm/dts/imx8mm-evk.dtb: Warning (node_name_chars_strict):
/binman/u-boot-spl-ddr/1d_dmem: Character '_' not recommended in node
name
Thanks,
Fabio Estevam
On Thu, Jan 13, 2022 at 10:40:21AM -0300, Fabio Estevam wrote: > Hi Patrick, > > On 13/01/2022 10:29, Michael Walle wrote: > > > Why don't you just change it to the correct naming then? > > I agree with Michael: node names should use a dash instead of the > underscore. > > dtc complains about it when building with W=2: > > arch/arm/dts/imx8mm-evk.dtb: Warning (node_name_chars_strict): > /binman/u-boot-spl-ddr/1d_dmem: Character '_' not recommended in node name Ok, I'll send a v2 for the patchset in a minute. Cheers, Patrick
diff --git a/arch/arm/dts/imx8mm-u-boot.dtsi b/arch/arm/dts/imx8mm-u-boot.dtsi index 7882fe7316..cc022d46c9 100644 --- a/arch/arm/dts/imx8mm-u-boot.dtsi +++ b/arch/arm/dts/imx8mm-u-boot.dtsi @@ -39,7 +39,7 @@ filename = "u-boot-spl.bin"; }; - 1d-imem { + 1d_imem { filename = "lpddr4_pmu_train_1d_imem.bin"; size = <0x8000>; type = "blob-ext";
One of the blobs was named using a hyphen instead of an underscore, so make it consistent. Signed-off-by: Patrick Wildt <patrick@blueri.se> --- arch/arm/dts/imx8mm-u-boot.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)