Message ID | SY4PR01MB679837C0066B241A7C1F54A2F61A9@SY4PR01MB6798.ausprd01.prod.outlook.com |
---|---|
State | Superseded |
Delegated to: | Andes |
Headers | show |
Series | riscv: dts: add OpenPiton RISC-V board dts support | expand |
Hi Tianrui, On Wed, Jul 07, 2021 at 12:02:00PM +0800, Tianrui Wei wrote: > Previous device tree for OpenPitonemits a warning during compilation, typo: OpenPiton emits ? > thus was rejected by Tom. This commit fixes the previous warning and Tom has actually accepted the patch, so this line could be dropped. > adds dts to the OpenPiton RISC-V board and added the device tree to > MAINTAINER file. > > Signed-off-by: Tianrui Wei <tianrui-wei@outlook.com> > Reported-by: Tom Rini <trini@konsulko.com> > --- > arch/riscv/dts/openpiton-riscv64.dts | 4 ++-- > board/openpiton/riscv64/MAINTAINERS | 3 ++- > 2 files changed, 4 insertions(+), 3 deletions(-) Otherwise, LGTM. Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
Hi Leo, Many thanks for reviewing our patches, we've updated the patch and submitted it. Best regards, Tianrui
diff --git a/arch/riscv/dts/openpiton-riscv64.dts b/arch/riscv/dts/openpiton-riscv64.dts index 45951e1236..abc6016a0b 100644 --- a/arch/riscv/dts/openpiton-riscv64.dts +++ b/arch/riscv/dts/openpiton-riscv64.dts @@ -80,8 +80,8 @@ }; soc { - #address-cells = <1>; - #size-cells = <1>; + #address-cells = <2>; + #size-cells = <2>; compatible = "openpiton,chipset", "simple-bus"; ranges; diff --git a/board/openpiton/riscv64/MAINTAINERS b/board/openpiton/riscv64/MAINTAINERS index f91c000c83..f80f5b0495 100644 --- a/board/openpiton/riscv64/MAINTAINERS +++ b/board/openpiton/riscv64/MAINTAINERS @@ -1,8 +1,9 @@ Openpiton BOARD -M: Tianrui Wei<tianrui-wei@outlook.com> +M: Tianrui Wei <tianrui-wei@outlook.com> S: Maintained F: board/openpiton/riscv64/ F: include/configs/openpiton-riscv64.h F: configs/openpiton_riscv64_defconfig F: configs/openpiton_riscv64_spl_defconfig F: drivers/mmc/piton_mmc.c +F: arch/riscv/dts/openpiton-riscv64.dts
Previous device tree for OpenPitonemits a warning during compilation, thus was rejected by Tom. This commit fixes the previous warning and adds dts to the OpenPiton RISC-V board and added the device tree to MAINTAINER file. Signed-off-by: Tianrui Wei <tianrui-wei@outlook.com> Reported-by: Tom Rini <trini@konsulko.com> --- arch/riscv/dts/openpiton-riscv64.dts | 4 ++-- board/openpiton/riscv64/MAINTAINERS | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-)