Message ID | F09210E57DF486449C294B7BFB865347150304@039-SN1MPN1-002.039d.mgd.msft.net |
---|---|
State | Accepted |
Delegated to: | Stefano Babic |
Headers | show |
On 03/02/2011 02:31 AM, Estevam Fabio-R49496 wrote: > Hi Stefano, > Hi Fabio, > Ping? As I do not see any fix for the current release, I have not yet merged it into u-boot-imx and I will do it when the window is open again. I imagine your patch is an introduction for further patches, where more as one uart is used, right ? Should it belong maybe to the same patchset ? checkpatch reports your patch is corrupted. Strange, I do not why, I have fixed myself. Best regards, Stefano Babic
On 3/2/2011 6:15 AM, Stefano Babic wrote: ... > As I do not see any fix for the current release, I have not yet merged > it into u-boot-imx and I will do it when the window is open again. I > imagine your patch is an introduction for further patches, where more as > one uart is used, right ? Should it belong maybe to the same patchset ? I was working on adding MX25PDK support and I think that that the UART reference should be explicit, as different boards can boot from different UART ports. > checkpatch reports your patch is corrupted. Strange, I do not why, I > have fixed myself. Thanks, I havenĀ“t noticed this. Regards, Fabio Estevam
On 03/02/2011 04:19 PM, Fabio Estevam wrote: > I was working on adding MX25PDK support and I think that that the > UART reference should be explicit, as different boards can boot from > different UART ports. I have applied your patch to u-boot-imx, next branch. Maybe it is easier to you to use it as base for your port. Best regards, Stefano Babic
diff --git a/arch/arm/cpu/arm926ejs/mx25/generic.c b/arch/arm/cpu/arm926ejs/mx25/generic.c index c6e1146..150eb69 100644 --- a/arch/arm/cpu/arm926ejs/mx25/generic.c +++ b/arch/arm/cpu/arm926ejs/mx25/generic.c @@ -145,7 +145,7 @@ int cpu_mmc_init (bd_t * bis) } #ifdef CONFIG_MXC_UART -void mx25_uart_init_pins (void) +void mx25_uart1_init_pins(void) { struct iomuxc_mux_ctl *muxctl; struct iomuxc_pad_ctl *padctl; diff --git a/board/karo/tx25/tx25.c b/board/karo/tx25/tx25.c index dc57d5c..269858c 100644 --- a/board/karo/tx25/tx25.c +++ b/board/karo/tx25/tx25.c @@ -141,9 +141,9 @@ void tx25_fec_init(void) int board_init() { #ifdef CONFIG_MXC_UART - extern void mx25_uart_init_pins(void); + extern void mx25_uart1_init_pins(void); - mx25_uart_init_pins(); + mx25_uart1_init_pins(); #endif /* board id for linux */ gd->bd->bi_arch_number = MACH_TYPE_TX25; -- 1.6.0.4