diff mbox series

drivers: mtd: spi: Use correct 4 byte mode enablement for ISSI SPI flash devices alongside spi-nor-tiny.c subsystem

Message ID CAPE2wM14oXdP-qxTkr45cePwKegv_hoDCsJCQviSVYQn_oZntw@mail.gmail.com
State Rejected
Delegated to: Jagannadha Sutradharudu Teki
Headers show
Series drivers: mtd: spi: Use correct 4 byte mode enablement for ISSI SPI flash devices alongside spi-nor-tiny.c subsystem | expand

Commit Message

Nathan Barrett-Morrison Jan. 26, 2022, 6:52 p.m. UTC
Hi All,

I noticed this was missing from the spi-nor-tiny.c subsystem while trying
to use an ISSI SPI flash device with the U-Boot SPL.

This patch will allow 4 byte addressing mode to be enabled with ISSI flash
devices while inside the U-Boot SPL / using spi-nor-tiny.c.

Sincerely,
Nathan

Comments

Pratyush Yadav Jan. 27, 2022, 10 a.m. UTC | #1
Hi Nathan,

On 26/01/22 01:52PM, Nathan Barrett-Morrison wrote:
> Hi All,
> 
> I noticed this was missing from the spi-nor-tiny.c subsystem while trying
> to use an ISSI SPI flash device with the U-Boot SPL.
> 
> This patch will allow 4 byte addressing mode to be enabled with ISSI flash
> devices while inside the U-Boot SPL / using spi-nor-tiny.c.

Please don't attach patches, send them inline. This makes it easier to 
review it. See the mailing list archive [0] for some examples.

[0] https://lore.kernel.org/u-boot/
diff mbox series

Patch

From 218e00fcaea8c5795e792af09f5d21fc19e3d831 Mon Sep 17 00:00:00 2001
From: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Date: Wed, 26 Jan 2022 13:43:53 -0500
Subject: [PATCH] drivers: mtd: spi: Use correct 4 byte mode enablement for
 ISSI SPI flash devices alongside spi-nor-tiny.c subsystem

Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Cc: Jagan Teki <jagan@amarulasolutions.com>
Cc: Vignesh R <vigneshr@ti.com>
CC: Tom Rini <trini@konsulko.com>
---
 drivers/mtd/spi/spi-nor-tiny.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/spi/spi-nor-tiny.c b/drivers/mtd/spi/spi-nor-tiny.c
index 68152ce3b4..130917aaa8 100644
--- a/drivers/mtd/spi/spi-nor-tiny.c
+++ b/drivers/mtd/spi/spi-nor-tiny.c
@@ -219,6 +219,7 @@  static inline int set_4byte(struct spi_nor *nor, const struct flash_info *info,
 	case SNOR_MFR_MICRON:
 		/* Some Micron need WREN command; all will accept it */
 		need_wren = true;
+	case SNOR_MFR_ISSI:
 	case SNOR_MFR_MACRONIX:
 	case SNOR_MFR_WINBOND:
 		if (need_wren)
-- 
2.34.1