Message ID | CANr=Z=azP3FLrS9rjjUvVcVs97NLau4_QQ6xBfTqNiCxMxizAA@mail.gmail.com |
---|---|
State | Accepted |
Delegated to: | Tom Rini |
Headers | show |
On Tue, May 19, 2015 at 01:56:47PM -0500, Joe Hershberger wrote: > Hi Tom, > > This contains a few bug fixes and features from earlier in the merge window. > > The following changes since commit 0e6b7a28243175ae0874d53b6e6e4eff8548d71f: > > Merge git://git.denx.de/u-boot-samsung (2015-05-18 09:15:15 -0400) > > are available in the git repository at: > > > git://git.denx.de/u-boot-net.git master > > for you to fetch changes up to d6bf59abead4069aa1164951d76a00d91f8f0298: > > net: Remove all calls to net_random_ethaddr() (2015-05-19 13:33:22 -0500) NAK: +(bf537-minotaur) common/built-in.o:(.data.init_sequence_r+0x40): undefined reference to `misc_init_r' +(bf537-pnav) common/built-in.o:(.data.init_sequence_r+0x48): undefined reference to `misc_init_r' +(bf537-srv1) ../board/bf537-srv1/bf537-srv1.c:29:2: error: #endif without #if +(bf537-srv1) make[2]: *** [board/bf537-srv1/bf537-srv1.o] Error 1 +(bf537-srv1) make[1]: *** [board/bf537-srv1] Error 2 w+(bf527-ezkit-v2,bf527-ezkit) ../board/bf527-ezkit/bf527-ezkit.c: In function ‘board_init_enetaddr’: w+(bf527-ezkit-v2,bf527-ezkit) ../board/bf527-ezkit/bf527-ezkit.c:30:7: warning: unused variable ‘valid_mac’
Hi Tom, On Wed, May 20, 2015 at 6:28 AM, Tom Rini <trini@konsulko.com> wrote: > On Tue, May 19, 2015 at 01:56:47PM -0500, Joe Hershberger wrote: > >> Hi Tom, >> >> This contains a few bug fixes and features from earlier in the merge window. >> >> The following changes since commit 0e6b7a28243175ae0874d53b6e6e4eff8548d71f: >> >> Merge git://git.denx.de/u-boot-samsung (2015-05-18 09:15:15 -0400) >> >> are available in the git repository at: >> >> >> git://git.denx.de/u-boot-net.git master >> >> for you to fetch changes up to d6bf59abead4069aa1164951d76a00d91f8f0298: >> >> net: Remove all calls to net_random_ethaddr() (2015-05-19 13:33:22 -0500) > > NAK: > +(bf537-minotaur) common/built-in.o:(.data.init_sequence_r+0x40): > undefined reference to `misc_init_r' > +(bf537-pnav) common/built-in.o:(.data.init_sequence_r+0x48): undefined > reference to `misc_init_r' > +(bf537-srv1) ../board/bf537-srv1/bf537-srv1.c:29:2: error: #endif > without #if > +(bf537-srv1) make[2]: *** [board/bf537-srv1/bf537-srv1.o] Error 1 > +(bf537-srv1) make[1]: *** [board/bf537-srv1] Error 2 > w+(bf527-ezkit-v2,bf527-ezkit) ../board/bf527-ezkit/bf527-ezkit.c: In > function ‘board_init_enetaddr’: > w+(bf527-ezkit-v2,bf527-ezkit) ../board/bf527-ezkit/bf527-ezkit.c:30:7: > warning: unused variable ‘valid_mac’ Sorry about that. Meant to circle back on this one I got the blackfin compiler setup. Should be good now. I ran buildman on it for all blackfin boards. -Joe
On Wed, May 20, 2015 at 12:11:36PM -0500, Joe Hershberger wrote: > Hi Tom, > > On Wed, May 20, 2015 at 6:28 AM, Tom Rini <trini@konsulko.com> wrote: > > On Tue, May 19, 2015 at 01:56:47PM -0500, Joe Hershberger wrote: > > > >> Hi Tom, > >> > >> This contains a few bug fixes and features from earlier in the merge window. > >> > >> The following changes since commit 0e6b7a28243175ae0874d53b6e6e4eff8548d71f: > >> > >> Merge git://git.denx.de/u-boot-samsung (2015-05-18 09:15:15 -0400) > >> > >> are available in the git repository at: > >> > >> > >> git://git.denx.de/u-boot-net.git master > >> > >> for you to fetch changes up to d6bf59abead4069aa1164951d76a00d91f8f0298: > >> > >> net: Remove all calls to net_random_ethaddr() (2015-05-19 13:33:22 -0500) > > > > NAK: > > +(bf537-minotaur) common/built-in.o:(.data.init_sequence_r+0x40): > > undefined reference to `misc_init_r' > > +(bf537-pnav) common/built-in.o:(.data.init_sequence_r+0x48): undefined > > reference to `misc_init_r' > > +(bf537-srv1) ../board/bf537-srv1/bf537-srv1.c:29:2: error: #endif > > without #if > > +(bf537-srv1) make[2]: *** [board/bf537-srv1/bf537-srv1.o] Error 1 > > +(bf537-srv1) make[1]: *** [board/bf537-srv1] Error 2 > > w+(bf527-ezkit-v2,bf527-ezkit) ../board/bf527-ezkit/bf527-ezkit.c: In > > function ‘board_init_enetaddr’: > > w+(bf527-ezkit-v2,bf527-ezkit) ../board/bf527-ezkit/bf527-ezkit.c:30:7: > > warning: unused variable ‘valid_mac’ > > Sorry about that. Meant to circle back on this one I got the blackfin > compiler setup. > > Should be good now. I ran buildman on it for all blackfin boards. I've applied the updated PR. Please address the following in some follow-up patches: w+(lschlv2,lsxhl) ../board/buffalo/lsxl/lsxl.c: In function 'rescue_mode': w+(lschlv2,lsxhl) ../board/buffalo/lsxl/lsxl.c:230:8: warning: unused variable 'enetaddr' [-Wunused-variable] Thanks!
Hi Tom, On Thu, May 21, 2015 at 8:09 AM, Tom Rini <trini@konsulko.com> wrote: > On Wed, May 20, 2015 at 12:11:36PM -0500, Joe Hershberger wrote: >> Hi Tom, >> >> On Wed, May 20, 2015 at 6:28 AM, Tom Rini <trini@konsulko.com> wrote: >> > On Tue, May 19, 2015 at 01:56:47PM -0500, Joe Hershberger wrote: >> > >> >> Hi Tom, >> >> >> >> This contains a few bug fixes and features from earlier in the merge window. >> >> >> >> The following changes since commit 0e6b7a28243175ae0874d53b6e6e4eff8548d71f: >> >> >> >> Merge git://git.denx.de/u-boot-samsung (2015-05-18 09:15:15 -0400) >> >> >> >> are available in the git repository at: >> >> >> >> >> >> git://git.denx.de/u-boot-net.git master >> >> >> >> for you to fetch changes up to d6bf59abead4069aa1164951d76a00d91f8f0298: >> >> >> >> net: Remove all calls to net_random_ethaddr() (2015-05-19 13:33:22 -0500) >> > >> > NAK: >> > +(bf537-minotaur) common/built-in.o:(.data.init_sequence_r+0x40): >> > undefined reference to `misc_init_r' >> > +(bf537-pnav) common/built-in.o:(.data.init_sequence_r+0x48): undefined >> > reference to `misc_init_r' >> > +(bf537-srv1) ../board/bf537-srv1/bf537-srv1.c:29:2: error: #endif >> > without #if >> > +(bf537-srv1) make[2]: *** [board/bf537-srv1/bf537-srv1.o] Error 1 >> > +(bf537-srv1) make[1]: *** [board/bf537-srv1] Error 2 >> > w+(bf527-ezkit-v2,bf527-ezkit) ../board/bf527-ezkit/bf527-ezkit.c: In >> > function ‘board_init_enetaddr’: >> > w+(bf527-ezkit-v2,bf527-ezkit) ../board/bf527-ezkit/bf527-ezkit.c:30:7: >> > warning: unused variable ‘valid_mac’ >> >> Sorry about that. Meant to circle back on this one I got the blackfin >> compiler setup. >> >> Should be good now. I ran buildman on it for all blackfin boards. > > I've applied the updated PR. Please address the following in some > follow-up patches: > w+(lschlv2,lsxhl) ../board/buffalo/lsxl/lsxl.c: In function 'rescue_mode': > w+(lschlv2,lsxhl) ../board/buffalo/lsxl/lsxl.c:230:8: warning: unused variable 'enetaddr' [-Wunused-variable] Will do. Thanks, -Joe