diff mbox series

Add support for Raspberry Pi 3B+(32bit)

Message ID CA+Yy3RsurrPFZwkB320HkfrzyrZDRzjTKSYjCnL=2pRWJs69Yg@mail.gmail.com
State New
Delegated to: Matthias Brugger
Headers show
Series Add support for Raspberry Pi 3B+(32bit) | expand

Commit Message

Toshifumi NISHINAGA April 20, 2021, 6:05 a.m. UTC
Hello all.

I will add rpi_3_32b_plus_defconfig to easy to build u-boot for
Raspberry Pi 3B+(32bit).
Could you merge this patch?

Thanks,
Toshifumi NISHINAGA


From 28d13f48761ab7c137a5fdf07c76a857967e3590 Mon Sep 17 00:00:00 2001
From: Toshifumi NISHINAGA <tnishinaga.dev@gmail.com>
Date: Thu, 15 Apr 2021 16:53:33 +0900
Subject: [PATCH] Add support for Raspberry Pi 3B+(32bit)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

It also boots on Raspberry Pi 3B+ using rpi_3_32b_defconfig,
but the network card doesn't work.

This defconfig is based on rpi_3_32b_defconfig.

Signed-off-by: Toshifumi NISHINAGA <tnishinaga.dev@gmail.com>
---

configs/rpi_3_32b_plus_defconfig | 46 ++++++++++++++++++++++++++++++++
1 file changed, 46 insertions(+)
create mode 100644 configs/rpi_3_32b_plus_defconfig

Comments

Matthias Brugger April 20, 2021, 9:45 a.m. UTC | #1
On 20/04/2021 08:05, Toshifumi NISHINAGA wrote:
> Hello all.
> 
> I will add rpi_3_32b_plus_defconfig to easy to build u-boot for
> Raspberry Pi 3B+(32bit).
> Could you merge this patch?
> 

This file is already present [1]. Please provide patches against the latest
U-Boot tree. Is there anything missing in the config?

Regards,
Matthias

[1]
https://source.denx.de/u-boot/u-boot/-/blob/master/configs/rpi_3_b_plus_defconfig


> Thanks,
> Toshifumi NISHINAGA
> 
> 
> From 28d13f48761ab7c137a5fdf07c76a857967e3590 Mon Sep 17 00:00:00 2001
> From: Toshifumi NISHINAGA <tnishinaga.dev@gmail.com>
> Date: Thu, 15 Apr 2021 16:53:33 +0900
> Subject: [PATCH] Add support for Raspberry Pi 3B+(32bit)
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> It also boots on Raspberry Pi 3B+ using rpi_3_32b_defconfig,
> but the network card doesn't work.
> 
> This defconfig is based on rpi_3_32b_defconfig.
> 
> Signed-off-by: Toshifumi NISHINAGA <tnishinaga.dev@gmail.com>
> ---
> 
> configs/rpi_3_32b_plus_defconfig | 46 ++++++++++++++++++++++++++++++++
> 1 file changed, 46 insertions(+)
> create mode 100644 configs/rpi_3_32b_plus_defconfig
> 
> diff --git a/configs/rpi_3_32b_plus_defconfig b/configs/rpi_3_32b_plus_defconfig
> new file mode 100644
> index 0000000000..d147a46ae7
> --- /dev/null
> +++ b/configs/rpi_3_32b_plus_defconfig
> @@ -0,0 +1,46 @@
> +CONFIG_ARM=y
> +CONFIG_ARCH_CPU_INIT=y
> +CONFIG_ARCH_BCM283X=y
> +CONFIG_SYS_TEXT_BASE=0x00008000
> +CONFIG_TARGET_RPI_3_32B=y
> +CONFIG_SYS_MALLOC_F_LEN=0x2000
> +CONFIG_NR_DRAM_BANKS=1
> +CONFIG_ENV_SIZE=0x4000
> +CONFIG_DEFAULT_DEVICE_TREE="bcm2837-rpi-3-b-plus"
> +CONFIG_DISTRO_DEFAULTS=y
> +CONFIG_OF_BOARD_SETUP=y
> +CONFIG_USE_PREBOOT=y
> +# CONFIG_DISPLAY_CPUINFO is not set
> +# CONFIG_DISPLAY_BOARDINFO is not set
> +CONFIG_MISC_INIT_R=y
> +CONFIG_SYS_PROMPT="U-Boot> "
> +CONFIG_CMD_GPIO=y
> +CONFIG_CMD_MMC=y
> +CONFIG_CMD_USB=y
> +CONFIG_CMD_FS_UUID=y
> +CONFIG_OF_EMBED=y
> +CONFIG_ENV_FAT_DEVICE_AND_PART="0:1"
> +CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> +CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
> +CONFIG_DM_MMC=y
> +CONFIG_MMC_SDHCI=y
> +CONFIG_MMC_SDHCI_BCM2835=y
> +CONFIG_PHYLIB=y
> +CONFIG_DM_ETH=y
> +CONFIG_PINCTRL=y
> +# CONFIG_PINCTRL_GENERIC is not set
> +# CONFIG_REQUIRE_SERIAL_CONSOLE is not set
> +CONFIG_USB=y
> +CONFIG_DM_USB=y
> +CONFIG_USB_DWC2=y
> +CONFIG_USB_KEYBOARD=y
> +CONFIG_USB_HOST_ETHER=y
> +CONFIG_USB_ETHER_LAN78XX=y
> +CONFIG_USB_ETHER_SMSC95XX=y
> +CONFIG_DM_VIDEO=y
> +# CONFIG_VIDEO_BPP8 is not set
> +# CONFIG_VIDEO_BPP16 is not set
> +CONFIG_SYS_WHITE_ON_BLACK=y
> +CONFIG_CONSOLE_SCROLL_LINES=10
> +CONFIG_PHYS_TO_BUS=y
> +CONFIG_OF_LIBFDT_OVERLAY=y
>
Toshifumi NISHINAGA April 20, 2021, 10:18 a.m. UTC | #2
Hello, Matthias.


> This file is already present [1]. Please provide patches against the latest

[1] is for the 64bit mode of Raspberry Pi 3B+, not for the 32bit mode.

The Raspberry Pi 3B has 64bit [2] and 32bit [3] mode configs.

[1]:https://source.denx.de/u-boot/u-boot/-/blob/master/configs/rpi_3_b_plus_defconfig
[2]:https://source.denx.de/u-boot/u-boot/-/blob/master/configs/rpi_3_defconfig
[3]: https://source.denx.de/u-boot/u-boot/-/blob/master/configs/rpi_3_32b_defconfig


Regards,
Toshifumi NISHINAGA


2021年4月20日(火) 18:45 Matthias Brugger <mbrugger@suse.com>:
>
>
>
> On 20/04/2021 08:05, Toshifumi NISHINAGA wrote:
> > Hello all.
> >
> > I will add rpi_3_32b_plus_defconfig to easy to build u-boot for
> > Raspberry Pi 3B+(32bit).
> > Could you merge this patch?
> >
>
> This file is already present [1]. Please provide patches against the latest
> U-Boot tree. Is there anything missing in the config?
>
> Regards,
> Matthias
>
> [1]
> https://source.denx.de/u-boot/u-boot/-/blob/master/configs/rpi_3_b_plus_defconfig
>
>
> > Thanks,
> > Toshifumi NISHINAGA
> >
> >
> > From 28d13f48761ab7c137a5fdf07c76a857967e3590 Mon Sep 17 00:00:00 2001
> > From: Toshifumi NISHINAGA <tnishinaga.dev@gmail.com>
> > Date: Thu, 15 Apr 2021 16:53:33 +0900
> > Subject: [PATCH] Add support for Raspberry Pi 3B+(32bit)
> > MIME-Version: 1.0
> > Content-Type: text/plain; charset=UTF-8
> > Content-Transfer-Encoding: 8bit
> >
> > It also boots on Raspberry Pi 3B+ using rpi_3_32b_defconfig,
> > but the network card doesn't work.
> >
> > This defconfig is based on rpi_3_32b_defconfig.
> >
> > Signed-off-by: Toshifumi NISHINAGA <tnishinaga.dev@gmail.com>
> > ---
> >
> > configs/rpi_3_32b_plus_defconfig | 46 ++++++++++++++++++++++++++++++++
> > 1 file changed, 46 insertions(+)
> > create mode 100644 configs/rpi_3_32b_plus_defconfig
> >
> > diff --git a/configs/rpi_3_32b_plus_defconfig b/configs/rpi_3_32b_plus_defconfig
> > new file mode 100644
> > index 0000000000..d147a46ae7
> > --- /dev/null
> > +++ b/configs/rpi_3_32b_plus_defconfig
> > @@ -0,0 +1,46 @@
> > +CONFIG_ARM=y
> > +CONFIG_ARCH_CPU_INIT=y
> > +CONFIG_ARCH_BCM283X=y
> > +CONFIG_SYS_TEXT_BASE=0x00008000
> > +CONFIG_TARGET_RPI_3_32B=y
> > +CONFIG_SYS_MALLOC_F_LEN=0x2000
> > +CONFIG_NR_DRAM_BANKS=1
> > +CONFIG_ENV_SIZE=0x4000
> > +CONFIG_DEFAULT_DEVICE_TREE="bcm2837-rpi-3-b-plus"
> > +CONFIG_DISTRO_DEFAULTS=y
> > +CONFIG_OF_BOARD_SETUP=y
> > +CONFIG_USE_PREBOOT=y
> > +# CONFIG_DISPLAY_CPUINFO is not set
> > +# CONFIG_DISPLAY_BOARDINFO is not set
> > +CONFIG_MISC_INIT_R=y
> > +CONFIG_SYS_PROMPT="U-Boot> "
> > +CONFIG_CMD_GPIO=y
> > +CONFIG_CMD_MMC=y
> > +CONFIG_CMD_USB=y
> > +CONFIG_CMD_FS_UUID=y
> > +CONFIG_OF_EMBED=y
> > +CONFIG_ENV_FAT_DEVICE_AND_PART="0:1"
> > +CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> > +CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
> > +CONFIG_DM_MMC=y
> > +CONFIG_MMC_SDHCI=y
> > +CONFIG_MMC_SDHCI_BCM2835=y
> > +CONFIG_PHYLIB=y
> > +CONFIG_DM_ETH=y
> > +CONFIG_PINCTRL=y
> > +# CONFIG_PINCTRL_GENERIC is not set
> > +# CONFIG_REQUIRE_SERIAL_CONSOLE is not set
> > +CONFIG_USB=y
> > +CONFIG_DM_USB=y
> > +CONFIG_USB_DWC2=y
> > +CONFIG_USB_KEYBOARD=y
> > +CONFIG_USB_HOST_ETHER=y
> > +CONFIG_USB_ETHER_LAN78XX=y
> > +CONFIG_USB_ETHER_SMSC95XX=y
> > +CONFIG_DM_VIDEO=y
> > +# CONFIG_VIDEO_BPP8 is not set
> > +# CONFIG_VIDEO_BPP16 is not set
> > +CONFIG_SYS_WHITE_ON_BLACK=y
> > +CONFIG_CONSOLE_SCROLL_LINES=10
> > +CONFIG_PHYS_TO_BUS=y
> > +CONFIG_OF_LIBFDT_OVERLAY=y
> >
>
Peter Robinson April 20, 2021, 10:28 a.m. UTC | #3
On Tue, Apr 20, 2021 at 7:05 AM Toshifumi NISHINAGA
<tnishinaga.dev@gmail.com> wrote:
>
> Hello all.
>
> I will add rpi_3_32b_plus_defconfig to easy to build u-boot for
> Raspberry Pi 3B+(32bit).

What does this provide over rpi_3_32b_defconfig? As that config works
just fine on all variants of the RPi3 inc the B, B+, A+ and CM3 I
don't see the point in confusing things with an unnecessary config.

> Could you merge this patch?
>
> Thanks,
> Toshifumi NISHINAGA
>
>
> From 28d13f48761ab7c137a5fdf07c76a857967e3590 Mon Sep 17 00:00:00 2001
> From: Toshifumi NISHINAGA <tnishinaga.dev@gmail.com>
> Date: Thu, 15 Apr 2021 16:53:33 +0900
> Subject: [PATCH] Add support for Raspberry Pi 3B+(32bit)
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> It also boots on Raspberry Pi 3B+ using rpi_3_32b_defconfig,
> but the network card doesn't work.
>
> This defconfig is based on rpi_3_32b_defconfig.
>
> Signed-off-by: Toshifumi NISHINAGA <tnishinaga.dev@gmail.com>
> ---
>
> configs/rpi_3_32b_plus_defconfig | 46 ++++++++++++++++++++++++++++++++
> 1 file changed, 46 insertions(+)
> create mode 100644 configs/rpi_3_32b_plus_defconfig
>
> diff --git a/configs/rpi_3_32b_plus_defconfig b/configs/rpi_3_32b_plus_defconfig
> new file mode 100644
> index 0000000000..d147a46ae7
> --- /dev/null
> +++ b/configs/rpi_3_32b_plus_defconfig
> @@ -0,0 +1,46 @@
> +CONFIG_ARM=y
> +CONFIG_ARCH_CPU_INIT=y
> +CONFIG_ARCH_BCM283X=y
> +CONFIG_SYS_TEXT_BASE=0x00008000
> +CONFIG_TARGET_RPI_3_32B=y
> +CONFIG_SYS_MALLOC_F_LEN=0x2000
> +CONFIG_NR_DRAM_BANKS=1
> +CONFIG_ENV_SIZE=0x4000
> +CONFIG_DEFAULT_DEVICE_TREE="bcm2837-rpi-3-b-plus"
> +CONFIG_DISTRO_DEFAULTS=y
> +CONFIG_OF_BOARD_SETUP=y
> +CONFIG_USE_PREBOOT=y
> +# CONFIG_DISPLAY_CPUINFO is not set
> +# CONFIG_DISPLAY_BOARDINFO is not set
> +CONFIG_MISC_INIT_R=y
> +CONFIG_SYS_PROMPT="U-Boot> "
> +CONFIG_CMD_GPIO=y
> +CONFIG_CMD_MMC=y
> +CONFIG_CMD_USB=y
> +CONFIG_CMD_FS_UUID=y
> +CONFIG_OF_EMBED=y
> +CONFIG_ENV_FAT_DEVICE_AND_PART="0:1"
> +CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> +CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
> +CONFIG_DM_MMC=y
> +CONFIG_MMC_SDHCI=y
> +CONFIG_MMC_SDHCI_BCM2835=y
> +CONFIG_PHYLIB=y
> +CONFIG_DM_ETH=y
> +CONFIG_PINCTRL=y
> +# CONFIG_PINCTRL_GENERIC is not set
> +# CONFIG_REQUIRE_SERIAL_CONSOLE is not set
> +CONFIG_USB=y
> +CONFIG_DM_USB=y
> +CONFIG_USB_DWC2=y
> +CONFIG_USB_KEYBOARD=y
> +CONFIG_USB_HOST_ETHER=y
> +CONFIG_USB_ETHER_LAN78XX=y
> +CONFIG_USB_ETHER_SMSC95XX=y
> +CONFIG_DM_VIDEO=y
> +# CONFIG_VIDEO_BPP8 is not set
> +# CONFIG_VIDEO_BPP16 is not set
> +CONFIG_SYS_WHITE_ON_BLACK=y
> +CONFIG_CONSOLE_SCROLL_LINES=10
> +CONFIG_PHYS_TO_BUS=y
> +CONFIG_OF_LIBFDT_OVERLAY=y
> --
> 2.24.3 (Apple Git-128)
Toshifumi NISHINAGA April 20, 2021, 10:56 a.m. UTC | #4
Hello Peter.

> As that config works
> just fine on all variants of the RPi3 inc the B, B+, A+ and CM3

Yes. It also boots on Raspberry Pi 3B+ using rpi_3_32b_defconfig,
but only the network card doesn't work.
Because the network cards used in the 3B and 3B+ are different.

This difference is hard to notice,
so I want to add a new defconfig for Raspberry Pi 3B+.


Regards,
Toshifumi NISHINAGA

2021年4月20日(火) 19:28 Peter Robinson <pbrobinson@gmail.com>:
>
> On Tue, Apr 20, 2021 at 7:05 AM Toshifumi NISHINAGA
> <tnishinaga.dev@gmail.com> wrote:
> >
> > Hello all.
> >
> > I will add rpi_3_32b_plus_defconfig to easy to build u-boot for
> > Raspberry Pi 3B+(32bit).
>
> What does this provide over rpi_3_32b_defconfig? As that config works
> just fine on all variants of the RPi3 inc the B, B+, A+ and CM3 I
> don't see the point in confusing things with an unnecessary config.
>
> > Could you merge this patch?
> >
> > Thanks,
> > Toshifumi NISHINAGA
> >
> >
> > From 28d13f48761ab7c137a5fdf07c76a857967e3590 Mon Sep 17 00:00:00 2001
> > From: Toshifumi NISHINAGA <tnishinaga.dev@gmail.com>
> > Date: Thu, 15 Apr 2021 16:53:33 +0900
> > Subject: [PATCH] Add support for Raspberry Pi 3B+(32bit)
> > MIME-Version: 1.0
> > Content-Type: text/plain; charset=UTF-8
> > Content-Transfer-Encoding: 8bit
> >
> > It also boots on Raspberry Pi 3B+ using rpi_3_32b_defconfig,
> > but the network card doesn't work.
> >
> > This defconfig is based on rpi_3_32b_defconfig.
> >
> > Signed-off-by: Toshifumi NISHINAGA <tnishinaga.dev@gmail.com>
> > ---
> >
> > configs/rpi_3_32b_plus_defconfig | 46 ++++++++++++++++++++++++++++++++
> > 1 file changed, 46 insertions(+)
> > create mode 100644 configs/rpi_3_32b_plus_defconfig
> >
> > diff --git a/configs/rpi_3_32b_plus_defconfig b/configs/rpi_3_32b_plus_defconfig
> > new file mode 100644
> > index 0000000000..d147a46ae7
> > --- /dev/null
> > +++ b/configs/rpi_3_32b_plus_defconfig
> > @@ -0,0 +1,46 @@
> > +CONFIG_ARM=y
> > +CONFIG_ARCH_CPU_INIT=y
> > +CONFIG_ARCH_BCM283X=y
> > +CONFIG_SYS_TEXT_BASE=0x00008000
> > +CONFIG_TARGET_RPI_3_32B=y
> > +CONFIG_SYS_MALLOC_F_LEN=0x2000
> > +CONFIG_NR_DRAM_BANKS=1
> > +CONFIG_ENV_SIZE=0x4000
> > +CONFIG_DEFAULT_DEVICE_TREE="bcm2837-rpi-3-b-plus"
> > +CONFIG_DISTRO_DEFAULTS=y
> > +CONFIG_OF_BOARD_SETUP=y
> > +CONFIG_USE_PREBOOT=y
> > +# CONFIG_DISPLAY_CPUINFO is not set
> > +# CONFIG_DISPLAY_BOARDINFO is not set
> > +CONFIG_MISC_INIT_R=y
> > +CONFIG_SYS_PROMPT="U-Boot> "
> > +CONFIG_CMD_GPIO=y
> > +CONFIG_CMD_MMC=y
> > +CONFIG_CMD_USB=y
> > +CONFIG_CMD_FS_UUID=y
> > +CONFIG_OF_EMBED=y
> > +CONFIG_ENV_FAT_DEVICE_AND_PART="0:1"
> > +CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> > +CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
> > +CONFIG_DM_MMC=y
> > +CONFIG_MMC_SDHCI=y
> > +CONFIG_MMC_SDHCI_BCM2835=y
> > +CONFIG_PHYLIB=y
> > +CONFIG_DM_ETH=y
> > +CONFIG_PINCTRL=y
> > +# CONFIG_PINCTRL_GENERIC is not set
> > +# CONFIG_REQUIRE_SERIAL_CONSOLE is not set
> > +CONFIG_USB=y
> > +CONFIG_DM_USB=y
> > +CONFIG_USB_DWC2=y
> > +CONFIG_USB_KEYBOARD=y
> > +CONFIG_USB_HOST_ETHER=y
> > +CONFIG_USB_ETHER_LAN78XX=y
> > +CONFIG_USB_ETHER_SMSC95XX=y
> > +CONFIG_DM_VIDEO=y
> > +# CONFIG_VIDEO_BPP8 is not set
> > +# CONFIG_VIDEO_BPP16 is not set
> > +CONFIG_SYS_WHITE_ON_BLACK=y
> > +CONFIG_CONSOLE_SCROLL_LINES=10
> > +CONFIG_PHYS_TO_BUS=y
> > +CONFIG_OF_LIBFDT_OVERLAY=y
> > --
> > 2.24.3 (Apple Git-128)
Peter Robinson April 20, 2021, 12:17 p.m. UTC | #5
On Tue, Apr 20, 2021 at 11:57 AM Toshifumi NISHINAGA
<tnishinaga.dev@gmail.com> wrote:
>
> Hello Peter.
>
> > As that config works
> > just fine on all variants of the RPi3 inc the B, B+, A+ and CM3
>
> Yes. It also boots on Raspberry Pi 3B+ using rpi_3_32b_defconfig,
> but only the network card doesn't work.
> Because the network cards used in the 3B and 3B+ are different.

The both the network cards are included in both configs, surely it
would be less confusing for users to detect the variant and load the
correct DT to ensure the network card does work, there's numerous
examples of this in U-Boot already

> This difference is hard to notice,
> so I want to add a new defconfig for Raspberry Pi 3B+.
>
>
> Regards,
> Toshifumi NISHINAGA
>
> 2021年4月20日(火) 19:28 Peter Robinson <pbrobinson@gmail.com>:
> >
> > On Tue, Apr 20, 2021 at 7:05 AM Toshifumi NISHINAGA
> > <tnishinaga.dev@gmail.com> wrote:
> > >
> > > Hello all.
> > >
> > > I will add rpi_3_32b_plus_defconfig to easy to build u-boot for
> > > Raspberry Pi 3B+(32bit).
> >
> > What does this provide over rpi_3_32b_defconfig? As that config works
> > just fine on all variants of the RPi3 inc the B, B+, A+ and CM3 I
> > don't see the point in confusing things with an unnecessary config.
> >
> > > Could you merge this patch?
> > >
> > > Thanks,
> > > Toshifumi NISHINAGA
> > >
> > >
> > > From 28d13f48761ab7c137a5fdf07c76a857967e3590 Mon Sep 17 00:00:00 2001
> > > From: Toshifumi NISHINAGA <tnishinaga.dev@gmail.com>
> > > Date: Thu, 15 Apr 2021 16:53:33 +0900
> > > Subject: [PATCH] Add support for Raspberry Pi 3B+(32bit)
> > > MIME-Version: 1.0
> > > Content-Type: text/plain; charset=UTF-8
> > > Content-Transfer-Encoding: 8bit
> > >
> > > It also boots on Raspberry Pi 3B+ using rpi_3_32b_defconfig,
> > > but the network card doesn't work.
> > >
> > > This defconfig is based on rpi_3_32b_defconfig.
> > >
> > > Signed-off-by: Toshifumi NISHINAGA <tnishinaga.dev@gmail.com>
> > > ---
> > >
> > > configs/rpi_3_32b_plus_defconfig | 46 ++++++++++++++++++++++++++++++++
> > > 1 file changed, 46 insertions(+)
> > > create mode 100644 configs/rpi_3_32b_plus_defconfig
> > >
> > > diff --git a/configs/rpi_3_32b_plus_defconfig b/configs/rpi_3_32b_plus_defconfig
> > > new file mode 100644
> > > index 0000000000..d147a46ae7
> > > --- /dev/null
> > > +++ b/configs/rpi_3_32b_plus_defconfig
> > > @@ -0,0 +1,46 @@
> > > +CONFIG_ARM=y
> > > +CONFIG_ARCH_CPU_INIT=y
> > > +CONFIG_ARCH_BCM283X=y
> > > +CONFIG_SYS_TEXT_BASE=0x00008000
> > > +CONFIG_TARGET_RPI_3_32B=y
> > > +CONFIG_SYS_MALLOC_F_LEN=0x2000
> > > +CONFIG_NR_DRAM_BANKS=1
> > > +CONFIG_ENV_SIZE=0x4000
> > > +CONFIG_DEFAULT_DEVICE_TREE="bcm2837-rpi-3-b-plus"
> > > +CONFIG_DISTRO_DEFAULTS=y
> > > +CONFIG_OF_BOARD_SETUP=y
> > > +CONFIG_USE_PREBOOT=y
> > > +# CONFIG_DISPLAY_CPUINFO is not set
> > > +# CONFIG_DISPLAY_BOARDINFO is not set
> > > +CONFIG_MISC_INIT_R=y
> > > +CONFIG_SYS_PROMPT="U-Boot> "
> > > +CONFIG_CMD_GPIO=y
> > > +CONFIG_CMD_MMC=y
> > > +CONFIG_CMD_USB=y
> > > +CONFIG_CMD_FS_UUID=y
> > > +CONFIG_OF_EMBED=y
> > > +CONFIG_ENV_FAT_DEVICE_AND_PART="0:1"
> > > +CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> > > +CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
> > > +CONFIG_DM_MMC=y
> > > +CONFIG_MMC_SDHCI=y
> > > +CONFIG_MMC_SDHCI_BCM2835=y
> > > +CONFIG_PHYLIB=y
> > > +CONFIG_DM_ETH=y
> > > +CONFIG_PINCTRL=y
> > > +# CONFIG_PINCTRL_GENERIC is not set
> > > +# CONFIG_REQUIRE_SERIAL_CONSOLE is not set
> > > +CONFIG_USB=y
> > > +CONFIG_DM_USB=y
> > > +CONFIG_USB_DWC2=y
> > > +CONFIG_USB_KEYBOARD=y
> > > +CONFIG_USB_HOST_ETHER=y
> > > +CONFIG_USB_ETHER_LAN78XX=y
> > > +CONFIG_USB_ETHER_SMSC95XX=y
> > > +CONFIG_DM_VIDEO=y
> > > +# CONFIG_VIDEO_BPP8 is not set
> > > +# CONFIG_VIDEO_BPP16 is not set
> > > +CONFIG_SYS_WHITE_ON_BLACK=y
> > > +CONFIG_CONSOLE_SCROLL_LINES=10
> > > +CONFIG_PHYS_TO_BUS=y
> > > +CONFIG_OF_LIBFDT_OVERLAY=y
> > > --
> > > 2.24.3 (Apple Git-128)
>
>
>
> --
> Toshifumi NISHINAGA
Toshifumi NISHINAGA April 20, 2021, 1:14 p.m. UTC | #6
> The both the network cards are included in both configs, surely it
> would be less confusing for users to detect the variant and load the
> correct DT to ensure the network card does work, there's numerous
> examples of this in U-Boot already

I think it would be less confusing for users to add a defconfig for 3B+(32bit)
for the following reasons.

- 3B has defconfig for 32bit and 64bit
- The defconfig for 3B and 3B+ is the same except for
CONFIG_DEFAULT_DEVICE_TREE, but both are provided

Alternatively, I suggest deleting rpi_3_b_plus_defconfig.

2021年4月20日(火) 21:18 Peter Robinson <pbrobinson@gmail.com>:
>
> On Tue, Apr 20, 2021 at 11:57 AM Toshifumi NISHINAGA
> <tnishinaga.dev@gmail.com> wrote:
> >
> > Hello Peter.
> >
> > > As that config works
> > > just fine on all variants of the RPi3 inc the B, B+, A+ and CM3
> >
> > Yes. It also boots on Raspberry Pi 3B+ using rpi_3_32b_defconfig,
> > but only the network card doesn't work.
> > Because the network cards used in the 3B and 3B+ are different.
>
> The both the network cards are included in both configs, surely it
> would be less confusing for users to detect the variant and load the
> correct DT to ensure the network card does work, there's numerous
> examples of this in U-Boot already
>
> > This difference is hard to notice,
> > so I want to add a new defconfig for Raspberry Pi 3B+.
> >
> >
> > Regards,
> > Toshifumi NISHINAGA
> >
> > 2021年4月20日(火) 19:28 Peter Robinson <pbrobinson@gmail.com>:
> > >
> > > On Tue, Apr 20, 2021 at 7:05 AM Toshifumi NISHINAGA
> > > <tnishinaga.dev@gmail.com> wrote:
> > > >
> > > > Hello all.
> > > >
> > > > I will add rpi_3_32b_plus_defconfig to easy to build u-boot for
> > > > Raspberry Pi 3B+(32bit).
> > >
> > > What does this provide over rpi_3_32b_defconfig? As that config works
> > > just fine on all variants of the RPi3 inc the B, B+, A+ and CM3 I
> > > don't see the point in confusing things with an unnecessary config.
> > >
> > > > Could you merge this patch?
> > > >
> > > > Thanks,
> > > > Toshifumi NISHINAGA
> > > >
> > > >
> > > > From 28d13f48761ab7c137a5fdf07c76a857967e3590 Mon Sep 17 00:00:00 2001
> > > > From: Toshifumi NISHINAGA <tnishinaga.dev@gmail.com>
> > > > Date: Thu, 15 Apr 2021 16:53:33 +0900
> > > > Subject: [PATCH] Add support for Raspberry Pi 3B+(32bit)
> > > > MIME-Version: 1.0
> > > > Content-Type: text/plain; charset=UTF-8
> > > > Content-Transfer-Encoding: 8bit
> > > >
> > > > It also boots on Raspberry Pi 3B+ using rpi_3_32b_defconfig,
> > > > but the network card doesn't work.
> > > >
> > > > This defconfig is based on rpi_3_32b_defconfig.
> > > >
> > > > Signed-off-by: Toshifumi NISHINAGA <tnishinaga.dev@gmail.com>
> > > > ---
> > > >
> > > > configs/rpi_3_32b_plus_defconfig | 46 ++++++++++++++++++++++++++++++++
> > > > 1 file changed, 46 insertions(+)
> > > > create mode 100644 configs/rpi_3_32b_plus_defconfig
> > > >
> > > > diff --git a/configs/rpi_3_32b_plus_defconfig b/configs/rpi_3_32b_plus_defconfig
> > > > new file mode 100644
> > > > index 0000000000..d147a46ae7
> > > > --- /dev/null
> > > > +++ b/configs/rpi_3_32b_plus_defconfig
> > > > @@ -0,0 +1,46 @@
> > > > +CONFIG_ARM=y
> > > > +CONFIG_ARCH_CPU_INIT=y
> > > > +CONFIG_ARCH_BCM283X=y
> > > > +CONFIG_SYS_TEXT_BASE=0x00008000
> > > > +CONFIG_TARGET_RPI_3_32B=y
> > > > +CONFIG_SYS_MALLOC_F_LEN=0x2000
> > > > +CONFIG_NR_DRAM_BANKS=1
> > > > +CONFIG_ENV_SIZE=0x4000
> > > > +CONFIG_DEFAULT_DEVICE_TREE="bcm2837-rpi-3-b-plus"
> > > > +CONFIG_DISTRO_DEFAULTS=y
> > > > +CONFIG_OF_BOARD_SETUP=y
> > > > +CONFIG_USE_PREBOOT=y
> > > > +# CONFIG_DISPLAY_CPUINFO is not set
> > > > +# CONFIG_DISPLAY_BOARDINFO is not set
> > > > +CONFIG_MISC_INIT_R=y
> > > > +CONFIG_SYS_PROMPT="U-Boot> "
> > > > +CONFIG_CMD_GPIO=y
> > > > +CONFIG_CMD_MMC=y
> > > > +CONFIG_CMD_USB=y
> > > > +CONFIG_CMD_FS_UUID=y
> > > > +CONFIG_OF_EMBED=y
> > > > +CONFIG_ENV_FAT_DEVICE_AND_PART="0:1"
> > > > +CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> > > > +CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
> > > > +CONFIG_DM_MMC=y
> > > > +CONFIG_MMC_SDHCI=y
> > > > +CONFIG_MMC_SDHCI_BCM2835=y
> > > > +CONFIG_PHYLIB=y
> > > > +CONFIG_DM_ETH=y
> > > > +CONFIG_PINCTRL=y
> > > > +# CONFIG_PINCTRL_GENERIC is not set
> > > > +# CONFIG_REQUIRE_SERIAL_CONSOLE is not set
> > > > +CONFIG_USB=y
> > > > +CONFIG_DM_USB=y
> > > > +CONFIG_USB_DWC2=y
> > > > +CONFIG_USB_KEYBOARD=y
> > > > +CONFIG_USB_HOST_ETHER=y
> > > > +CONFIG_USB_ETHER_LAN78XX=y
> > > > +CONFIG_USB_ETHER_SMSC95XX=y
> > > > +CONFIG_DM_VIDEO=y
> > > > +# CONFIG_VIDEO_BPP8 is not set
> > > > +# CONFIG_VIDEO_BPP16 is not set
> > > > +CONFIG_SYS_WHITE_ON_BLACK=y
> > > > +CONFIG_CONSOLE_SCROLL_LINES=10
> > > > +CONFIG_PHYS_TO_BUS=y
> > > > +CONFIG_OF_LIBFDT_OVERLAY=y
> > > > --
> > > > 2.24.3 (Apple Git-128)
> >
> >
> >
> > --
> > Toshifumi NISHINAGA
diff mbox series

Patch

diff --git a/configs/rpi_3_32b_plus_defconfig b/configs/rpi_3_32b_plus_defconfig
new file mode 100644
index 0000000000..d147a46ae7
--- /dev/null
+++ b/configs/rpi_3_32b_plus_defconfig
@@ -0,0 +1,46 @@ 
+CONFIG_ARM=y
+CONFIG_ARCH_CPU_INIT=y
+CONFIG_ARCH_BCM283X=y
+CONFIG_SYS_TEXT_BASE=0x00008000
+CONFIG_TARGET_RPI_3_32B=y
+CONFIG_SYS_MALLOC_F_LEN=0x2000
+CONFIG_NR_DRAM_BANKS=1
+CONFIG_ENV_SIZE=0x4000
+CONFIG_DEFAULT_DEVICE_TREE="bcm2837-rpi-3-b-plus"
+CONFIG_DISTRO_DEFAULTS=y
+CONFIG_OF_BOARD_SETUP=y
+CONFIG_USE_PREBOOT=y
+# CONFIG_DISPLAY_CPUINFO is not set
+# CONFIG_DISPLAY_BOARDINFO is not set
+CONFIG_MISC_INIT_R=y
+CONFIG_SYS_PROMPT="U-Boot> "
+CONFIG_CMD_GPIO=y
+CONFIG_CMD_MMC=y
+CONFIG_CMD_USB=y
+CONFIG_CMD_FS_UUID=y
+CONFIG_OF_EMBED=y
+CONFIG_ENV_FAT_DEVICE_AND_PART="0:1"
+CONFIG_SYS_RELOC_GD_ENV_ADDR=y
+CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
+CONFIG_DM_MMC=y
+CONFIG_MMC_SDHCI=y
+CONFIG_MMC_SDHCI_BCM2835=y
+CONFIG_PHYLIB=y
+CONFIG_DM_ETH=y
+CONFIG_PINCTRL=y
+# CONFIG_PINCTRL_GENERIC is not set
+# CONFIG_REQUIRE_SERIAL_CONSOLE is not set
+CONFIG_USB=y
+CONFIG_DM_USB=y
+CONFIG_USB_DWC2=y
+CONFIG_USB_KEYBOARD=y
+CONFIG_USB_HOST_ETHER=y
+CONFIG_USB_ETHER_LAN78XX=y
+CONFIG_USB_ETHER_SMSC95XX=y
+CONFIG_DM_VIDEO=y
+# CONFIG_VIDEO_BPP8 is not set
+# CONFIG_VIDEO_BPP16 is not set
+CONFIG_SYS_WHITE_ON_BLACK=y
+CONFIG_CONSOLE_SCROLL_LINES=10
+CONFIG_PHYS_TO_BUS=y
+CONFIG_OF_LIBFDT_OVERLAY=y