From patchwork Sat May 16 01:33:15 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bin Meng X-Patchwork-Id: 472987 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 0D32514027F for ; Sat, 16 May 2015 11:33:53 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=iWcERgW1; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 431494B8BC; Sat, 16 May 2015 03:33:47 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 03pkhr_CKgX6; Sat, 16 May 2015 03:33:47 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id A825F4B8C8; Sat, 16 May 2015 03:33:44 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id B84EC4B8B2 for ; Sat, 16 May 2015 03:33:41 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iLrgxOeM-NGx for ; Sat, 16 May 2015 03:33:41 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-qc0-f176.google.com (mail-qc0-f176.google.com [209.85.216.176]) by theia.denx.de (Postfix) with ESMTPS id 8BFFB4B89E for ; Sat, 16 May 2015 03:33:35 +0200 (CEST) Received: by qcyk17 with SMTP id k17so65953081qcy.1 for ; Fri, 15 May 2015 18:33:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:from:to:subject:date:in-reply-to:references:mime-version :content-type; bh=jLB3fkV0tZcFEbl+W6K525OWNojAXthX6fTb5/x1GJU=; b=iWcERgW1lLdNd49QCjDNFiP/MbF7vocYXAATZqu3+45Rq/NTqm8y8Ngj9R4DiQl3dV DJIQCAosrCoAYwWy3C23g+A8LmkGWEibRjztbw9tmvuXIaiF+cXkugi9KcB5HVG1dmdM cROPymyiQiO9PqvyVIrvvfzYmwJBhIr78aaaYb591ViCIYC73f2j9jchY8TTzli6Ddlo oiQfi5u2x/1J1YGjnZWtkkceh2A9YTyRggDpEbzBfYuF7nCI6gIuXyNGlyby94yjMiRa ESt5MUbMdkxaHJF8+F1w+0L49irGQm4SCLp22ZuCja2ixgGhfdyt8/buwUuB2W1I+Ddc vC8w== X-Received: by 10.55.43.220 with SMTP id r89mr25981396qkr.27.1431740014536; Fri, 15 May 2015 18:33:34 -0700 (PDT) Received: from mail.hotmail.com (blu004-wss1s3.hotmail.com. [134.170.2.218]) by mx.google.com with ESMTPSA id b7sm2242605qkb.33.2015.05.15.18.33.33 (version=TLSv1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 15 May 2015 18:33:33 -0700 (PDT) Received: from BLU436-SMTP139 ([134.170.2.215]) by BLU004-WSS1S3.hotmail.com over TLS secured channel with Microsoft SMTPSVC(7.5.7601.22751); Fri, 15 May 2015 18:33:33 -0700 X-TMN: [8dtVY2VGBbDw6gZ1+Z2lZv/FynN4b4Wc] Message-ID: From: Bin Meng To: Simon Glass , U-Boot Mailing List Date: Sat, 16 May 2015 09:33:15 +0800 X-Mailer: git-send-email 1.8.2.1 In-Reply-To: <1431739999-24609-1-git-send-email-bmeng.cn@gmail.com> References: <1431739999-24609-1-git-send-email-bmeng.cn@gmail.com> X-OriginalArrivalTime: 16 May 2015 01:33:32.0266 (UTC) FILETIME=[51A994A0:01D08F78] MIME-Version: 1.0 Subject: [U-Boot] [PATCH v2 2/6] pci: Do not skip legacy IDE device configuration X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" The legacy IDE device has a BAR4 (Bus Master Interface BAR) which needs to be configured. Signed-off-by: Bin Meng Reviewed-by: Simon Glass Acked-by: Simon Glass --- Changes in v2: - Correct a typo in the commit message title drivers/pci/pci_auto.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/pci/pci_auto.c b/drivers/pci/pci_auto.c index 43965d8..7c10983 100644 --- a/drivers/pci/pci_auto.c +++ b/drivers/pci/pci_auto.c @@ -20,8 +20,6 @@ #define DEBUGF(x...) #endif /* DEBUG */ -#define PCIAUTO_IDE_MODE_MASK 0x05 - /* the user can define CONFIG_SYS_PCI_CACHE_LINE_SIZE to avoid problems */ #ifndef CONFIG_SYS_PCI_CACHE_LINE_SIZE #define CONFIG_SYS_PCI_CACHE_LINE_SIZE 8 @@ -424,7 +422,6 @@ int pciauto_config_device(struct pci_controller *hose, pci_dev_t dev) { unsigned int sub_bus = PCI_BUS(dev); unsigned short class; - unsigned char prg_iface; int n; pci_hose_read_config_word(hose, dev, PCI_CLASS_DEVICE, &class); @@ -460,17 +457,6 @@ int pciauto_config_device(struct pci_controller *hose, pci_dev_t dev) #endif break; - case PCI_CLASS_STORAGE_IDE: - pci_hose_read_config_byte(hose, dev, PCI_CLASS_PROG, &prg_iface); - if (!(prg_iface & PCIAUTO_IDE_MODE_MASK)) { - DEBUGF("PCI Autoconfig: Skipping legacy mode IDE controller\n"); - return sub_bus; - } - - pciauto_setup_device(hose, dev, 6, hose->pci_mem, - hose->pci_prefetch, hose->pci_io); - break; - case PCI_CLASS_BRIDGE_CARDBUS: /* * just do a minimal setup of the bridge,