| Message ID | BANLkTim3=fhQ4GTdLMQnbdUw5wvhAxH-fw@mail.gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
Hi Anton, Sorry for the dela in replying. Le 05/04/2011 23:33, Anton Staaf a écrit : > Create the board/nvidia/common directory in the out of tree build > directory. > > Without this patch building out of tree results in a failure to create > the board.o file in the build directory tree. > > Signed-off-by: Anton Staaf<robotboy@chromium.org> > Cc: Tom Warren<twarren@nvidia.com> > Cc: Albert ARIBAUD<albert.aribaud@free.fr> > --- > > An alternative solution would be to create a Makefile in the common directory > that creates an object/library that each board depends on. I'm not sure which > is better. I'd prefer the alternative solution -- the issue is with a common directory, so it seems logical that the solution is in the common part of the code rather than spread over the non-common variants. Amicalement,
No worries. On Thu, Apr 14, 2011 at 2:29 PM, Albert ARIBAUD <albert.u.boot@aribaud.net> wrote: >> >> An alternative solution would be to create a Makefile in the common >> directory >> that creates an object/library that each board depends on. I'm not sure >> which >> is better. > > I'd prefer the alternative solution -- the issue is with a common directory, > so it seems logical that the solution is in the common part of the code > rather than spread over the non-common variants. > Yes, that makes perfect sense. I'll make the change. Thanks, Anton
diff --git a/board/nvidia/harmony/Makefile b/board/nvidia/harmony/Makefile index 3a146cb..4f4373b 100644 --- a/board/nvidia/harmony/Makefile +++ b/board/nvidia/harmony/Makefile @@ -24,6 +24,8 @@ include $(TOPDIR)/config.mk +$(shell mkdir -p $(obj)../common) + LIB = $(obj)lib$(BOARD).o COBJS += ../common/board.o diff --git a/board/nvidia/seaboard/Makefile b/board/nvidia/seaboard/Makefile index 3a146cb..4f4373b 100644 --- a/board/nvidia/seaboard/Makefile +++ b/board/nvidia/seaboard/Makefile @@ -24,6 +24,8 @@ include $(TOPDIR)/config.mk +$(shell mkdir -p $(obj)../common) + LIB = $(obj)lib$(BOARD).o COBJS += ../common/board.o
Create the board/nvidia/common directory in the out of tree build directory. Without this patch building out of tree results in a failure to create the board.o file in the build directory tree. Signed-off-by: Anton Staaf <robotboy@chromium.org> Cc: Tom Warren <twarren@nvidia.com> Cc: Albert ARIBAUD <albert.aribaud@free.fr> --- An alternative solution would be to create a Makefile in the common directory that creates an object/library that each board depends on. I'm not sure which is better. board/nvidia/harmony/Makefile | 2 ++ board/nvidia/seaboard/Makefile | 2 ++ 2 files changed, 4 insertions(+), 0 deletions(-)