From patchwork Tue Nov 16 13:13:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Aleksandar Gerasimovski X-Patchwork-Id: 1555824 X-Patchwork-Delegate: priyanka.jain@nxp.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=hitachienergy.com header.i=@hitachienergy.com header.a=rsa-sha256 header.s=selector1 header.b=eqk60J4A; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Htmj944sqz9t0G for ; Wed, 17 Nov 2021 00:13:49 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3469083907; Tue, 16 Nov 2021 14:13:46 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=hitachienergy.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=hitachienergy.com header.i=@hitachienergy.com header.b="eqk60J4A"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 04E8983904; Tue, 16 Nov 2021 14:13:44 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03on0711.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe08::711]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D6F5C8390B for ; Tue, 16 Nov 2021 14:13:35 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=hitachienergy.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=aleksandar.gerasimovski@hitachienergy.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aSuNCveSM7eT0sr58x9EvNOeqeJ2uMRzmxvmmDRP5seSnnOhwXpiZ8mzYeSorQwmYqLKXz7LQPubJJ43+J3+QcLrLEJXlrQoslV7o+qn2/Bbg+OC3X1EH3OuDO+S5jAVvIuoegG9eYDPXcwgbHU9yTbnkAqguH/wKM3NXqa2BC7dKABECGeeOPirmhr+LPOT45LHngRexr0W9U2de3ib0hfQuh0a+91ZXLqbhooebmH76BoP1pXWsjKSXqa+JMphlsYwLh4cjtaQ7A8Ma5+7rtDFUzclzetR8cxGJsvf2NQCib5K9TTJPhAKaSn8y+HC4fzB8oDZk1WZWzSzKbXipw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HtRsmK5y7PVwVuSYQHtnw4h87yv32wHoCNhOT4ECJHQ=; b=bOQmhG3XDCqQbFacAajLZsIzKkNoXiAd9uYKMMLO/LmxTNqFgvwbw6hedVnbb0w96FP1Jh4u23cXxZN05etLo0t0Zu8WG3Pd39snZKuwTMyFrxc9gjrEg60w0ShgHkmAfN7e81ErnNfYLZYFce2OtM7aRD58zVM6dKHh48QQ6aTN0WW5WaxxGeliLWr7qD1/Jo60+gi1fPt524y6AHERyPvVwPo6i6HqH7wcwFOLYHevZ/DPl1fsDmMOipHaePkf2oE7U5MX7jNqqimETp93J8OpUaaLn+kYEJiPiDWhINWFciiz6zkGUIq8dKS1+c239V/YXLPHwfDfvhALuwTjYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hitachienergy.com; dmarc=pass action=none header.from=hitachienergy.com; dkim=pass header.d=hitachienergy.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hitachienergy.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HtRsmK5y7PVwVuSYQHtnw4h87yv32wHoCNhOT4ECJHQ=; b=eqk60J4AUOkodxChPYc+LQW4syT4+8XnPw6FXUoyQfG56LfS2PEpnsly/e4jXzREVqizeuMl2NrL8Baxm6vB5qnOlHTZi3Sth6Z2VwXkEAPyHD1itYdMcm6yq6mPRwNqtGfYo7bHiYBvo/JVFQUwAkhBDa0JCW6YNqydqoYCx01MtTp8UV/JWFr1gXvb71r8b9BX3OydelviD3D/tI8Bj4w6qfEHvWUjqhwEgJy8vJEOpznJHGj2G/YyxZoUdxOLKnVM+9SXOf58L0+xIv+o5TY5i8eINy2lK4B/lukeWEyD6lvaZpjv4PmDI2+WDpaaSBg1KlNn/IldtC0VleJtLw== Received: from AM9PR06MB8100.eurprd06.prod.outlook.com (2603:10a6:20b:388::22) by AM0PR06MB6564.eurprd06.prod.outlook.com (2603:10a6:208:1a1::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.16; Tue, 16 Nov 2021 13:13:35 +0000 Received: from AM9PR06MB8100.eurprd06.prod.outlook.com ([fe80::cbe:8274:604e:1e8b]) by AM9PR06MB8100.eurprd06.prod.outlook.com ([fe80::cbe:8274:604e:1e8b%4]) with mapi id 15.20.4690.027; Tue, 16 Nov 2021 13:13:35 +0000 From: Aleksandar Gerasimovski To: "u-boot@lists.denx.de" , "Priyanka Jain (OSS)" , Rainer Boschung , Holger Brunck Subject: [PATCH 18/18] km/ls102xa: use unused scratchrw4 address for post word Thread-Topic: [PATCH 18/18] km/ls102xa: use unused scratchrw4 address for post word Thread-Index: Adfa67bUBNEwyFKIQwCzGV56EmweyA== Date: Tue, 16 Nov 2021 13:13:35 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=hitachienergy.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 319140af-3a54-4c83-f3a7-08d9a902e547 x-ms-traffictypediagnostic: AM0PR06MB6564: x-microsoft-antispam-prvs: x-he-o365-outbound: HEO365Out x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1jqkm0bM7E7kGyFnuDKpzrFmj/Bx4XyNSagsXrzhCYdoEv5Um4fD8SVDsCee9ABQRTD/78YTFZVt1S0GQ434h7cc5rPJNRTogttXXdwLTLmt6Y3iWZns2PQqZBRoEQPHUQO7j0xaoNVw7cSFmNo7WIwklVqY03xqWDAtHGDNtObxS8jqwpmFFWyaBGToHbH7J06HpUwxSOV7dWrkJPOIKxFRyFMe9eaKmii5MwZMKFDZ9IQZwCqVe0yUCkId7aFbG+OLXDd+gvLQOQlBeyZ9IZlrBifJKGD/BWEkvwv2+VzoRWoIZL4ilwLz+DZU09MeeErnELHKV6aOQYo8l68xMBIYAcRqyfwPZTjpRgraUz8LBSEW0kjvUPtHvtn/FJ05A63l9oo4mmO2wHPVExh/vLqk/V03Z4EQBUkZP+1X4Bh5RsRhcYlALp9sM0quKVboQIlURTInsJeMwyi6h/ynDybfgvw8i4LPhuI99Yhrv/GPyN/r6ikDXgYZSUbXGQCfxOnTCdhbNLbPFHTD692JWl24pwIf1VTAu+jcrzp2RpiFtQNde6+aZNXhVTQDv4wv9/wLCIFx893OACsIbQOnaq+N6JTYUF5tPNf0lQ75DBQt5oSQ4fHHhI+bD0zeJ78bgX2QyaYdu5VZU+gG1MQmMfKfkVAtxlzckZPnme0986mzjmlP4BuEJ3NO1Rp9PPwEIIlYmDWmwKGL9bc87wF8uA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM9PR06MB8100.eurprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6636002)(86362001)(316002)(186003)(26005)(110136005)(508600001)(44832011)(33656002)(8676002)(122000001)(8936002)(38100700002)(6506007)(82960400001)(9686003)(7696005)(55016002)(38070700005)(66476007)(2906002)(71200400001)(66556008)(64756008)(66446008)(5660300002)(83380400001)(52536014)(66946007)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 2 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?q?ta8f+l2o5jQPRqIwrpIO+lH?= =?iso-8859-1?q?e+HDLC0cBQcKqXz8PSZxG3qyAx07TPDRfwAdbxwa9a/Hkuruv4Kwsz3FZty3?= =?iso-8859-1?q?w2UuJZ85UzBOxcrDcufFvNWYuAbHSYRwG83u0oFcTpZJTI6nyMGt5BaFnwVc?= =?iso-8859-1?q?cyCp+mdb1adRoawHQgbvCe4xBZGNq2+kwxngp5eSxVbSZooYqjGlawrH4pWK?= =?iso-8859-1?q?etHRzLg3YoPUXGtD4iRj/7VEiM/yH9+MtqTXKlJ/g6Rr31vEwY4p6RcE/JUt?= =?iso-8859-1?q?8u3p/2X0on8+KrNqgBuxwpa6pSy3lfqKrbuzn6LQXUGeu+twsMbUP5zyicIK?= =?iso-8859-1?q?4X4AV8YyMGX6OUStJASwvzHQeqt/NtvRXWbJ0NhUzT8YMyg3sRZckkb+517/?= =?iso-8859-1?q?voEX0ZFMuE1ggCfFr2KEXJXfAsudAnRDWMOXCPpKgulpRMkblgoKzlnjQ1Xe?= =?iso-8859-1?q?ncZ9gAeuEXw0JsT+MPuNnWMPbGqN534QsEkWAW9L6Jcv6W9Fc0+h9YLbkUjp?= =?iso-8859-1?q?48WOTPs7yR04caN4tZbIBlys1Gy/zzNIZMmNEoDJnL9wCVli6knSDl8rb2e+?= =?iso-8859-1?q?EDW/c491EksyRcGdL6PGHZOHNbFNnpLIm58ggQCiEVA3v9nTekZ/t6ipINjh?= =?iso-8859-1?q?Jgugsf0l7gOOm82miRbnO+zzxefj4U3/qZtOMT8ymtNHYzAR44PldwmR01wx?= =?iso-8859-1?q?lWPlN0Z0E7bXZzGnKsjTC6LTi/3lNfNkqJ1aX6RHILkJ/mI4lLN6kC9J0ic2?= =?iso-8859-1?q?BvBp9bw0d8FSSW7FxB462/R+1A1ITnLdOpDFxOw4cOwSuYsKXNDSJIUAR6Ol?= =?iso-8859-1?q?rMgUStjrqDtlPvmeyouUkEUC2FDLsRO59YBHhwRmAbLkMtpQpaWw67j1ZOBJ?= =?iso-8859-1?q?abtRNxWmiBkWPT/hTzyUpqWGcGqCA67RnnkIgt4Qba2ZTP+aPiuQ5YSSfelt?= =?iso-8859-1?q?2KlnWOcEXYoNfqjlRPSLfE+JlR7f9YLgUe3TkkHGbDCgGkLNGl3V+ZKqBjdK?= =?iso-8859-1?q?Xp4kjwhexqC4exCvlQ9FlsOPtA6NQP4dPfTsq1WLtLBgVyTiVp6aid8lM8Wa?= =?iso-8859-1?q?zpy4eiJ7kOyG83rVISiEcSQTk/BzsmIva5AWNaqdAW4c9C1ErlegpNsHyDRs?= =?iso-8859-1?q?tXIjeRBATumZX7jNS7DwRLc/xQriKBG78dEFMtrSBkf62okx44aJOp2F5eug?= =?iso-8859-1?q?wUVPx0z37f7qu4JuduXJ921DSWTnl58mnYsSlKDVLxZKtJYQhQBdBvT5xE1N?= =?iso-8859-1?q?dBuetheOYypCu20EaZpzxuIPjgMDv09VZquPjYHZoE/5P1hnSUv3yGi1Bs3Z?= =?iso-8859-1?q?mzHlftoCGsgdgrQXUZ6831lTnDNOBiRKpXhWxvoFk+vjD0NbHzeasGDrKTnw?= =?iso-8859-1?q?LhF2K3/14CUUBHx1xABp1nR5Vsd1ol5m4PYtEw3dxDcwz98CfOlK4G+62Qje?= =?iso-8859-1?q?scr7TEoM2w7qcAnSrBiHfMqJk76kd5QmReO2kZVTYSuUN4jFnTBw+VLR+sSZ?= =?iso-8859-1?q?vB0TQZmtf2PmXeUFiIMdnwnzyCGc4sjtvfEw2IxcK1DjQnnVaMA68tyhHM6J?= =?iso-8859-1?q?wKL3RwCqxNhKuya7T4hqFslno3ldoA9EV2lfCgrLaJltWKs9kN7jNTVsGu+z?= =?iso-8859-1?q?YgsFgq6ammeIiChf0vtw67o1gpnTg+4eo/RmhvDAkXKlk8usjzs2Cemef48q?= =?iso-8859-1?q?0xLLec8Nmn+2tFcdyjjqxdAZTjpBPZOOyTYr59EkiFvi+XQqt+NzSuZeO7b5?= =?iso-8859-1?q?n+RnOl8HhSIwqMiTlg46lhOWRZOUKHw0rBOh5LfUDnVVGA/y9BpuiINNUnoK?= =?iso-8859-1?q?R5XB7sP/gL8559XpWHaOfiEhnRWtW6IRQCDgK?= x-ms-exchange-antispam-messagedata-1: oOT59PYpJeTQbA== MIME-Version: 1.0 X-OriginatorOrg: hitachienergy.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM9PR06MB8100.eurprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 319140af-3a54-4c83-f3a7-08d9a902e547 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2021 13:13:35.1093 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7831e6d9-dc6c-4cd1-9ec6-1dc2b4133195 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: J4TlOMJfvx+pxFIN9ddvryrzJtJX+hYqI1efgxyHRlaOsiFuYqDgmNelulfI+ladFuGozRqNeQEQ74wOX2c6Q+37x1ERuqifLYOGrBSNZIw762qcJKz4f+ZHxPa1C0md8f2g+eVHszDUVAiyMhhfCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR06MB6564 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.35 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean The SCRATCHRW4 is only used in secure boot scenario that is unsupported by our design, so this address can be stolen for storing POST status. The SCRATCHRW4 is initialized to zero at core rest. Using a DDR address was unfortunate choice, the DDR at boot time has a random contend and it happens that sometimes is matching POST magic number. This behavior can lead to undefined POST behavior and u-boot ending in failbootcmd command. Signed-off-by: Aleksandar Gerasimovski --- board/keymile/pg-wcom-ls102xa/pg-wcom-ls102xa.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/board/keymile/pg-wcom-ls102xa/pg-wcom-ls102xa.c b/board/keymile/pg-wcom-ls102xa/pg-wcom-ls102xa.c index a37d111..467f110 100644 --- a/board/keymile/pg-wcom-ls102xa/pg-wcom-ls102xa.c +++ b/board/keymile/pg-wcom-ls102xa/pg-wcom-ls102xa.c @@ -162,19 +162,18 @@ int post_hotkeys_pressed(void) return qrio_get_selftest_pin(); } +/* POST word is located in the unused SCRATCHRW4 register */ +#define CCSR_SCRATCHRW4_ADDR 0x1ee020c + ulong post_word_load(void) { - /* POST word is located at the beginning of reserved physical RAM */ - void *addr = (void *)(CONFIG_SYS_SDRAM_BASE + - gd->ram_size - CONFIG_KM_RESERVED_PRAM + 8); + void *addr = (void *)CCSR_SCRATCHRW4_ADDR; return in_le32(addr); } void post_word_store(ulong value) { - /* POST word is located at the beginning of reserved physical RAM */ - void *addr = (void *)(CONFIG_SYS_SDRAM_BASE + - gd->ram_size - CONFIG_KM_RESERVED_PRAM + 8); + void *addr = (void *)CCSR_SCRATCHRW4_ADDR; out_le32(addr, value); }