Message ID | 9941bd6679491a99ef3c50f76c852eb1ef092662.1405895188.git.rbyshko@gmail.com |
---|---|
State | Accepted |
Delegated to: | Hans de Goede |
Headers | show |
On Thu, 2014-07-24 at 22:54 +0200, Roman Byshko wrote: > Cubietruck has two USB host controllers. This makes them > usable by enabling the EHCI driver for them. Did you not want to enable for the Cubietruck_FEL config too? What about other boards with A20 on them? And does this same driver work for sun4i, sun5i or sun6i? The wiki seems to suggest yes for sun4i and sun5i at least. I don't necessarily expect you will want to add the cfg for boards you can't test yourself but I'm wondering if I should prod people (well, mainly Hans so far ;-)) to enable on their boards. There's a minor conflict with the updated boards.cfg in u-boot-sunxi.git#next. I can pretty easily resolve it but if you need to resend the series for some other reason you could save me the trouble and base it one branch instead of master. Cheers, Ian. > Signed-off-by: Roman Byshko <rbyshko@gmail.com> > Acked-by: Ian Campbell <ijc@hellion.org.uk> > --- > boards.cfg | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/boards.cfg b/boards.cfg > index 035b5c7..ae167c2 100644 > --- a/boards.cfg > +++ b/boards.cfg > @@ -381,7 +381,7 @@ Active arm armv7 sunxi - sunxi > Active arm armv7 sunxi - sunxi Cubieboard sun4i:CUBIEBOARD,SPL,AXP209_POWER,SUNXI_EMAC Hans de Goede <hdegoede@redhat.com> > Active arm armv7 sunxi - sunxi Cubieboard2 sun7i:CUBIEBOARD2,SPL,SUNXI_GMAC Ian Campbell <ijc@hellion.org.uk>:Hans de Goede <hdegoede@redhat.com> > Active arm armv7 sunxi - sunxi Cubieboard2_FEL sun7i:CUBIEBOARD2,SPL_FEL,SUNXI_GMAC Ian Campbell <ijc@hellion.org.uk>:Hans de Goede <hdegoede@redhat.com> > -Active arm armv7 sunxi - sunxi Cubietruck sun7i:CUBIETRUCK,SPL,AXP209_POWER,SUNXI_GMAC,RGMII Ian Campbell <ijc@hellion.org.uk>:Hans de Goede <hdegoede@redhat.com> > +Active arm armv7 sunxi - sunxi Cubietruck sun7i:CUBIETRUCK,SPL,AXP209_POWER,SUNXI_GMAC,RGMII,USB_EHCI Ian Campbell <ijc@hellion.org.uk>:Hans de Goede <hdegoede@redhat.com> > Active arm armv7 sunxi - sunxi Cubietruck_FEL sun7i:CUBIETRUCK,SPL_FEL,AXP209_POWER,SUNXI_GMAC,RGMII Ian Campbell <ijc@hellion.org.uk>:Hans de Goede <hdegoede@redhat.com> > Active arm armv7 sunxi - sunxi r7-tv-dongle sun5i:R7DONGLE,SPL,AXP152_POWER Hans de Goede <hdegoede@redhat.com> > Active arm armv7 u8500 st-ericsson snowball snowball - Mathieu Poirier <mathieu.poirier@linaro.org>
Hi, On 07/25/2014 10:33 PM, Ian Campbell wrote: > On Thu, 2014-07-24 at 22:54 +0200, Roman Byshko wrote: >> Cubietruck has two USB host controllers. This makes them >> usable by enabling the EHCI driver for them. > > Did you not want to enable for the Cubietruck_FEL config too? > > What about other boards with A20 on them? And does this same driver work > for sun4i, sun5i or sun6i? It should work on sun4i, sun5i and sun7i with one very small modification (which is actually needed for sun5i and sun7i not for sun4i). See my reply to the 2nd patch of this series. > > The wiki seems to suggest yes for sun4i and sun5i at least. I don't > necessarily expect you will want to add the cfg for boards you can't > test yourself but I'm wondering if I should prod people (well, mainly > Hans so far ;-)) to enable on their boards. > > There's a minor conflict with the updated boards.cfg in > u-boot-sunxi.git#next. I can pretty easily resolve it but if you need to > resend the series for some other reason you could save me the trouble > and base it one branch instead of master. I've already cherry picked this patch for adding it to u-boot-sunxi next branch, resolving the conflict myself. Unfortunately we cannot take this patch in sunxi next without also taking the 2nd patch otherwise the build breaks. See my other reply to the 2nd patch in the series on this. Regards, Hans
diff --git a/boards.cfg b/boards.cfg index 035b5c7..ae167c2 100644 --- a/boards.cfg +++ b/boards.cfg @@ -381,7 +381,7 @@ Active arm armv7 sunxi - sunxi Active arm armv7 sunxi - sunxi Cubieboard sun4i:CUBIEBOARD,SPL,AXP209_POWER,SUNXI_EMAC Hans de Goede <hdegoede@redhat.com> Active arm armv7 sunxi - sunxi Cubieboard2 sun7i:CUBIEBOARD2,SPL,SUNXI_GMAC Ian Campbell <ijc@hellion.org.uk>:Hans de Goede <hdegoede@redhat.com> Active arm armv7 sunxi - sunxi Cubieboard2_FEL sun7i:CUBIEBOARD2,SPL_FEL,SUNXI_GMAC Ian Campbell <ijc@hellion.org.uk>:Hans de Goede <hdegoede@redhat.com> -Active arm armv7 sunxi - sunxi Cubietruck sun7i:CUBIETRUCK,SPL,AXP209_POWER,SUNXI_GMAC,RGMII Ian Campbell <ijc@hellion.org.uk>:Hans de Goede <hdegoede@redhat.com> +Active arm armv7 sunxi - sunxi Cubietruck sun7i:CUBIETRUCK,SPL,AXP209_POWER,SUNXI_GMAC,RGMII,USB_EHCI Ian Campbell <ijc@hellion.org.uk>:Hans de Goede <hdegoede@redhat.com> Active arm armv7 sunxi - sunxi Cubietruck_FEL sun7i:CUBIETRUCK,SPL_FEL,AXP209_POWER,SUNXI_GMAC,RGMII Ian Campbell <ijc@hellion.org.uk>:Hans de Goede <hdegoede@redhat.com> Active arm armv7 sunxi - sunxi r7-tv-dongle sun5i:R7DONGLE,SPL,AXP152_POWER Hans de Goede <hdegoede@redhat.com> Active arm armv7 u8500 st-ericsson snowball snowball - Mathieu Poirier <mathieu.poirier@linaro.org>