| Message ID | 8982bb88db1e211d67574a5fd3186d04389e03d5.1449154075.git.michal.simek@xilinx.com |
|---|---|
| State | Accepted |
| Delegated to: | Michal Simek |
| Headers | show |
On 3 December 2015 at 20:17, Michal Simek <michal.simek@xilinx.com> wrote: > CONFIG_API is causing compilation error when DM_ETH is enabled because > eth_get_dev() is not available. Then how come, freebsd elf generate w/o CONFIG_API? > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > Changes in v3: None > Changes in v2: None > > include/configs/zynq-common.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/configs/zynq-common.h b/include/configs/zynq-common.h > index a9e6bf046a97..5db501188b18 100644 > --- a/include/configs/zynq-common.h > +++ b/include/configs/zynq-common.h > @@ -297,7 +297,6 @@ > > /* Boot FreeBSD/vxWorks from an ELF image */ > #if defined(CONFIG_ZYNQ_BOOT_FREEBSD) > -# define CONFIG_API > # define CONFIG_SYS_MMC_MAX_DEVICE 1 > #endif > thanks!
Hi, On 03-12-15 17:09, Jagan Teki wrote: > On 3 December 2015 at 20:17, Michal Simek <michal.simek@xilinx.com> wrote: >> CONFIG_API is causing compilation error when DM_ETH is enabled because >> eth_get_dev() is not available. > Then how come, freebsd elf generate w/o CONFIG_API? > >> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >> --- >> >> Changes in v3: None >> Changes in v2: None >> >> include/configs/zynq-common.h | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/include/configs/zynq-common.h b/include/configs/zynq-common.h >> index a9e6bf046a97..5db501188b18 100644 >> --- a/include/configs/zynq-common.h >> +++ b/include/configs/zynq-common.h >> @@ -297,7 +297,6 @@ >> >> /* Boot FreeBSD/vxWorks from an ELF image */ >> #if defined(CONFIG_ZYNQ_BOOT_FREEBSD) >> -# define CONFIG_API >> # define CONFIG_SYS_MMC_MAX_DEVICE 1 >> #endif >> > FreeBSD boot relies on CONFIG_API. Removing it will brick FreeBSD boots.... Regards, Jeroen
On 3.12.2015 17:09, Jagan Teki wrote: > On 3 December 2015 at 20:17, Michal Simek <michal.simek@xilinx.com> wrote: >> CONFIG_API is causing compilation error when DM_ETH is enabled because >> eth_get_dev() is not available. > > Then how come, freebsd elf generate w/o CONFIG_API? missing DM support there. Thanks, Michal
On 3.12.2015 18:57, Jeroen Hofstee wrote: > Hi, > > On 03-12-15 17:09, Jagan Teki wrote: >> On 3 December 2015 at 20:17, Michal Simek <michal.simek@xilinx.com> >> wrote: >>> CONFIG_API is causing compilation error when DM_ETH is enabled because >>> eth_get_dev() is not available. >> Then how come, freebsd elf generate w/o CONFIG_API? >> >>> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >>> --- >>> >>> Changes in v3: None >>> Changes in v2: None >>> >>> include/configs/zynq-common.h | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/include/configs/zynq-common.h >>> b/include/configs/zynq-common.h >>> index a9e6bf046a97..5db501188b18 100644 >>> --- a/include/configs/zynq-common.h >>> +++ b/include/configs/zynq-common.h >>> @@ -297,7 +297,6 @@ >>> >>> /* Boot FreeBSD/vxWorks from an ELF image */ >>> #if defined(CONFIG_ZYNQ_BOOT_FREEBSD) >>> -# define CONFIG_API >>> # define CONFIG_SYS_MMC_MAX_DEVICE 1 >>> #endif >>> >> > > FreeBSD boot relies on CONFIG_API. Removing it will brick FreeBSD boots.... It will. But for me it is better to move driver to DM and break FreeBSD boot than removing ethernet driver. Feel free to fix CONFIG_API and we can enable that option again. Thanks, Michal
On 4 December 2015 at 13:50, Michal Simek <michal.simek@xilinx.com> wrote: > On 3.12.2015 18:57, Jeroen Hofstee wrote: >> Hi, >> >> On 03-12-15 17:09, Jagan Teki wrote: >>> On 3 December 2015 at 20:17, Michal Simek <michal.simek@xilinx.com> >>> wrote: >>>> CONFIG_API is causing compilation error when DM_ETH is enabled because >>>> eth_get_dev() is not available. >>> Then how come, freebsd elf generate w/o CONFIG_API? >>> >>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com> Reviewed-by: Jagan Teki <jteki@openedev.com> >>>> --- >>>> >>>> Changes in v3: None >>>> Changes in v2: None >>>> >>>> include/configs/zynq-common.h | 1 - >>>> 1 file changed, 1 deletion(-) >>>> >>>> diff --git a/include/configs/zynq-common.h >>>> b/include/configs/zynq-common.h >>>> index a9e6bf046a97..5db501188b18 100644 >>>> --- a/include/configs/zynq-common.h >>>> +++ b/include/configs/zynq-common.h >>>> @@ -297,7 +297,6 @@ >>>> >>>> /* Boot FreeBSD/vxWorks from an ELF image */ >>>> #if defined(CONFIG_ZYNQ_BOOT_FREEBSD) >>>> -# define CONFIG_API >>>> # define CONFIG_SYS_MMC_MAX_DEVICE 1 >>>> #endif >>>> >>> >> >> FreeBSD boot relies on CONFIG_API. Removing it will brick FreeBSD boots.... > > It will. But for me it is better to move driver to DM and break FreeBSD > boot than removing ethernet driver. > Feel free to fix CONFIG_API and we can enable that option again. thanks!
diff --git a/include/configs/zynq-common.h b/include/configs/zynq-common.h index a9e6bf046a97..5db501188b18 100644 --- a/include/configs/zynq-common.h +++ b/include/configs/zynq-common.h @@ -297,7 +297,6 @@ /* Boot FreeBSD/vxWorks from an ELF image */ #if defined(CONFIG_ZYNQ_BOOT_FREEBSD) -# define CONFIG_API # define CONFIG_SYS_MMC_MAX_DEVICE 1 #endif
CONFIG_API is causing compilation error when DM_ETH is enabled because eth_get_dev() is not available. Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- Changes in v3: None Changes in v2: None include/configs/zynq-common.h | 1 - 1 file changed, 1 deletion(-)