From patchwork Wed Apr 8 15:37:36 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vagrant Cascadian X-Patchwork-Id: 459329 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 664AC1401B1 for ; Thu, 9 Apr 2015 01:37:52 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 1AC58A742D; Wed, 8 Apr 2015 17:37:50 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EUzfebKwr154; Wed, 8 Apr 2015 17:37:49 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 5F9E9A7422; Wed, 8 Apr 2015 17:37:49 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 24808A7422 for ; Wed, 8 Apr 2015 17:37:46 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RhYorQoUVcfV for ; Wed, 8 Apr 2015 17:37:46 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from cascadia.aikidev.net (cascadia.aikidev.net [173.255.214.101]) by theia.denx.de (Postfix) with ESMTP id 8B8E5A7421 for ; Wed, 8 Apr 2015 17:37:41 +0200 (CEST) Received: from localhost (unknown [IPv6:2601:7:780:9bc:221a:6ff:fe04:64bd]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 00F6A3F20A; Wed, 8 Apr 2015 08:37:39 -0700 (PDT) From: Vagrant Cascadian To: Stefano Babic , Chris Kuethe , U-Boot Mailing List , Fabio Estevam , trini@konsulko.com In-Reply-To: <5524EC6E.5020804@denx.de> References: <1427370589-11291-1-git-send-email-andrej@inversepath.com> <20150326222314.GA6131@core.inversepath.com> <551BD75F.1000109@denx.de> <5524EC6E.5020804@denx.de> User-Agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) X-Hashcash: 1:20:150408:trini@konsulko.com::o5UfPTMNB3qpQqYC:00000000000000000000000000000000000000000000xQB X-Hashcash: 1:20:150408:chris.kuethe@gmail.com::MSBHbobSC8G1MJ1q:0000000000000000000000000000000000000001YmT X-Hashcash: 1:20:150408:u-boot@lists.denx.de::W58jhNeDbu2oD3YE:000000000000000000000000000000000000000003F6m X-Hashcash: 1:20:150408:festevam@gmail.com::yBrkrPvsiE2mI+zn:000000000000000000000000000000000000000000098dU Date: Wed, 08 Apr 2015 08:37:36 -0700 Message-ID: <87fv8aaawv.fsf@aikidev.net> MIME-Version: 1.0 Subject: Re: [U-Boot] [PATCH v4 0/2] ARM: mx5: add support for USB armory board X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" On 2015-04-08, Stefano Babic wrote: > On 01/04/2015 13:32, Stefano Babic wrote: >> On 01/04/2015 04:46, Chris Kuethe wrote: >>> Any chance of this being accepted into 2015.04? > > checpatch reports some issues by patch 2/2. Can you please fix them and > resubmit ? Thanks ! Applying the patch below corrects most of the issues, but not all of the reported issues: Cleaned 2 patches 0 errors, 1 warnings, 0 checks for 0001-ARM-mx5-move-to-a-standard-arch-board-approach.patch: warning: arch/arm/Kconfig,440: please write a paragraph that describes the config symbol fully 0 errors, 1 warnings, 1 checks for 0002-ARM-mx5-add-support-for-USB-armory-board.patch: check: board/inversepath/usbarmory/usbarmory.c,382: Alignment should match open parenthesis warning: include/configs/usbarmory.h,41: line over 80 characters checkpatch.pl found 0 error(s), 2 warning(s), 1 checks(s) live well, vagrant diff --git a/board/inversepath/usbarmory/usbarmory.c b/board/inversepath/usbarmory/usbarmory.c index 3e60a86..573d586 100644 --- a/board/inversepath/usbarmory/usbarmory.c +++ b/board/inversepath/usbarmory/usbarmory.c @@ -68,13 +68,13 @@ static void setup_iomux_sd(void) NEW_PAD_CTRL(MX53_PAD_SD1_CMD__ESDHC1_CMD, SD_CMD_PAD_CTRL), NEW_PAD_CTRL(MX53_PAD_SD1_CLK__ESDHC1_CLK, MX53_SDHC_PAD_CTRL), NEW_PAD_CTRL(MX53_PAD_SD1_DATA0__ESDHC1_DAT0, - MX53_SDHC_PAD_CTRL), + MX53_SDHC_PAD_CTRL), NEW_PAD_CTRL(MX53_PAD_SD1_DATA1__ESDHC1_DAT1, - MX53_SDHC_PAD_CTRL), + MX53_SDHC_PAD_CTRL), NEW_PAD_CTRL(MX53_PAD_SD1_DATA2__ESDHC1_DAT2, - MX53_SDHC_PAD_CTRL), + MX53_SDHC_PAD_CTRL), NEW_PAD_CTRL(MX53_PAD_SD1_DATA3__ESDHC1_DAT3, - MX53_SDHC_PAD_CTRL), + MX53_SDHC_PAD_CTRL), MX53_PAD_EIM_DA13__GPIO3_13, }; @@ -85,7 +85,7 @@ static void setup_iomux_led(void) { static const iomux_v3_cfg_t pads[] = { NEW_PAD_CTRL(MX53_PAD_DISP0_DAT6__GPIO4_27, - PAD_CTL_PUS_100K_DOWN), + PAD_CTL_PUS_100K_DOWN), }; imx_iomux_v3_setup_multiple_pads(pads, ARRAY_SIZE(pads)); @@ -107,9 +107,9 @@ static void setup_iomux_pinheader(void) NEW_PAD_CTRL(MX53_PAD_CSI0_DAT8__GPIO5_26, PAD_CTRL_UP), NEW_PAD_CTRL(MX53_PAD_CSI0_DAT9__GPIO5_27, PAD_CTRL_UP), NEW_PAD_CTRL(MX53_PAD_CSI0_DAT10__UART1_TXD_MUX, - MX53_UART_PAD_CTRL), + MX53_UART_PAD_CTRL), NEW_PAD_CTRL(MX53_PAD_CSI0_DAT11__UART1_RXD_MUX, - MX53_UART_PAD_CTRL), + MX53_UART_PAD_CTRL), NEW_PAD_CTRL(MX53_PAD_CSI0_DAT12__GPIO5_30, PAD_CTRL_UP), }; @@ -119,7 +119,6 @@ static void setup_iomux_pinheader(void) static void setup_iomux_unused_boot(void) { static const iomux_v3_cfg_t pads[] = { - /* Pulled-up pads */ NEW_PAD_CTRL(MX53_PAD_EIM_A21__GPIO2_17, PAD_CTRL_UP), NEW_PAD_CTRL(MX53_PAD_EIM_DA0__GPIO3_0, PAD_CTRL_UP), @@ -155,7 +154,6 @@ static void setup_iomux_unused_nc(void) ROM is executed so we force all the not connected pins to a known state */ static const iomux_v3_cfg_t pads[] = { - /* CONTROL PINS block */ NEW_PAD_CTRL(MX53_PAD_GPIO_0__GPIO1_0, PAD_CTRL_UP), NEW_PAD_CTRL(MX53_PAD_GPIO_1__GPIO1_1, PAD_CTRL_UP),