diff mbox series

[v8,3/5] arm64: dts: ti: k3-am65-mcu: Add RTI watchdog entry

Message ID 789827a988a4ca6b418edb55e205918812564fd9.1631945876.git.jan.kiszka@siemens.com
State Deferred
Delegated to: Tom Rini
Headers show
Series Add SIMATIC IOT2050 board support | expand

Commit Message

Jan Kiszka Sept. 18, 2021, 6:17 a.m. UTC
From: Jan Kiszka <jan.kiszka@siemens.com>

Add the DT entry for a watchdog based on RTI1. It requires additional
firmware on the MCU R5F cores to handle the expiry, e.g.
https://github.com/siemens/k3-rti-wdt. As this firmware will also lock
the power domain to protect it against premature shutdown, mark it
shared.

Aligns us to the kernel's DT in this regard.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 arch/arm/dts/k3-am65-mcu.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Tom Rini Oct. 3, 2021, 6:40 p.m. UTC | #1
On Sat, Sep 18, 2021 at 08:17:54AM +0200, Jan Kiszka wrote:

> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Add the DT entry for a watchdog based on RTI1. It requires additional
> firmware on the MCU R5F cores to handle the expiry, e.g.
> https://github.com/siemens/k3-rti-wdt. As this firmware will also lock
> the power domain to protect it against premature shutdown, mark it
> shared.
> 
> Aligns us to the kernel's DT in this regard.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  arch/arm/dts/k3-am65-mcu.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm/dts/k3-am65-mcu.dtsi b/arch/arm/dts/k3-am65-mcu.dtsi
> index 7454c8cec0..903796bf7d 100644
> --- a/arch/arm/dts/k3-am65-mcu.dtsi
> +++ b/arch/arm/dts/k3-am65-mcu.dtsi
> @@ -308,4 +308,13 @@
>  			ti,loczrama = <1>;
>  		};
>  	};
> +
> +	mcu_rti1: rti@40610000 {
> +		compatible = "ti,j7-rti-wdt";
> +		reg = <0x0 0x40610000 0x0 0x100>;
> +		clocks = <&k3_clks 135 0>;
> +		power-domains = <&k3_pds 135 TI_SCI_PD_SHARED>;
> +		assigned-clocks = <&k3_clks 135 0>;
> +		assigned-clock-parents = <&k3_clks 135 4>;
> +	};
>  };

So, in applying
https://patchwork.ozlabs.org/project/uboot/patch/20210910213743.30793-1-trini@konsulko.com/
to bring us fully to v5.14 for K3 platforms, this patch is no longer
needed, and I'm deferring it.  The only difference is the node name is
"watchdog@40610000" not "rti@40610000" but should not matter (and
doesn't look to from a quick read of the rest of the series.
Jan Kiszka Oct. 4, 2021, 7:44 a.m. UTC | #2
On 03.10.21 20:40, Tom Rini wrote:
> On Sat, Sep 18, 2021 at 08:17:54AM +0200, Jan Kiszka wrote:
> 
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> Add the DT entry for a watchdog based on RTI1. It requires additional
>> firmware on the MCU R5F cores to handle the expiry, e.g.
>> https://github.com/siemens/k3-rti-wdt. As this firmware will also lock
>> the power domain to protect it against premature shutdown, mark it
>> shared.
>>
>> Aligns us to the kernel's DT in this regard.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>  arch/arm/dts/k3-am65-mcu.dtsi | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/arm/dts/k3-am65-mcu.dtsi b/arch/arm/dts/k3-am65-mcu.dtsi
>> index 7454c8cec0..903796bf7d 100644
>> --- a/arch/arm/dts/k3-am65-mcu.dtsi
>> +++ b/arch/arm/dts/k3-am65-mcu.dtsi
>> @@ -308,4 +308,13 @@
>>  			ti,loczrama = <1>;
>>  		};
>>  	};
>> +
>> +	mcu_rti1: rti@40610000 {
>> +		compatible = "ti,j7-rti-wdt";
>> +		reg = <0x0 0x40610000 0x0 0x100>;
>> +		clocks = <&k3_clks 135 0>;
>> +		power-domains = <&k3_pds 135 TI_SCI_PD_SHARED>;
>> +		assigned-clocks = <&k3_clks 135 0>;
>> +		assigned-clock-parents = <&k3_clks 135 4>;
>> +	};
>>  };
> 
> So, in applying
> https://patchwork.ozlabs.org/project/uboot/patch/20210910213743.30793-1-trini@konsulko.com/
> to bring us fully to v5.14 for K3 platforms, this patch is no longer
> needed, and I'm deferring it.  The only difference is the node name is
> "watchdog@40610000" not "rti@40610000" but should not matter (and
> doesn't look to from a quick read of the rest of the series.
> 

Ack, this is now obsolete.

Jan
diff mbox series

Patch

diff --git a/arch/arm/dts/k3-am65-mcu.dtsi b/arch/arm/dts/k3-am65-mcu.dtsi
index 7454c8cec0..903796bf7d 100644
--- a/arch/arm/dts/k3-am65-mcu.dtsi
+++ b/arch/arm/dts/k3-am65-mcu.dtsi
@@ -308,4 +308,13 @@ 
 			ti,loczrama = <1>;
 		};
 	};
+
+	mcu_rti1: rti@40610000 {
+		compatible = "ti,j7-rti-wdt";
+		reg = <0x0 0x40610000 0x0 0x100>;
+		clocks = <&k3_clks 135 0>;
+		power-domains = <&k3_pds 135 TI_SCI_PD_SHARED>;
+		assigned-clocks = <&k3_clks 135 0>;
+		assigned-clock-parents = <&k3_clks 135 4>;
+	};
 };