| Message ID | 6234350a-bb9b-a63d-151a-58b18db5a8e3@samsung.com |
|---|---|
| State | Accepted |
| Commit | 1411298cbca83a8527d2c1b5c4d299871fc34cf1 |
| Delegated to: | Minkyu Kang |
| Headers | show |
| Series | [U-Boot] arndale: fix unknown status | expand |
On 14/03/2019 09:44, Minkyu Kang wrote: > set status to Maintained > > Signed-off-by: Minkyu Kang <mk7.kang@samsung.com> > Cc: Krzysztof Kozlowski <krzk@kernel.org> > --- > board/samsung/arndale/MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/board/samsung/arndale/MAINTAINERS b/board/samsung/arndale/MAINTAINERS > index 98ccaa4..aa64c7a 100644 > --- a/board/samsung/arndale/MAINTAINERS > +++ b/board/samsung/arndale/MAINTAINERS > @@ -1,6 +1,6 @@ > ARNDALE BOARD > M: Krzysztof Kozlowski <krzk@kernel.org> > -S: Odd Fixes > +S: Maintained > F: board/samsung/arndale/ > F: include/configs/arndale.h > F: configs/arndale_defconfig > applied to u-boot-samsung. Thanks, Minkyu Kang.
On Thu, 14 Mar 2019 at 05:10, Minkyu Kang <mk7.kang@samsung.com> wrote: > > On 14/03/2019 09:44, Minkyu Kang wrote: > > set status to Maintained > > > > Signed-off-by: Minkyu Kang <mk7.kang@samsung.com> > > Cc: Krzysztof Kozlowski <krzk@kernel.org> > > --- > > board/samsung/arndale/MAINTAINERS | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/board/samsung/arndale/MAINTAINERS b/board/samsung/arndale/MAINTAINERS > > index 98ccaa4..aa64c7a 100644 > > --- a/board/samsung/arndale/MAINTAINERS > > +++ b/board/samsung/arndale/MAINTAINERS > > @@ -1,6 +1,6 @@ > > ARNDALE BOARD > > M: Krzysztof Kozlowski <krzk@kernel.org> > > -S: Odd Fixes > > +S: Maintained > > F: board/samsung/arndale/ > > F: include/configs/arndale.h > > F: configs/arndale_defconfig > > > > applied to u-boot-samsung. Hi, In the commit changing the maintainer I changed on purpose to Odd Fixes. Because the board is not actively maintained. It is not "unknown status", it is perfectly valid status. Why changing it to Maintained? Best regards, Krzysztof
Hi, On 14/03/2019 16:38, Krzysztof Kozlowski wrote: > On Thu, 14 Mar 2019 at 05:10, Minkyu Kang <mk7.kang@samsung.com> wrote: >> >> On 14/03/2019 09:44, Minkyu Kang wrote: >>> set status to Maintained >>> >>> Signed-off-by: Minkyu Kang <mk7.kang@samsung.com> >>> Cc: Krzysztof Kozlowski <krzk@kernel.org> >>> --- >>> board/samsung/arndale/MAINTAINERS | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/board/samsung/arndale/MAINTAINERS b/board/samsung/arndale/MAINTAINERS >>> index 98ccaa4..aa64c7a 100644 >>> --- a/board/samsung/arndale/MAINTAINERS >>> +++ b/board/samsung/arndale/MAINTAINERS >>> @@ -1,6 +1,6 @@ >>> ARNDALE BOARD >>> M: Krzysztof Kozlowski <krzk@kernel.org> >>> -S: Odd Fixes >>> +S: Maintained >>> F: board/samsung/arndale/ >>> F: include/configs/arndale.h >>> F: configs/arndale_defconfig >>> >> >> applied to u-boot-samsung. > > Hi, > > In the commit changing the maintainer I changed on purpose to Odd > Fixes. Because the board is not actively maintained. It is not > "unknown status", it is perfectly valid status. Why changing it to > Maintained? > $ ./tools/genboardscfg.py -f WARNING: Odd Fixes: unknown status for 'arndale' If you don't want to maintain then, it would be set to Orphan? Thanks, Minkyu Kang.
On Thu, 14 Mar 2019 at 09:15, Minkyu Kang <mk7.kang@samsung.com> wrote: > > Hi, > > On 14/03/2019 16:38, Krzysztof Kozlowski wrote: > > On Thu, 14 Mar 2019 at 05:10, Minkyu Kang <mk7.kang@samsung.com> wrote: > >> > >> On 14/03/2019 09:44, Minkyu Kang wrote: > >>> set status to Maintained > >>> > >>> Signed-off-by: Minkyu Kang <mk7.kang@samsung.com> > >>> Cc: Krzysztof Kozlowski <krzk@kernel.org> > >>> --- > >>> board/samsung/arndale/MAINTAINERS | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/board/samsung/arndale/MAINTAINERS b/board/samsung/arndale/MAINTAINERS > >>> index 98ccaa4..aa64c7a 100644 > >>> --- a/board/samsung/arndale/MAINTAINERS > >>> +++ b/board/samsung/arndale/MAINTAINERS > >>> @@ -1,6 +1,6 @@ > >>> ARNDALE BOARD > >>> M: Krzysztof Kozlowski <krzk@kernel.org> > >>> -S: Odd Fixes > >>> +S: Maintained > >>> F: board/samsung/arndale/ > >>> F: include/configs/arndale.h > >>> F: configs/arndale_defconfig > >>> > >> > >> applied to u-boot-samsung. > > > > Hi, > > > > In the commit changing the maintainer I changed on purpose to Odd > > Fixes. Because the board is not actively maintained. It is not > > "unknown status", it is perfectly valid status. Why changing it to > > Maintained? > > > > $ ./tools/genboardscfg.py -f > WARNING: Odd Fixes: unknown status for 'arndale' > > If you don't want to maintain then, it would be set to Orphan? I think then the genboardscfg.py should be updated because "Odd fixer" is a valid entry from MAINTAINERS (although not popular). "Odd Fixes: It has a maintainer but they don't have time to do much other than throw the odd patch in. See below.." The board is pretty close to being orphaned but not yet. Best regards, Krzysztof
On Thu, Mar 14, 2019 at 09:23:53AM +0100, Krzysztof Kozlowski wrote: > On Thu, 14 Mar 2019 at 09:15, Minkyu Kang <mk7.kang@samsung.com> wrote: > > > > Hi, > > > > On 14/03/2019 16:38, Krzysztof Kozlowski wrote: > > > On Thu, 14 Mar 2019 at 05:10, Minkyu Kang <mk7.kang@samsung.com> wrote: > > >> > > >> On 14/03/2019 09:44, Minkyu Kang wrote: > > >>> set status to Maintained > > >>> > > >>> Signed-off-by: Minkyu Kang <mk7.kang@samsung.com> > > >>> Cc: Krzysztof Kozlowski <krzk@kernel.org> > > >>> --- > > >>> board/samsung/arndale/MAINTAINERS | 2 +- > > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > > >>> > > >>> diff --git a/board/samsung/arndale/MAINTAINERS b/board/samsung/arndale/MAINTAINERS > > >>> index 98ccaa4..aa64c7a 100644 > > >>> --- a/board/samsung/arndale/MAINTAINERS > > >>> +++ b/board/samsung/arndale/MAINTAINERS > > >>> @@ -1,6 +1,6 @@ > > >>> ARNDALE BOARD > > >>> M: Krzysztof Kozlowski <krzk@kernel.org> > > >>> -S: Odd Fixes > > >>> +S: Maintained > > >>> F: board/samsung/arndale/ > > >>> F: include/configs/arndale.h > > >>> F: configs/arndale_defconfig > > >>> > > >> > > >> applied to u-boot-samsung. > > > > > > Hi, > > > > > > In the commit changing the maintainer I changed on purpose to Odd > > > Fixes. Because the board is not actively maintained. It is not > > > "unknown status", it is perfectly valid status. Why changing it to > > > Maintained? > > > > > > > $ ./tools/genboardscfg.py -f > > WARNING: Odd Fixes: unknown status for 'arndale' > > > > If you don't want to maintain then, it would be set to Orphan? > > I think then the genboardscfg.py should be updated because "Odd fixer" > is a valid entry from MAINTAINERS (although not popular). > "Odd Fixes: It has a maintainer but they don't have time to do much > other than throw the odd patch in. See below.." > The board is pretty close to being orphaned but not yet. I'm taking your patch to the MAINTAINERS file now. That said, generally "odd fixes" are what's required of board maintainers, once the port is in. However, as we push forward on moving to various frameworks that should make life easier overall, over the long term, changes are needed that may be more than just an occasional fix. Looking at arndale right now for example: arm: w+ arndale +(arndale) ===================== WARNING ====================== +(arndale) This board uses CONFIG_DM_I2C_COMPAT. Please remove +(arndale) (possibly in a subsequent patch in your series) +(arndale) before sending patches to the mailing list. +(arndale) ==================================================== So, do you have time to look into that build time warning? Thanks!
On Thu, 14 Mar 2019 at 20:24, Tom Rini <trini@konsulko.com> wrote: > I'm taking your patch to the MAINTAINERS file now. That said, generally > "odd fixes" are what's required of board maintainers, once the port is > in. However, as we push forward on moving to various frameworks that > should make life easier overall, over the long term, changes are needed > that may be more than just an occasional fix. Looking at arndale right > now for example: > arm: w+ arndale > +(arndale) ===================== WARNING ====================== > +(arndale) This board uses CONFIG_DM_I2C_COMPAT. Please remove > +(arndale) (possibly in a subsequent patch in your series) > +(arndale) before sending patches to the mailing list. > +(arndale) ==================================================== > > So, do you have time to look into that build time warning? Thanks! Sure, let me take a look. Best regards, Krzysztof
On Fri, Mar 15, 2019 at 02:52:12PM +0100, Krzysztof Kozlowski wrote: > On Thu, 14 Mar 2019 at 20:24, Tom Rini <trini@konsulko.com> wrote: > > I'm taking your patch to the MAINTAINERS file now. That said, generally > > "odd fixes" are what's required of board maintainers, once the port is > > in. However, as we push forward on moving to various frameworks that > > should make life easier overall, over the long term, changes are needed > > that may be more than just an occasional fix. Looking at arndale right > > now for example: > > arm: w+ arndale > > +(arndale) ===================== WARNING ====================== > > +(arndale) This board uses CONFIG_DM_I2C_COMPAT. Please remove > > +(arndale) (possibly in a subsequent patch in your series) > > +(arndale) before sending patches to the mailing list. > > +(arndale) ==================================================== > > > > So, do you have time to look into that build time warning? Thanks! > > Sure, let me take a look. Thanks!
diff --git a/board/samsung/arndale/MAINTAINERS b/board/samsung/arndale/MAINTAINERS index 98ccaa4..aa64c7a 100644 --- a/board/samsung/arndale/MAINTAINERS +++ b/board/samsung/arndale/MAINTAINERS @@ -1,6 +1,6 @@ ARNDALE BOARD M: Krzysztof Kozlowski <krzk@kernel.org> -S: Odd Fixes +S: Maintained F: board/samsung/arndale/ F: include/configs/arndale.h F: configs/arndale_defconfig
set status to Maintained Signed-off-by: Minkyu Kang <mk7.kang@samsung.com> Cc: Krzysztof Kozlowski <krzk@kernel.org> --- board/samsung/arndale/MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)