mbox series

Pull request: u-boot-imx u-boot-imx-20210720

Message ID 5eec1cef-521b-f612-fb24-85314486c35c@denx.de
State Changes Requested
Delegated to: Tom Rini
Headers show
Series Pull request: u-boot-imx u-boot-imx-20210720 | expand

Pull-request

https://gitlab.denx.de/u-boot/custodians/u-boot-imx.git tags/u-boot-imx-20210720

Message

Stefano Babic July 20, 2021, 3:17 p.m. UTC
Hi Tom,

please pull from u-boot-imx, thanks !

The following changes since commit f929ce50727bf1019323d6c199dfd3a5755c5474:

   Merge branch '2021-07-16-cleanup-image-support' (2021-07-17 11:39:50 
-0400)

are available in the Git repository at:

   https://gitlab.denx.de/u-boot/custodians/u-boot-imx.git 
tags/u-boot-imx-20210720

for you to fetch changes up to bd8e26606db62a0434c7f09adfa6ec666b36985b:

   imx: imx8mm: Add support for Kontron Electronics SL/BL i.MX8M-Mini 
boards (N801x) (2021-07-19 23:30:47 +0200)

----------------------------------------------------------------
CI: https://source.denx.de/u-boot/custodians/u-boot-imx/-/pipelines/8325

- imx8:
	add support for i.MX8ULP
	Kontron MX8MM
- imx6ul:
	Kontron mx6ul

----------------------------------------------------------------
Frieder Schrempf (2):
       imx: imx6ul: Add support for Kontron Electronics SL/BL 
i.MX6UL/ULL boards (N63xx/N64xx)
       imx: imx8mm: Add support for Kontron Electronics SL/BL 
i.MX8M-Mini boards (N801x)

Peng Fan (24):
       arm: imx: add i.MX8ULP basic Kconfig option
       arm: imx: add i.MX8ULP cpu type and helper
       arm: imx: sys_proto: move boot mode define to common header
       arm: imx8ulp: support print cpu info
       imx: imx8ulp: add get reset cause
       arm: imx: basic i.MX8ULP support
       arm: imx: parse-container: guard included header files
       arm: imx: move container Kconfig under mach-imx
       net: fec_mxc: support i.MX8ULP
       driver: serial: fsl_lpuart: support i.MX8ULP
       arm: imx8ulp: add clock support
       drivers: mmc: fsl_esdhc_imx: support i.MX8ULP
       arm: imx8ulp: disable wdog3
       arm: imx8ulp: add rdc support
       arm: imx8ulp: add trdc release request
       arm: imx8ulp: release trdc and assign lpav from RTD to APD
       imx8ulp: unify rdc functions
       arm: imx8ulp: add dummy imx_get_mac_from_fuse
       arm: imx8ulp: add iomuxc support
       imx8ulp: soc: correct reset cause
       imx8ulp: move struct mu_type to common header
       imx8ulp: add upower api support
       arm: dts: add i.MX8ULP dtsi
       arm: imx: add i.MX8ULP EVK support

Ye Li (20):
       arm: imx8: Move container parser and image to mach-imx common folder
       arm: imx8: Move container image header file to mach-imx
       arm: imx8ulp: add container support
       driver: misc: Add MU and S400 API to communicate with Sentinel
       pinctrl: Add pinctrl driver for imx8ulp
       arm: imx8ulp: soc: Change to use CMC1 to get bootcfg
       arm: imx8ulp: Enable full L2 cache in SPL
       arm: imx8ulp: Update the reset vector in u-boot
       drivers: misc: s400_api: Update S400_SUCCESS_IND to 0xd6
       drivers: misc: imx8ulp: Add S400 API for image authentication
       drivers: misc: imx8ulp: Update S400 API for release RDC
       drivers: misc: s400_api: Update API for fuse read and write
       arm: imx8ulp: release and configure XRDC at early phase
       arm: imx8ulp: Probe the S400 MU device in arch init
       arm: iMX8ULP: Add boot device relevant functions
       arm: imx8ulp: Allocate DCNANO and MIPI_DSI to AD domain
       driver: misc: imx8ulp: Add fuse driver for imx8ulp
       imx8ulp: Use DGO_GP5 to get boot config
       imx8ulp: Add workaround for eMMC boot
       ddr: Add DDR driver for iMX8ULP

  arch/arm/Kconfig                                      |   11 ++
  arch/arm/Makefile                                     |    4 +-
  arch/arm/dts/Makefile                                 |    9 +-
  arch/arm/dts/imx6ul-kontron-n631x-s-u-boot.dtsi       |    7 ++
  arch/arm/dts/imx6ul-kontron-n631x-s.dts               |   17 +++
  arch/arm/dts/imx6ul-kontron-n631x-som.dtsi            |   14 +++
  arch/arm/dts/imx6ul-kontron-n6x1x-s-u-boot.dtsi       |   98 
+++++++++++++++++
  arch/arm/dts/imx6ul-kontron-n6x1x-s.dts               |  423 
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  arch/arm/dts/imx6ul-kontron-n6x1x-s.dtsi              |  420 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  arch/arm/dts/imx6ul-kontron-n6x1x-som-common.dtsi     |  124 
++++++++++++++++++++++
  arch/arm/dts/imx6ull-kontron-n641x-s-u-boot.dtsi      |    7 ++
  arch/arm/dts/imx6ull-kontron-n641x-s.dts              |   16 +++
  arch/arm/dts/imx6ull-kontron-n641x-som.dtsi           |   13 +++
  arch/arm/dts/imx8mm-kontron-n801x-s-lvds.dts          |  116 
++++++++++++++++++++
  arch/arm/dts/imx8mm-kontron-n801x-s-u-boot.dtsi       |  237 
+++++++++++++++++++++++++++++++++++++++++
  arch/arm/dts/imx8mm-kontron-n801x-s.dts               |  387 
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  arch/arm/dts/imx8mm-kontron-n801x-som.dtsi            |  298 
++++++++++++++++++++++++++++++++++++++++++++++++++++
  arch/arm/dts/imx8ulp-evk-u-boot.dtsi                  |   40 +++++++
  arch/arm/dts/imx8ulp-evk.dts                          |  223 
+++++++++++++++++++++++++++++++++++++++
  arch/arm/dts/imx8ulp-pinfunc.h                        |  978 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  arch/arm/dts/imx8ulp.dtsi                             |  728 
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  arch/arm/include/asm/arch-imx/cpu.h                   |    4 +
  arch/arm/include/asm/arch-imx8ulp/cgc.h               |  130 
+++++++++++++++++++++++
  arch/arm/include/asm/arch-imx8ulp/clock.h             |   41 ++++++++
  arch/arm/include/asm/arch-imx8ulp/ddr.h               |   38 +++++++
  arch/arm/include/asm/arch-imx8ulp/gpio.h              |   20 ++++
  arch/arm/include/asm/arch-imx8ulp/imx-regs.h          |  162 
++++++++++++++++++++++++++++
  arch/arm/include/asm/arch-imx8ulp/imx8ulp-pins.h      |   60 +++++++++++
  arch/arm/include/asm/arch-imx8ulp/iomux.h             |   82 
+++++++++++++++
  arch/arm/include/asm/arch-imx8ulp/mu_hal.h            |   12 +++
  arch/arm/include/asm/arch-imx8ulp/pcc.h               |  139 
++++++++++++++++++++++++
  arch/arm/include/asm/arch-imx8ulp/rdc.h               |   27 +++++
  arch/arm/include/asm/arch-imx8ulp/s400_api.h          |   41 ++++++++
  arch/arm/include/asm/arch-imx8ulp/sys_proto.h         |   19 ++++
  arch/arm/include/asm/arch-imx8ulp/upower.h            |   15 +++
  arch/arm/include/asm/arch-mx7ulp/sys_proto.h          |    9 --
  arch/arm/include/asm/global_data.h                    |    5 +
  arch/arm/include/asm/{arch-imx8 => mach-imx}/image.h  |    2 +
  arch/arm/include/asm/mach-imx/sys_proto.h             |   13 ++-
  arch/arm/mach-imx/Kconfig                             |   15 ++-
  arch/arm/mach-imx/Makefile                            |    5 +
  arch/arm/mach-imx/cmd_dek.c                           |    2 +-
  arch/arm/mach-imx/{imx8/image.c => image-container.c} |   51 +++++++--
  arch/arm/mach-imx/imx8/Kconfig                        |   13 ---
  arch/arm/mach-imx/imx8/Makefile                       |    3 -
  arch/arm/mach-imx/imx8/ahab.c                         |    2 +-
  arch/arm/mach-imx/imx8m/Kconfig                       |    8 ++
  arch/arm/mach-imx/imx8ulp/Kconfig                     |   23 ++++
  arch/arm/mach-imx/imx8ulp/Makefile                    |   11 ++
  arch/arm/mach-imx/imx8ulp/cgc.c                       |  455 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  arch/arm/mach-imx/imx8ulp/clock.c                     |  397 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  arch/arm/mach-imx/imx8ulp/iomux.c                     |   58 ++++++++++
  arch/arm/mach-imx/imx8ulp/lowlevel_init.S             |   26 +++++
  arch/arm/mach-imx/imx8ulp/pcc.c                       |  449 
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  arch/arm/mach-imx/imx8ulp/rdc.c                       |  411 
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  arch/arm/mach-imx/imx8ulp/soc.c                       |  544 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  arch/arm/mach-imx/imx8ulp/upower/Makefile             |    6 ++
  arch/arm/mach-imx/imx8ulp/upower/upower_api.c         |  485 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  arch/arm/mach-imx/imx8ulp/upower/upower_api.h         |  258 
+++++++++++++++++++++++++++++++++++++++++++++
  arch/arm/mach-imx/imx8ulp/upower/upower_hal.c         |  179 
+++++++++++++++++++++++++++++++
  arch/arm/mach-imx/mx6/Kconfig                         |    9 ++
  arch/arm/mach-imx/{imx8 => }/parse-container.c        |    4 +-
  arch/arm/mach-imx/spl_imx_romapi.c                    |  172 
+++++++++++++++++++++++-------
  board/freescale/imx8ulp_evk/Kconfig                   |   14 +++
  board/freescale/imx8ulp_evk/MAINTAINERS               |    6 ++
  board/freescale/imx8ulp_evk/Makefile                  |    7 ++
  board/freescale/imx8ulp_evk/ddr_init.c                |  207 
++++++++++++++++++++++++++++++++++++
  board/freescale/imx8ulp_evk/imx8ulp_evk.c             |   67 ++++++++++++
  board/freescale/imx8ulp_evk/lpddr4_timing.c           | 1158 
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  board/freescale/imx8ulp_evk/spl.c                     |  115 
++++++++++++++++++++
  board/kontron/sl-mx6ul/Kconfig                        |   15 +++
  board/kontron/sl-mx6ul/MAINTAINERS                    |    9 ++
  board/kontron/sl-mx6ul/Makefile                       |    8 ++
  board/kontron/sl-mx6ul/kontron_mx6ul.c                |   85 
+++++++++++++++
  board/kontron/sl-mx6ul/spl.c                          |  376 
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  board/kontron/sl-mx8mm/Kconfig                        |   15 +++
  board/kontron/sl-mx8mm/MAINTAINERS                    |    7 ++
  board/kontron/sl-mx8mm/Makefile                       |    9 ++
  board/kontron/sl-mx8mm/imximage.cfg                   |    9 ++
  board/kontron/sl-mx8mm/kontron_mx8mm.c                |  102 
++++++++++++++++++
  board/kontron/sl-mx8mm/lpddr4_timing.c                | 1846 
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  board/kontron/sl-mx8mm/spl.c                          |  322 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  configs/imx8ulp_evk_defconfig                         |  103 
++++++++++++++++++
  configs/kontron_mx6ul_defconfig                       |  109 
+++++++++++++++++++
  configs/kontron_mx8mm_defconfig                       |  124 
++++++++++++++++++++++
  drivers/Makefile                                      |    1 +
  drivers/ddr/imx/Kconfig                               |    1 +
  drivers/ddr/imx/imx8ulp/Kconfig                       |   11 ++
  drivers/ddr/imx/imx8ulp/Makefile                      |    9 ++
  drivers/ddr/imx/imx8ulp/ddr_init.c                    |  217 
++++++++++++++++++++++++++++++++++++++
  drivers/misc/Makefile                                 |    1 +
  drivers/misc/imx8ulp/Makefile                         |    4 +
  drivers/misc/imx8ulp/fuse.c                           |  198 
++++++++++++++++++++++++++++++++++
  drivers/misc/imx8ulp/imx8ulp_mu.c                     |  234 
+++++++++++++++++++++++++++++++++++++++++
  drivers/misc/imx8ulp/s400_api.c                       |  244 
++++++++++++++++++++++++++++++++++++++++++
  drivers/mmc/Kconfig                                   |    2 +-
  drivers/mmc/fsl_esdhc_imx.c                           |   12 ++-
  drivers/net/Kconfig                                   |    2 +-
  drivers/net/fec_mxc.c                                 |    2 +-
  drivers/pinctrl/nxp/Kconfig                           |   14 +++
  drivers/pinctrl/nxp/Makefile                          |    1 +
  drivers/pinctrl/nxp/pinctrl-imx8ulp.c                 |   44 ++++++++
  include/configs/imx8ulp_evk.h                         |  107 
+++++++++++++++++++
  include/configs/kontron_common.h                      |   86 
+++++++++++++++
  include/configs/kontron_mx6ul.h                       |   52 +++++++++
  include/configs/kontron_mx8mm.h                       |   66 ++++++++++++
  include/dt-bindings/clock/imx8ulp-clock.h             |  247 
+++++++++++++++++++++++++++++++++++++++++++
  include/fsl_lpuart.h                                  |    2 +-
  108 files changed, 14758 insertions(+), 87 deletions(-)
  create mode 100644 arch/arm/dts/imx6ul-kontron-n631x-s-u-boot.dtsi
  create mode 100644 arch/arm/dts/imx6ul-kontron-n631x-s.dts
  create mode 100644 arch/arm/dts/imx6ul-kontron-n631x-som.dtsi
  create mode 100644 arch/arm/dts/imx6ul-kontron-n6x1x-s-u-boot.dtsi
  create mode 100644 arch/arm/dts/imx6ul-kontron-n6x1x-s.dts
  create mode 100644 arch/arm/dts/imx6ul-kontron-n6x1x-s.dtsi
  create mode 100644 arch/arm/dts/imx6ul-kontron-n6x1x-som-common.dtsi
  create mode 100644 arch/arm/dts/imx6ull-kontron-n641x-s-u-boot.dtsi
  create mode 100644 arch/arm/dts/imx6ull-kontron-n641x-s.dts
  create mode 100644 arch/arm/dts/imx6ull-kontron-n641x-som.dtsi
  create mode 100644 arch/arm/dts/imx8mm-kontron-n801x-s-lvds.dts
  create mode 100644 arch/arm/dts/imx8mm-kontron-n801x-s-u-boot.dtsi
  create mode 100644 arch/arm/dts/imx8mm-kontron-n801x-s.dts
  create mode 100644 arch/arm/dts/imx8mm-kontron-n801x-som.dtsi
  create mode 100644 arch/arm/dts/imx8ulp-evk-u-boot.dtsi
  create mode 100644 arch/arm/dts/imx8ulp-evk.dts
  create mode 100644 arch/arm/dts/imx8ulp-pinfunc.h
  create mode 100644 arch/arm/dts/imx8ulp.dtsi
  create mode 100644 arch/arm/include/asm/arch-imx8ulp/cgc.h
  create mode 100644 arch/arm/include/asm/arch-imx8ulp/clock.h
  create mode 100644 arch/arm/include/asm/arch-imx8ulp/ddr.h
  create mode 100644 arch/arm/include/asm/arch-imx8ulp/gpio.h
  create mode 100644 arch/arm/include/asm/arch-imx8ulp/imx-regs.h
  create mode 100644 arch/arm/include/asm/arch-imx8ulp/imx8ulp-pins.h
  create mode 100644 arch/arm/include/asm/arch-imx8ulp/iomux.h
  create mode 100644 arch/arm/include/asm/arch-imx8ulp/mu_hal.h
  create mode 100644 arch/arm/include/asm/arch-imx8ulp/pcc.h
  create mode 100644 arch/arm/include/asm/arch-imx8ulp/rdc.h
  create mode 100644 arch/arm/include/asm/arch-imx8ulp/s400_api.h
  create mode 100644 arch/arm/include/asm/arch-imx8ulp/sys_proto.h
  create mode 100644 arch/arm/include/asm/arch-imx8ulp/upower.h
  rename arch/arm/include/asm/{arch-imx8 => mach-imx}/image.h (95%)
  rename arch/arm/mach-imx/{imx8/image.c => image-container.c} (79%)
  create mode 100644 arch/arm/mach-imx/imx8ulp/Kconfig
  create mode 100644 arch/arm/mach-imx/imx8ulp/Makefile
  create mode 100644 arch/arm/mach-imx/imx8ulp/cgc.c
  create mode 100644 arch/arm/mach-imx/imx8ulp/clock.c
  create mode 100644 arch/arm/mach-imx/imx8ulp/iomux.c
  create mode 100644 arch/arm/mach-imx/imx8ulp/lowlevel_init.S
  create mode 100644 arch/arm/mach-imx/imx8ulp/pcc.c
  create mode 100644 arch/arm/mach-imx/imx8ulp/rdc.c
  create mode 100644 arch/arm/mach-imx/imx8ulp/soc.c
  create mode 100644 arch/arm/mach-imx/imx8ulp/upower/Makefile
  create mode 100644 arch/arm/mach-imx/imx8ulp/upower/upower_api.c
  create mode 100644 arch/arm/mach-imx/imx8ulp/upower/upower_api.h
  create mode 100644 arch/arm/mach-imx/imx8ulp/upower/upower_hal.c
  rename arch/arm/mach-imx/{imx8 => }/parse-container.c (98%)
  create mode 100644 board/freescale/imx8ulp_evk/Kconfig
  create mode 100644 board/freescale/imx8ulp_evk/MAINTAINERS
  create mode 100644 board/freescale/imx8ulp_evk/Makefile
  create mode 100644 board/freescale/imx8ulp_evk/ddr_init.c
  create mode 100644 board/freescale/imx8ulp_evk/imx8ulp_evk.c
  create mode 100644 board/freescale/imx8ulp_evk/lpddr4_timing.c
  create mode 100644 board/freescale/imx8ulp_evk/spl.c
  create mode 100644 board/kontron/sl-mx6ul/Kconfig
  create mode 100644 board/kontron/sl-mx6ul/MAINTAINERS
  create mode 100644 board/kontron/sl-mx6ul/Makefile
  create mode 100644 board/kontron/sl-mx6ul/kontron_mx6ul.c
  create mode 100644 board/kontron/sl-mx6ul/spl.c
  create mode 100644 board/kontron/sl-mx8mm/Kconfig
  create mode 100644 board/kontron/sl-mx8mm/MAINTAINERS
  create mode 100644 board/kontron/sl-mx8mm/Makefile
  create mode 100644 board/kontron/sl-mx8mm/imximage.cfg
  create mode 100644 board/kontron/sl-mx8mm/kontron_mx8mm.c
  create mode 100644 board/kontron/sl-mx8mm/lpddr4_timing.c
  create mode 100644 board/kontron/sl-mx8mm/spl.c
  create mode 100644 configs/imx8ulp_evk_defconfig
  create mode 100644 configs/kontron_mx6ul_defconfig
  create mode 100644 configs/kontron_mx8mm_defconfig
  create mode 100644 drivers/ddr/imx/imx8ulp/Kconfig
  create mode 100644 drivers/ddr/imx/imx8ulp/Makefile
  create mode 100644 drivers/ddr/imx/imx8ulp/ddr_init.c
  create mode 100644 drivers/misc/imx8ulp/Makefile
  create mode 100644 drivers/misc/imx8ulp/fuse.c
  create mode 100644 drivers/misc/imx8ulp/imx8ulp_mu.c
  create mode 100644 drivers/misc/imx8ulp/s400_api.c
  create mode 100644 drivers/pinctrl/nxp/pinctrl-imx8ulp.c
  create mode 100644 include/configs/imx8ulp_evk.h
  create mode 100644 include/configs/kontron_common.h
  create mode 100644 include/configs/kontron_mx6ul.h
  create mode 100644 include/configs/kontron_mx8mm.h
  create mode 100644 include/dt-bindings/clock/imx8ulp-clock.h

Best regards,
Stefano

Comments

Tom Rini July 20, 2021, 5:45 p.m. UTC | #1
On Tue, Jul 20, 2021 at 05:17:59PM +0200, Stefano Babic wrote:

> Hi Tom,
> 
> please pull from u-boot-imx, thanks !
> 
> The following changes since commit f929ce50727bf1019323d6c199dfd3a5755c5474:
> 
>   Merge branch '2021-07-16-cleanup-image-support' (2021-07-17 11:39:50
> -0400)
> 
> are available in the Git repository at:
> 
>   https://gitlab.denx.de/u-boot/custodians/u-boot-imx.git
> tags/u-boot-imx-20210720
> 
> for you to fetch changes up to bd8e26606db62a0434c7f09adfa6ec666b36985b:
> 
>   imx: imx8mm: Add support for Kontron Electronics SL/BL i.MX8M-Mini boards
> (N801x) (2021-07-19 23:30:47 +0200)
> 

NAK:

ERROR: fdt or initrd relocation disabled at boot time
#2019: FILE: include/configs/kontron_common.h:67:
+       "fdt_high=0xffffffff\0" \

And this is likely a bad idea too:
ERROR: fdt or initrd relocation disabled at boot time
#2020: FILE: include/configs/kontron_common.h:68:
+       "initrd_high=0xffffffff\0" \

but I haven't looked at all of include/configs/kontron_common.h to make
sure it follows all of the layout stuff documented for example in:
https://source.denx.de/u-boot/u-boot/-/blob/master/include/configs/ti_armv7_common.h#L32
(which is also true for aarch64 best I can tell from
https://www.kernel.org/doc/Documentation/arm64/booting.rst).

And since I'm noting things, checkpatch has a whole bunch of formatting
issues throughout as well (kontron and generic imx8 code both).
Frieder Schrempf July 21, 2021, 8:07 a.m. UTC | #2
Hi Tom, Stefano,

On 20.07.21 19:45, Tom Rini wrote:
> On Tue, Jul 20, 2021 at 05:17:59PM +0200, Stefano Babic wrote:
> 
>> Hi Tom,
>>
>> please pull from u-boot-imx, thanks !
>>
>> The following changes since commit f929ce50727bf1019323d6c199dfd3a5755c5474:
>>
>>   Merge branch '2021-07-16-cleanup-image-support' (2021-07-17 11:39:50
>> -0400)
>>
>> are available in the Git repository at:
>>
>>   https://gitlab.denx.de/u-boot/custodians/u-boot-imx.git
>> tags/u-boot-imx-20210720
>>
>> for you to fetch changes up to bd8e26606db62a0434c7f09adfa6ec666b36985b:
>>
>>   imx: imx8mm: Add support for Kontron Electronics SL/BL i.MX8M-Mini boards
>> (N801x) (2021-07-19 23:30:47 +0200)
>>
> 
> NAK:
> 
> ERROR: fdt or initrd relocation disabled at boot time
> #2019: FILE: include/configs/kontron_common.h:67:
> +       "fdt_high=0xffffffff\0" \
> 
> And this is likely a bad idea too:
> ERROR: fdt or initrd relocation disabled at boot time
> #2020: FILE: include/configs/kontron_common.h:68:
> +       "initrd_high=0xffffffff\0" \
> 
> but I haven't looked at all of include/configs/kontron_common.h to make
> sure it follows all of the layout stuff documented for example in:
> https://source.denx.de/u-boot/u-boot/-/blob/master/include/configs/ti_armv7_common.h#L32
> (which is also true for aarch64 best I can tell from
> https://www.kernel.org/doc/Documentation/arm64/booting.rst).
> 
> And since I'm noting things, checkpatch has a whole bunch of formatting
> issues throughout as well (kontron and generic imx8 code both).

Sorry for the mess! I have fixed these issues and just sent a v4 for the Kontron board support patches.

Best regards
Frieder
Stefano Babic July 21, 2021, 8:17 a.m. UTC | #3
On 21.07.21 10:07, Frieder Schrempf wrote:
> Hi Tom, Stefano,
> 
> On 20.07.21 19:45, Tom Rini wrote:
>> On Tue, Jul 20, 2021 at 05:17:59PM +0200, Stefano Babic wrote:
>>
>>> Hi Tom,
>>>
>>> please pull from u-boot-imx, thanks !
>>>
>>> The following changes since commit f929ce50727bf1019323d6c199dfd3a5755c5474:
>>>
>>>    Merge branch '2021-07-16-cleanup-image-support' (2021-07-17 11:39:50
>>> -0400)
>>>
>>> are available in the Git repository at:
>>>
>>>    https://gitlab.denx.de/u-boot/custodians/u-boot-imx.git
>>> tags/u-boot-imx-20210720
>>>
>>> for you to fetch changes up to bd8e26606db62a0434c7f09adfa6ec666b36985b:
>>>
>>>    imx: imx8mm: Add support for Kontron Electronics SL/BL i.MX8M-Mini boards
>>> (N801x) (2021-07-19 23:30:47 +0200)
>>>
>>
>> NAK:
>>
>> ERROR: fdt or initrd relocation disabled at boot time
>> #2019: FILE: include/configs/kontron_common.h:67:
>> +       "fdt_high=0xffffffff\0" \
>>
>> And this is likely a bad idea too:
>> ERROR: fdt or initrd relocation disabled at boot time
>> #2020: FILE: include/configs/kontron_common.h:68:
>> +       "initrd_high=0xffffffff\0" \
>>
>> but I haven't looked at all of include/configs/kontron_common.h to make
>> sure it follows all of the layout stuff documented for example in:
>> https://source.denx.de/u-boot/u-boot/-/blob/master/include/configs/ti_armv7_common.h#L32
>> (which is also true for aarch64 best I can tell from
>> https://www.kernel.org/doc/Documentation/arm64/booting.rst).
>>
>> And since I'm noting things, checkpatch has a whole bunch of formatting
>> issues throughout as well (kontron and generic imx8 code both).
> 
> Sorry for the mess! I have fixed these issues and just sent a v4 for the Kontron board support patches.

Thanks ! I have reverted (dropped) patches from u-boot-imx, we start again.

Best regards,
Stefano
Peng Fan July 21, 2021, 10:23 a.m. UTC | #4
Sorry for non-text top posting.

The imx8ulp patch set has pin headers that would have lots warning, but we have agreement in Linux kernel that they are acceptable. Or you need we fix the line 100 warning?

Are there others blocking the patch set?

Thanks,
Peng

获取 Outlook for iOS<https://aka.ms/o0ukef>
Tom Rini July 21, 2021, 1:26 p.m. UTC | #5
On Wed, Jul 21, 2021 at 10:23:12AM +0000, Peng Fan wrote:

> Sorry for non-text top posting.
> 
> The imx8ulp patch set has pin headers that would have lots warning, but we have agreement in Linux kernel that they are acceptable. Or you need we fix the line 100 warning?
> 
> Are there others blocking the patch set?

I saw at least a few "spaces before tabs" and similar errors.  The best
answer I can give here is to run checkpatch.pl in the tree and make sure
there's nothing that's not just pin headers/long lines.  But I do think
I saw some about general coding style too.