From patchwork Tue Aug 25 09:53:40 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernhard Nortmann X-Patchwork-Id: 510428 X-Patchwork-Delegate: joe.hershberger@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id E7D9B140082 for ; Tue, 25 Aug 2015 19:53:56 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 571824B672; Tue, 25 Aug 2015 11:53:51 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6Y6OBQmCvmIR; Tue, 25 Aug 2015 11:53:51 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id CC4204B664; Tue, 25 Aug 2015 11:53:50 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 47B1C4B664 for ; Tue, 25 Aug 2015 11:53:48 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id J82CVnGfR6yV for ; Tue, 25 Aug 2015 11:53:48 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mout.web.de (mout.web.de [212.227.15.4]) by theia.denx.de (Postfix) with ESMTPS id 14E4C4B663 for ; Tue, 25 Aug 2015 11:53:45 +0200 (CEST) Received: from [172.16.0.1] ([217.225.7.251]) by smtp.web.de (mrweb004) with ESMTPSA (Nemesis) id 0M1UUr-1YbeQc2fHN-00tTfR; Tue, 25 Aug 2015 11:53:39 +0200 To: Joe Hershberger , Simon Glass References: <1440196247-6885-1-git-send-email-bernhard.nortmann@web.de> <1440196247-6885-2-git-send-email-bernhard.nortmann@web.de> <55DAEFDE.5040809@web.de> From: Bernhard Nortmann Message-ID: <55DC3B24.7010508@web.de> Date: Tue, 25 Aug 2015 11:53:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: X-Provags-ID: V03:K0:+aVsAJ9uU2bEDMpSEDp9RNF36Ic2K/rDLvq+7WDO/y8dv/RZydy hY5pSP/4MIckgrPXVpzmtAGUxhrcDnS+WzSWGpXeB203ghyx2VyfzUqyCTZmCfUBVUAbhxX 9Ed8SfqsUVYryUdM0yJDHqieHuvWw87MijzLwYv7hqVgh3QNQ8Dpt1FrhnujUaVwfiGTyfK KTDURpQSFRQldWCxKD4kw== X-UI-Out-Filterresults: notjunk:1; V01:K0:wkMusDH6e7Q=:eZY4V3WcFNQFbWodccokqa JhxlbErIQmLVz2nkC5HiZUqISrQr5typtoLC7d1f0T120wh0OAiyyoAVe82hN41YQaj+jwXET Pk/uaAihP//mzI0zX/Uy2tur5uf9XE9zNKcTrP6/KoGxWRNZ1tbBbi/9IiKQKM4jMJ4Ytp72C qqtQudnVKbWh0AnJuP1jrRLsGO44loW3uTWsSId8gkwMd4ufNGfT0VwtLvJ3UPElF9Bgy+/gP 8voFjxGdw2bbImzyGbP4VozyS0PxuOE6cdLdQwKCHolnlRi+A6HWauaOcM5qs7FBmOP7zqBCF CkY5NicunKgE9fXA3RHYc+HbXfCkEyUWB1tWxzaIx1ggclLmjgJw2tNnBnAe25TRrN6XAdh8m 3clxsRPqOJSh09B005H1l9l1S50O7aVAUw0bTR4mPIDiC1JhUMttGAXOtk0t87vlmS5bXHR/u /NxgPw8YV3NXiWHVBmNuJIUg2FV5rcYfpoDHUQJZ1Jgx0aKi1BmdCTjtJM29+QS8+WaleFxrt CN1T/s2QhnLS/iRXCxBt2WntQpo7rE2jIAembH/Y6h86sqYbJb0cwjNB/Bc4vPE+TVhcE/TSp OW/hQ//6w9tQ5vjPwyx2DeibuvllX6hEbtvMPGcQaZCaqbDx3I30LI6MobDTB46EvrJ7WL1a9 uIvKx4HsE2DI+5rET/5D7ewTnKhuGWM7PWbh3ANyKDBlyThD8vcTQYxOfETL2yF8mIGJKaHYA vVrZOMg/jCZwyNx0k+RCNlJNQAg0v64+1dtPWA== Cc: Joe Hershberger , Tom Rini , Radha Mohan Chintakuntla , U-Boot Mailing List Subject: Re: [U-Boot] [RFC PATCH 1/3] expose eth_is_active() function to test network device state X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Am 24.08.2015 um 19:02 schrieb Joe Hershberger: > Hi Simon, > > On Mon, Aug 24, 2015 at 11:59 AM, Simon Glass wrote: >> Hi Bernhard, >> >> [...] >> i.e. sunxi GMAC (by simply adding #define CONFIG_NETCONSOLE). >> In that case how about adding that config to that board? Does it cause >> problems for other people? > I'll pile on and agree that it would be great to have at least one > board with this enabled, and even better to have one that supports > DM_ETH and one that does not. > > -Joe grep "#define CONFIG_NETCONSOLE" include/configs/* lists a considerable number of boards where NETCONSOLE seems to be active by default. I guess none of these has moved to DM_ETH yet, or I'd have expected reports of "broken" builds. If you're all for it, I can of course enable NETCONSOLE for the Banana Pi/Pro. (It may even be done across-the-board for all SUNXI_[EG]MAC configs?) Personally, I'm a bit reluctant to "enforce" this setting, because until now my understanding was that NETCONSOLE is supposed to be mostly optional, i.e. at user's choice - especially for boards where other means of input/output are readily available (serial console, vga, usb keyboard). I don't expect this to create problems, it just adds code that probably won't be used most of the time (as long as "nc" doesn't get used for stdin/stdout). I guess the proper way to do it would be to introduce Kconfig support; will this do? In case this gets a "go", I'd prepare a v2 patch set that includes enabling CONFIG_NETCONSOLE via Bananapi_defconfig / Bananapro_defconfig. Regards, B. Nortmann diff --git a/net/Kconfig b/net/Kconfig index 915371d..87c1729 100644 --- a/net/Kconfig +++ b/net/Kconfig @@ -16,4 +16,10 @@ config NET_RANDOM_ETHADDR A new MAC address will be generated on every boot and it will not be added to the environment. +config NETCONSOLE + bool "Netconsole support" + help + Support the 'nc' input/output device for networked console. + See README.NetConsole for details. + endif # if NET