From patchwork Wed Jan 29 08:04:17 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Minkyu Kang X-Patchwork-Id: 314927 X-Patchwork-Delegate: promsoft@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 1CD902C00AD for ; Wed, 29 Jan 2014 19:04:43 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id D64A94B3D6; Wed, 29 Jan 2014 09:04:41 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XuJ0D62espQq; Wed, 29 Jan 2014 09:04:41 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 0C8634B3DF; Wed, 29 Jan 2014 09:04:39 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 659644B3BA for ; Wed, 29 Jan 2014 09:04:33 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xhVm80equzYC for ; Wed, 29 Jan 2014 09:04:28 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by theia.denx.de (Postfix) with ESMTPS id D2B464B3D6 for ; Wed, 29 Jan 2014 09:04:25 +0100 (CET) Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N0500FE8L33QJ00@mailout4.samsung.com> for u-boot@lists.denx.de; Wed, 29 Jan 2014 17:04:15 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [172.20.52.113]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id 92.8B.14803.EF5B8E25; Wed, 29 Jan 2014 17:04:14 +0900 (KST) X-AuditID: cbfee691-b7efc6d0000039d3-bf-52e8b5fe4fbd Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 6D.B9.29263.DF5B8E25; Wed, 29 Jan 2014 17:04:13 +0900 (KST) Received: from [10.89.71.75] by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N0500AWPL31NK00@mmp2.samsung.com>; Wed, 29 Jan 2014 17:04:13 +0900 (KST) Message-id: <52E8B601.8070502@samsung.com> Date: Wed, 29 Jan 2014 17:04:17 +0900 From: Minkyu Kang Organization: SAMSUNG ELECTRONICS User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-version: 1.0 To: "u-boot@lists.denx.de" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprAIsWRmVeSWpSXmKPExsWyRsSkUPff1hdBBidb2C3WPVnLatGy9gCr xdu9newOzB5n7+xg9OjbsooxgCmKyyYlNSezLLVI3y6BK+Pw4y2sBU/ZK05d2c/awLiXrYuR k0NCwETiff87KFtM4sK99UA2F4eQwFJGidtb7zDDFK193sUIkZjOKNF7/w0ThPMSyLn2FaiK g4NXQEvi3AUjkAYWAVWJnxuusoDYbAIaEk+nbWcEsfkFFCVmtL4A2yYqECaxqaeZCcTmFRCU +DH5Hli9iIChxN/du8FsZoFIiXVP94LVCAvYS6x+NYcdIq4jsb91GhuELS+xec1bZpB7JAT6 2SXmbrvABnGEgMS3yYdYQG6TEJCV2HQA6hlJiYMrbrBMYBSdhWT1LCRjZyEZu4CReRWjaGpB ckFxUnqRqV5xYm5xaV66XnJ+7iZGYGyc/vds4g7G+wesDzEmA62cyCwlmpwPjK28knhDYzMj C1MTU2Mjc0sz0oSVxHnTHyUFCQmkJ5akZqemFqQWxReV5qQWH2Jk4uCUamBUFLVednrnko0h /CEP13/mfLdq6/Pny8/ZsG4tt7l8K1Z45g/LRzPetb50943SddkldqI0aSOrrGB1Vk/nKy+b bf0dJuZ7N70S1ZdP7PUoE7wi9tvVof+2Tc7Vr/6Tqrf+KP3C/37Rpb2VevZzfzvf1nbQmNPE 69uhVrh4zdd9TRdt8wxU2POVWIozEg21mIuKEwEC/8+BowIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLIsWRmVeSWpSXmKPExsVy+t9jQd2/W18EGRz+amOx7slaVouWtQdY Ld7u7WR3YPY4e2cHo0ffllWMAUxRDYw2GamJKalFCql5yfkpmXnptkrewfHO8aZmBoa6hpYW 5koKeYm5qbZKLj4Bum6ZOUBblBTKEnNKgUIBicXFSvp2mCaEhrjpWsA0Ruj6hgTB9RgZoIGE NYwZhx9vYS14yl5x6sp+1gbGvWxdjJwcEgImEmufdzFC2GISF+6tB4pzcQgJTGeU6L3/hgnC eQnkXPvK3MXIwcEroCVx7oIRSAOLgKrEzw1XWUBsNgENiafTtoMN4hdQlJjR+gJsgahAmMSm nmYmEJtXQFDix+R7YPUiAoYSf3fvBrOZBSIl1j3dC1YjLGAvsfrVHHaIuI7E/tZpbBC2vMTm NW+ZJzDyz0IyahaSsllIyhYwMq9iFE0tSC4oTkrPNdQrTswtLs1L10vOz93ECI68Z1I7GFc2 WBxiFOBgVOLhXXHxeZAQa2JZcWXuIUYJDmYlEd4Tm14ECfGmJFZWpRblxxeV5qQWH2JMBvp6 IrOUaHI+MCnklcQbGpuYGVkamRtaGBmbkyasJM57oNU6UEggPbEkNTs1tSC1CGYLEwenVAOj XGDawrUTLs+R37bT4Kfj7Gk8pt/Ti2dGxXfpMsitcl/wqOKUYIn/g+/eW+12qnHdfXPfY4bk yuUreDxuqBzM3t/WEhzivU44KuC81drwpHs/G3jqP3rMeaKQtGM1MxNnh37kF8mHzvbz7x08 Pbedt3JLTV3t7tvMc1Jc16Qzn+veYlshE1WgxFKckWioxVxUnAgAYCQyOgADAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: Piotr Wilczek , Rajeshwari Shinde Subject: [U-Boot] [PATCH 3/3] exynos: pinmux: remove unnecessary routine X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de Because of the list of peripherals is not sequential, such a routine does not check for valid correctly. Error check will be done when call the exynos_pinmux_config function. Signed-off-by: Minkyu Kang Acked-by: Jaehoon Chung Acked-by: Rajeshwari Shinde --- arch/arm/cpu/armv7/exynos/pinmux.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/arch/arm/cpu/armv7/exynos/pinmux.c b/arch/arm/cpu/armv7/exynos/pinmux.c index 904177a..645c497 100644 --- a/arch/arm/cpu/armv7/exynos/pinmux.c +++ b/arch/arm/cpu/armv7/exynos/pinmux.c @@ -751,12 +751,7 @@ static int exynos5_pinmux_decode_periph_id(const void *blob, int node) if (err) return PERIPH_ID_NONE; - /* check for invalid peripheral id */ - if ((PERIPH_ID_SDMMC4 > cell[1]) || (cell[1] < PERIPH_ID_UART0)) - return cell[1]; - - debug(" invalid peripheral id\n"); - return PERIPH_ID_NONE; + return cell[1]; } int pinmux_decode_periph_id(const void *blob, int node)