diff mbox

[U-Boot] net: gem: Enable CTRL+C in wait_for_bit

Message ID 523cef3095ca22485117f079837886ca36633a3b.1448531207.git.michal.simek@xilinx.com
State Superseded
Delegated to: Michal Simek
Headers show

Commit Message

Michal Simek Nov. 26, 2015, 9:46 a.m. UTC 
Enable to break waiting loop at any time.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 drivers/net/zynq_gem.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Joe Hershberger Nov. 30, 2015, 8:36 p.m. UTC | #1 
Hi Michal,

On Thu, Nov 26, 2015 at 3:46 AM, Michal Simek <michal.simek@xilinx.com> wrote:
> Enable to break waiting loop at any time.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
>  drivers/net/zynq_gem.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c
> index 858093f0d7e2..ee4169107e5b 100644
> --- a/drivers/net/zynq_gem.c
> +++ b/drivers/net/zynq_gem.c
> @@ -447,6 +447,11 @@ static int wait_for_bit(const char *func, u32 *reg, const u32 mask,
>                 if (get_timer(start) > timeout)
>                         break;
>
> +               if (ctrlc()) {
> +                       puts("Abort\n");
> +                       return -1;

Maybe this should return -EINTR?

> +               }
> +
>                 udelay(1);
>         }
>
> --
> 1.9.1
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
Michal Simek Dec. 1, 2015, 10:35 a.m. UTC | #2 
On 30.11.2015 21:36, Joe Hershberger wrote:
> Hi Michal,
> 
> On Thu, Nov 26, 2015 at 3:46 AM, Michal Simek <michal.simek@xilinx.com> wrote:
>> Enable to break waiting loop at any time.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>>  drivers/net/zynq_gem.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c
>> index 858093f0d7e2..ee4169107e5b 100644
>> --- a/drivers/net/zynq_gem.c
>> +++ b/drivers/net/zynq_gem.c
>> @@ -447,6 +447,11 @@ static int wait_for_bit(const char *func, u32 *reg, const u32 mask,
>>                 if (get_timer(start) > timeout)
>>                         break;
>>
>> +               if (ctrlc()) {
>> +                       puts("Abort\n");
>> +                       return -1;
> 
> Maybe this should return -EINTR?

No problem with this.

Thanks,
Michal
diff mbox

Patch

diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c
index 858093f0d7e2..ee4169107e5b 100644
--- a/drivers/net/zynq_gem.c
+++ b/drivers/net/zynq_gem.c
@@ -447,6 +447,11 @@  static int wait_for_bit(const char *func, u32 *reg, const u32 mask,
 		if (get_timer(start) > timeout)
 			break;
 
+		if (ctrlc()) {
+			puts("Abort\n");
+			return -1;
+		}
+
 		udelay(1);
 	}