Message ID | 4FF18398.8070200@samsung.com |
---|---|
State | Changes Requested |
Delegated to: | Minkyu Kang |
Headers | show |
On 2 July 2012 20:18, Donghwa Lee <dh09.lee@samsung.com> wrote: > To avoid compilers error in case of not using > CONFIG_EXYNOS_MIPI_DSIM, add no operation function. > > Signed-off-by: Donghwa Lee <dh09.lee@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > --- > arch/arm/include/asm/arch-exynos/mipi_dsim.h | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/include/asm/arch-exynos/mipi_dsim.h b/arch/arm/include/asm/arch-exynos/mipi_dsim.h > index 9a7cbeb..b73263d 100644 > --- a/arch/arm/include/asm/arch-exynos/mipi_dsim.h > +++ b/arch/arm/include/asm/arch-exynos/mipi_dsim.h > @@ -358,7 +358,14 @@ struct mipi_dsim_lcd_driver { > void (*mipi_display_on)(struct mipi_dsim_device *dsim_dev); > }; > > +#ifdef CONFIG_EXYNOS_MIPI_DSIM > int exynos_mipi_dsi_init(void); > +#else > +int exynos_mipi_dsi_init(void) > +{ > + return 0; > +} > +#endif How about weak function instead of ifdef? Thanks. Minkyu Kang.
On 4 July 2012 12:29, Minkyu Kang wrote: > On 2 July 2012 20:18, Donghwa Lee <dh09.lee@samsung.com> wrote: >> To avoid compilers error in case of not using >> CONFIG_EXYNOS_MIPI_DSIM, add no operation function. >> >> Signed-off-by: Donghwa Lee <dh09.lee@samsung.com> >> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> >> --- >> arch/arm/include/asm/arch-exynos/mipi_dsim.h | 7 +++++++ >> 1 files changed, 7 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/include/asm/arch-exynos/mipi_dsim.h b/arch/arm/include/asm/arch-exynos/mipi_dsim.h >> index 9a7cbeb..b73263d 100644 >> --- a/arch/arm/include/asm/arch-exynos/mipi_dsim.h >> +++ b/arch/arm/include/asm/arch-exynos/mipi_dsim.h >> @@ -358,7 +358,14 @@ struct mipi_dsim_lcd_driver { >> void (*mipi_display_on)(struct mipi_dsim_device *dsim_dev); >> }; >> >> +#ifdef CONFIG_EXYNOS_MIPI_DSIM >> int exynos_mipi_dsi_init(void); >> +#else >> +int exynos_mipi_dsi_init(void) >> +{ >> + return 0; >> +} >> +#endif > > How about weak function instead of ifdef? > > Thanks. > Minkyu Kang. Ok, It looks like better. I will fix it later. Thank you, Donghwa Lee.
diff --git a/arch/arm/include/asm/arch-exynos/mipi_dsim.h b/arch/arm/include/asm/arch-exynos/mipi_dsim.h index 9a7cbeb..b73263d 100644 --- a/arch/arm/include/asm/arch-exynos/mipi_dsim.h +++ b/arch/arm/include/asm/arch-exynos/mipi_dsim.h @@ -358,7 +358,14 @@ struct mipi_dsim_lcd_driver { void (*mipi_display_on)(struct mipi_dsim_device *dsim_dev); }; +#ifdef CONFIG_EXYNOS_MIPI_DSIM int exynos_mipi_dsi_init(void); +#else +int exynos_mipi_dsi_init(void) +{ + return 0; +} +#endif /* * register mipi_dsim_lcd_driver object defined by lcd panel driver