| Message ID | 42760d2bf82367583908cca56580da882a2a4354.1429098181.git.michal.simek@xilinx.com |
|---|---|
| State | Deferred |
| Delegated to: | Łukasz Majewski |
| Headers | show |
On Wednesday, April 15, 2015 at 01:43:03 PM, Michal Simek wrote: > From: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com> > > Dont perform reset at the end of thor download > if configured to do reset off. > Reset may not be required in all cases and hence > provided an option to do so. Hi, You fail to explain in which cases this option is needed. You also fail to document this option in README file. Please fix. Best regards, Marek Vasut
Hi Marek, > -----Original Message----- > From: Marek Vasut [mailto:marex@denx.de] > Sent: Wednesday, April 15, 2015 5:17 PM > To: Michal Simek > Cc: Lukasz Majewski; u-boot@lists.denx.de; Siva Durga Prasad Paladugu; Tom > Rini > Subject: Re: [RESEND PATCH] f_thor: Dont perform reset at the end of thor > > On Wednesday, April 15, 2015 at 01:43:03 PM, Michal Simek wrote: > > From: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com> > > > > Dont perform reset at the end of thor download if configured to do > > reset off. > > Reset may not be required in all cases and hence provided an option to > > do so. > > Hi, > > You fail to explain in which cases this option is needed. > You also fail to document this option in README file. The case here would be to download the images just to DDR instead of to any flash device. Regards, Siva > > Please fix. > > Best regards, > Marek Vasut This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.
On Wednesday, April 15, 2015 at 02:03:50 PM, Siva Durga Prasad Paladugu wrote: > Hi Marek, Hi! > > -----Original Message----- > > From: Marek Vasut [mailto:marex@denx.de] > > Sent: Wednesday, April 15, 2015 5:17 PM > > To: Michal Simek > > Cc: Lukasz Majewski; u-boot@lists.denx.de; Siva Durga Prasad Paladugu; > > Tom Rini > > Subject: Re: [RESEND PATCH] f_thor: Dont perform reset at the end of thor > > > > On Wednesday, April 15, 2015 at 01:43:03 PM, Michal Simek wrote: > > > From: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com> > > > > > > Dont perform reset at the end of thor download if configured to do > > > reset off. > > > Reset may not be required in all cases and hence provided an option to > > > do so. > > > > Hi, > > > > You fail to explain in which cases this option is needed. > > You also fail to document this option in README file. > > The case here would be to download the images just to DDR instead of to any > flash device. That should certainly be in the commit message :) > This email and any attachments are intended for the sole use of the named > recipient(s) and contain(s) confidential information that may be > proprietary, privileged or copyrighted under applicable law. If you are > not the intended recipient, do not read, copy, or forward this email > message or any attachments. Delete this email message and any attachments > immediately. Oh my $DEITY, now the entire mailing list received this possibly proprietary email. What do we do ?! ... Best regards, Marek Vasut
On 04/15/2015 02:35 PM, Marek Vasut wrote: > On Wednesday, April 15, 2015 at 02:03:50 PM, Siva Durga Prasad Paladugu wrote: >> Hi Marek, > > Hi! > >>> -----Original Message----- >>> From: Marek Vasut [mailto:marex@denx.de] >>> Sent: Wednesday, April 15, 2015 5:17 PM >>> To: Michal Simek >>> Cc: Lukasz Majewski; u-boot@lists.denx.de; Siva Durga Prasad Paladugu; >>> Tom Rini >>> Subject: Re: [RESEND PATCH] f_thor: Dont perform reset at the end of thor >>> >>> On Wednesday, April 15, 2015 at 01:43:03 PM, Michal Simek wrote: >>>> From: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com> >>>> >>>> Dont perform reset at the end of thor download if configured to do >>>> reset off. >>>> Reset may not be required in all cases and hence provided an option to >>>> do so. >>> >>> Hi, >>> >>> You fail to explain in which cases this option is needed. >>> You also fail to document this option in README file. >> >> The case here would be to download the images just to DDR instead of to any >> flash device. > > That should certainly be in the commit message :) > >> This email and any attachments are intended for the sole use of the named >> recipient(s) and contain(s) confidential information that may be >> proprietary, privileged or copyrighted under applicable law. If you are >> not the intended recipient, do not read, copy, or forward this email >> message or any attachments. Delete this email message and any attachments >> immediately. > > Oh my $DEITY, now the entire mailing list received this possibly proprietary > email. What do we do ?! ... Just ignore it. I will update the commit message and will resend this patch as v2 but I will wait if someone else has any objection with it. Thanks, Michal
diff --git a/drivers/usb/gadget/f_thor.c b/drivers/usb/gadget/f_thor.c index e9a690eff5f1..5c8f6768519c 100644 --- a/drivers/usb/gadget/f_thor.c +++ b/drivers/usb/gadget/f_thor.c @@ -123,6 +123,9 @@ static int process_rqt_cmd(const struct rqt_box *rqt) send_rsp(rsp); g_dnl_unregister(); dfu_free_entities(); +#ifdef CONFIG_THOR_RESET_OFF + return RESET_DONE; +#endif run_command("reset", 0); break; case RQT_CMD_POWEROFF: @@ -728,6 +731,10 @@ int thor_handle(void) if (ret > 0) { ret = process_data(); +#ifdef CONFIG_THOR_RESET_OFF + if (ret == RESET_DONE) + break; +#endif if (ret < 0) return ret; } else { diff --git a/drivers/usb/gadget/f_thor.h b/drivers/usb/gadget/f_thor.h index 833a9d24ae7e..83412851dd17 100644 --- a/drivers/usb/gadget/f_thor.h +++ b/drivers/usb/gadget/f_thor.h @@ -121,4 +121,7 @@ struct f_thor { #define F_NAME_BUF_SIZE 32 #define THOR_PACKET_SIZE SZ_1M /* 1 MiB */ #define THOR_STORE_UNIT_SIZE SZ_32M /* 32 MiB */ +#ifdef CONFIG_THOR_RESET_OFF +#define RESET_DONE 0xFFFFFFFF +#endif #endif /* _USB_THOR_H_ */