| Message ID | 35b1d35839a0e87cf54aeafb9d9eaada349f306a.1450108392.git.michal.simek@xilinx.com |
|---|---|
| State | Superseded |
| Headers | show |
On 14 December 2015 at 08:53, Michal Simek <michal.simek@xilinx.com> wrote: > Reported-by: Thomas Chou <thomas@wytron.com.tw> > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > drivers/serial/serial_xuartlite.c | 2 +- > drivers/serial/serial_zynq.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org>
Hi Michal, On Mon, Dec 14, 2015 at 11:53 PM, Michal Simek <michal.simek@xilinx.com> wrote: > Reported-by: Thomas Chou <thomas@wytron.com.tw> > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- Could you always include a simple sentence in the commit message? > > drivers/serial/serial_xuartlite.c | 2 +- > drivers/serial/serial_zynq.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/serial/serial_xuartlite.c b/drivers/serial/serial_xuartlite.c > index fe87b515d902..0238a52380c7 100644 > --- a/drivers/serial/serial_xuartlite.c > +++ b/drivers/serial/serial_xuartlite.c > @@ -122,7 +122,7 @@ U_BOOT_DRIVER(serial_uartlite) = { > }; > > #ifdef CONFIG_DEBUG_UART_UARTLITE > -void _debug_uart_init(void) > +static inline void _debug_uart_init(void) > { > struct uartlite *regs = (struct uartlite *)CONFIG_DEBUG_UART_BASE; > > diff --git a/drivers/serial/serial_zynq.c b/drivers/serial/serial_zynq.c > index b2b98dea1561..3430482f8d8b 100644 > --- a/drivers/serial/serial_zynq.c > +++ b/drivers/serial/serial_zynq.c > @@ -192,7 +192,7 @@ U_BOOT_DRIVER(serial_zynq) = { > }; > > #ifdef CONFIG_DEBUG_UART_ZYNQ > -void _debug_uart_init(void) > +static inline void _debug_uart_init(void) > { > struct uart_zynq *regs = (struct uart_zynq *)CONFIG_DEBUG_UART_BASE; > > -- Other than that, Reviewed-by: Bin Meng <bmeng.cn@gmail.com> Regards, Bin
Hi Michal, On 2015年12月14日 23:53, Michal Simek wrote: > Reported-by: Thomas Chou <thomas@wytron.com.tw> > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > drivers/serial/serial_xuartlite.c | 2 +- > drivers/serial/serial_zynq.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/serial/serial_xuartlite.c b/drivers/serial/serial_xuartlite.c > index fe87b515d902..0238a52380c7 100644 > --- a/drivers/serial/serial_xuartlite.c > +++ b/drivers/serial/serial_xuartlite.c > @@ -122,7 +122,7 @@ U_BOOT_DRIVER(serial_uartlite) = { > }; > > #ifdef CONFIG_DEBUG_UART_UARTLITE > -void _debug_uart_init(void) > +static inline void _debug_uart_init(void) > { > struct uartlite *regs = (struct uartlite *)CONFIG_DEBUG_UART_BASE; > > diff --git a/drivers/serial/serial_zynq.c b/drivers/serial/serial_zynq.c > index b2b98dea1561..3430482f8d8b 100644 > --- a/drivers/serial/serial_zynq.c > +++ b/drivers/serial/serial_zynq.c > @@ -192,7 +192,7 @@ U_BOOT_DRIVER(serial_zynq) = { > }; > > #ifdef CONFIG_DEBUG_UART_ZYNQ > -void _debug_uart_init(void) > +static inline void _debug_uart_init(void) > { > struct uart_zynq *regs = (struct uart_zynq *)CONFIG_DEBUG_UART_BASE; > > Reviewed-by: Thomas Chou <thomas@wytron.com.tw> Thanks, Thomas
On 15.12.2015 05:20, Bin Meng wrote: > Hi Michal, > > On Mon, Dec 14, 2015 at 11:53 PM, Michal Simek <michal.simek@xilinx.com> wrote: >> Reported-by: Thomas Chou <thomas@wytron.com.tw> >> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >> --- > > Could you always include a simple sentence in the commit message? done in v2. Thanks, Michal
diff --git a/drivers/serial/serial_xuartlite.c b/drivers/serial/serial_xuartlite.c index fe87b515d902..0238a52380c7 100644 --- a/drivers/serial/serial_xuartlite.c +++ b/drivers/serial/serial_xuartlite.c @@ -122,7 +122,7 @@ U_BOOT_DRIVER(serial_uartlite) = { }; #ifdef CONFIG_DEBUG_UART_UARTLITE -void _debug_uart_init(void) +static inline void _debug_uart_init(void) { struct uartlite *regs = (struct uartlite *)CONFIG_DEBUG_UART_BASE; diff --git a/drivers/serial/serial_zynq.c b/drivers/serial/serial_zynq.c index b2b98dea1561..3430482f8d8b 100644 --- a/drivers/serial/serial_zynq.c +++ b/drivers/serial/serial_zynq.c @@ -192,7 +192,7 @@ U_BOOT_DRIVER(serial_zynq) = { }; #ifdef CONFIG_DEBUG_UART_ZYNQ -void _debug_uart_init(void) +static inline void _debug_uart_init(void) { struct uart_zynq *regs = (struct uart_zynq *)CONFIG_DEBUG_UART_BASE;
Reported-by: Thomas Chou <thomas@wytron.com.tw> Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- drivers/serial/serial_xuartlite.c | 2 +- drivers/serial/serial_zynq.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)