diff mbox series

[U-Boot] Makefile: drop unused cpp_cfg macro

Message ID 2a25b59ddd749c4d4d884e4fbd680c148af86ffe.1529297965.git.baruch@tkos.co.il
State Accepted
Commit bf5dd78cd4b26e8e9186311da14793110b9c3278
Delegated to: Tom Rini
Headers show
Series [U-Boot] Makefile: drop unused cpp_cfg macro | expand

Commit Message

Baruch Siach June 18, 2018, 4:59 a.m. UTC
Commit e19b0fb4851f (kbuild: generate u-boot.cfg as a byproduct of
include/autoconf.mk) removed the use of the cpp_cfg macro in Makefile,
but forgot to remove its definition.

Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 Makefile | 5 -----
 1 file changed, 5 deletions(-)

Comments

Masahiro Yamada June 19, 2018, 2:01 a.m. UTC | #1
2018-06-18 13:59 GMT+09:00 Baruch Siach <baruch@tkos.co.il>:
> Commit e19b0fb4851f (kbuild: generate u-boot.cfg as a byproduct of
> include/autoconf.mk) removed the use of the cpp_cfg macro in Makefile,
> but forgot to remove its definition.
>
> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---

Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>


>  Makefile | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 61ef84576afa..cbee84249b06 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1052,11 +1052,6 @@ ifndef CONFIG_SYS_UBOOT_START
>  CONFIG_SYS_UBOOT_START := 0
>  endif
>
> -# Create a file containing the configuration options the image was built with
> -quiet_cmd_cpp_cfg = CFG     $@
> -cmd_cpp_cfg = $(CPP) -Wp,-MD,$(depfile) $(cpp_flags) $(LDPPFLAGS) -ansi \
> -       -DDO_DEPS_ONLY -D__ASSEMBLY__ -x assembler-with-cpp -P -dM -E -o $@ $<
> -
>  # Boards with more complex image requirments can provide an .its source file
>  # or a generator script
>  ifneq ($(CONFIG_SPL_FIT_SOURCE),"")
> --
> 2.17.1
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
Tom Rini July 11, 2018, 12:42 p.m. UTC | #2
On Mon, Jun 18, 2018 at 07:59:25AM +0300, Baruch Siach wrote:

> Commit e19b0fb4851f (kbuild: generate u-boot.cfg as a byproduct of
> include/autoconf.mk) removed the use of the cpp_cfg macro in Makefile,
> but forgot to remove its definition.
> 
> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/Makefile b/Makefile
index 61ef84576afa..cbee84249b06 100644
--- a/Makefile
+++ b/Makefile
@@ -1052,11 +1052,6 @@  ifndef CONFIG_SYS_UBOOT_START
 CONFIG_SYS_UBOOT_START := 0
 endif
 
-# Create a file containing the configuration options the image was built with
-quiet_cmd_cpp_cfg = CFG     $@
-cmd_cpp_cfg = $(CPP) -Wp,-MD,$(depfile) $(cpp_flags) $(LDPPFLAGS) -ansi \
-	-DDO_DEPS_ONLY -D__ASSEMBLY__ -x assembler-with-cpp -P -dM -E -o $@ $<
-
 # Boards with more complex image requirments can provide an .its source file
 # or a generator script
 ifneq ($(CONFIG_SPL_FIT_SOURCE),"")