| Message ID | 2417b7bc-0dad-64ce-c4a9-ed4d9851df44@baylibre.com |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [PULL,u-boot] Please pull u-boot-amlogic-20210222 | expand |
On Mon, Feb 22, 2021 at 03:30:36PM +0100, Neil Armstrong wrote: > Hi Tom, > > These changes adds support for reading the ADC key on the Khadas VIM3 & VIM3L, in the same > time it adds plumbing for ADC keys and a test for sandbox. > > The CI job is at https://gitlab.denx.de/u-boot/custodians/u-boot-amlogic/pipelines/6461 > > Thanks, > Neil > > The following changes since commit 496f49464d90b564da5f1a2f4eecb5553e01edf9: > > Merge branch '2021-02-16-assorted-improvements' (2021-02-16 15:14:34 -0500) > > are available in the Git repository at: > > https://gitlab.denx.de/u-boot/custodians/u-boot-amlogic.git tags/u-boot-amlogic-20210222 > > for you to fetch changes up to 2d339efb1ff941705a770e93494427912689ce18: > > button: add udevice forward declaration (2021-02-22 11:07:57 +0100) > First up, I've applied this to u-boot/master, as there's some small problems, but I don't want to make you recreate the tag. That said, running ./scripts/checkpatch.pl -q --git on this shows that the ADC changes all add "treshold" fields, etc, and not "threshold" fields. A follow-up to fix this, before the misspelling propagates more would be appreciated. Thanks!
On 22/02/2021 21:03, Tom Rini wrote: > On Mon, Feb 22, 2021 at 03:30:36PM +0100, Neil Armstrong wrote: > >> Hi Tom, >> >> These changes adds support for reading the ADC key on the Khadas VIM3 & VIM3L, in the same >> time it adds plumbing for ADC keys and a test for sandbox. >> >> The CI job is at https://gitlab.denx.de/u-boot/custodians/u-boot-amlogic/pipelines/6461 >> >> Thanks, >> Neil >> >> The following changes since commit 496f49464d90b564da5f1a2f4eecb5553e01edf9: >> >> Merge branch '2021-02-16-assorted-improvements' (2021-02-16 15:14:34 -0500) >> >> are available in the Git repository at: >> >> https://gitlab.denx.de/u-boot/custodians/u-boot-amlogic.git tags/u-boot-amlogic-20210222 >> >> for you to fetch changes up to 2d339efb1ff941705a770e93494427912689ce18: >> >> button: add udevice forward declaration (2021-02-22 11:07:57 +0100) >> > > First up, I've applied this to u-boot/master, as there's some small > problems, but I don't want to make you recreate the tag. That said, > running ./scripts/checkpatch.pl -q --git on this shows that the ADC > changes all add "treshold" fields, etc, and not "threshold" fields. A > follow-up to fix this, before the misspelling propagates more would be > appreciated. Thanks! > Thanks for seeing this, I'll fixup ans resubmit ! Neil
Hi Tom, These changes adds support for reading the ADC key on the Khadas VIM3 & VIM3L, in the same time it adds plumbing for ADC keys and a test for sandbox. The CI job is at https://gitlab.denx.de/u-boot/custodians/u-boot-amlogic/pipelines/6461 Thanks, Neil The following changes since commit 496f49464d90b564da5f1a2f4eecb5553e01edf9: Merge branch '2021-02-16-assorted-improvements' (2021-02-16 15:14:34 -0500) are available in the Git repository at: https://gitlab.denx.de/u-boot/custodians/u-boot-amlogic.git tags/u-boot-amlogic-20210222 for you to fetch changes up to 2d339efb1ff941705a770e93494427912689ce18: button: add udevice forward declaration (2021-02-22 11:07:57 +0100) ---------------------------------------------------------------- - adds adc-keys button driver - fix meson-saradc driver to get reference voltage - add adc-keys test for sandbox - enable adc-keys for VIM3 & VIM3L boards - fix button.h build ---------------------------------------------------------------- Marek Szyprowski (5): dt-bindings: input: adc-keys bindings documentation button: add a simple Analog to Digital Converter device based button driver adc: meson-saradc: add support for getting reference voltage value configs: khadas-vim3(l): enable Function button support test: add a simple test for the adc-keys button driver Neil Armstrong (1): button: add udevice forward declaration arch/sandbox/dts/test.dts | 28 +++++- configs/khadas-vim3_defconfig | 2 + configs/khadas-vim3l_defconfig | 2 + configs/sandbox_defconfig | 1 + doc/device-tree-bindings/input/adc-keys.txt | 67 +++++++++++++ drivers/adc/meson-saradc.c | 21 ++++ drivers/button/Kconfig | 8 ++ drivers/button/Makefile | 1 + drivers/button/button-adc.c | 146 ++++++++++++++++++++++++++++ include/button.h | 2 + test/dm/button.c | 50 +++++++++- 11 files changed, 325 insertions(+), 3 deletions(-) create mode 100644 doc/device-tree-bindings/input/adc-keys.txt create mode 100644 drivers/button/button-adc.c