diff mbox

[U-Boot,v3,09/17] sf: Initialize bank_sel to zero for read ops

Message ID 23ea4d9c-f64b-4d52-8832-7b3d52d07505@CO9EHSMHS016.ehs.local
State Superseded
Delegated to: Jagannadha Sutradharudu Teki
Headers show

Commit Message

Jagannadha Sutradharudu Teki June 11, 2013, 7:23 p.m. UTC
Initialized bank_sel variable to 0 to support the updated read
ops for flashes which has < 16Mbytes.

Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
---
Changes for v3:
	- none
Changes for v2:
	- none

 drivers/mtd/spi/spi_flash.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Glass June 12, 2013, 10:38 p.m. UTC | #1
On Tue, Jun 11, 2013 at 12:23 PM, Jagannadha Sutradharudu Teki <
jagannadha.sutradharudu-teki@xilinx.com> wrote:

> Initialized bank_sel variable to 0 to support the updated read
> ops for flashes which has < 16Mbytes.
>
> Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
>

Reviewed-by: Simon Glass <sjg@chromium.org>

(This seems like it could be merged with an early patch?)
Jagan Teki June 13, 2013, 2:47 p.m. UTC | #2
On Thu, Jun 13, 2013 at 4:08 AM, Simon Glass <sjg@chromium.org> wrote:
> On Tue, Jun 11, 2013 at 12:23 PM, Jagannadha Sutradharudu Teki
> <jagannadha.sutradharudu-teki@xilinx.com> wrote:
>>
>> Initialized bank_sel variable to 0 to support the updated read
>> ops for flashes which has < 16Mbytes.
>>
>> Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
>
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> (This seems like it could be merged with an early patch?)
>

Merged with previous patch, thanks

--
Thanks,
Jagan.
diff mbox

Patch

diff --git a/drivers/mtd/spi/spi_flash.c b/drivers/mtd/spi/spi_flash.c
index ee959fc..96b8733 100644
--- a/drivers/mtd/spi/spi_flash.c
+++ b/drivers/mtd/spi/spi_flash.c
@@ -151,7 +151,7 @@  int spi_flash_read_common(struct spi_flash *flash, const u8 *cmd,
 int spi_flash_cmd_read_fast(struct spi_flash *flash, u32 offset,
 		size_t len, void *data)
 {
-	u8 cmd[5], bank_sel;
+	u8 cmd[5], bank_sel = 0;
 	u32 remain_len, read_len;
 	int ret = -1;