diff mbox series

arm64: zynqmp: Do not clear reset reason

Message ID 22ea89c98e0e790526a98bd8fcd47f13c9f4ea38.1612857121.git.michal.simek@xilinx.com
State Accepted
Commit 3aba25bc382beeb8a92b46d23fd1db47dfcb1121
Delegated to: Michal Simek
Headers show
Series arm64: zynqmp: Do not clear reset reason | expand

Commit Message

Michal Simek Feb. 9, 2021, 7:52 a.m. UTC
There is no need to clear reset reason register because it is protected by
PMUFW already which is reported when verbose log is enabled as:
pm_core.c@733 APU> No write permission to 0xFF5E0220

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 board/xilinx/zynqmp/zynqmp.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Comments

Michal Simek Feb. 23, 2021, 1:41 p.m. UTC | #1
Ășt 9. 2. 2021 v 8:52 odesĂ­latel Michal Simek <michal.simek@xilinx.com> napsal:
>
> There is no need to clear reset reason register because it is protected by
> PMUFW already which is reported when verbose log is enabled as:
> pm_core.c@733 APU> No write permission to 0xFF5E0220
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
>  board/xilinx/zynqmp/zynqmp.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/board/xilinx/zynqmp/zynqmp.c b/board/xilinx/zynqmp/zynqmp.c
> index a216eeb35f15..6babc0ebce3e 100644
> --- a/board/xilinx/zynqmp/zynqmp.c
> +++ b/board/xilinx/zynqmp/zynqmp.c
> @@ -496,11 +496,7 @@ static int reset_reason(void)
>
>         env_set("reset_reason", reason);
>
> -       ret = zynqmp_mmio_write((ulong)&crlapb_base->reset_reason, ~0, ~0);
> -       if (ret)
> -               return -EINVAL;
> -
> -       return ret;
> +       return 0;
>  }
>
>  static int set_fdtfile(void)
> --
> 2.30.0
>

Applied.
M
diff mbox series

Patch

diff --git a/board/xilinx/zynqmp/zynqmp.c b/board/xilinx/zynqmp/zynqmp.c
index a216eeb35f15..6babc0ebce3e 100644
--- a/board/xilinx/zynqmp/zynqmp.c
+++ b/board/xilinx/zynqmp/zynqmp.c
@@ -496,11 +496,7 @@  static int reset_reason(void)
 
 	env_set("reset_reason", reason);
 
-	ret = zynqmp_mmio_write((ulong)&crlapb_base->reset_reason, ~0, ~0);
-	if (ret)
-		return -EINVAL;
-
-	return ret;
+	return 0;
 }
 
 static int set_fdtfile(void)