diff mbox series

[v1,4/9] clk: qcom: sc7280: add GCC_PCIE_1_PIPE_CLK_SRC no-op gate

Message ID 20261104163408.1250410-5-sumit.dhami@oss.qualcomm.com
State New
Delegated to: Neil Armstrong
Headers show
Series Enable PCIe1 xHCI on Qualcomm QCS6490 RB3 Gen2 | expand

Commit Message

Sumit Singh Dhami Nov. 4, 2026, 4:33 p.m. UTC
From: Senthilkumar <senthilkumar.l@oss.qualcomm.com>

GCC_PCIE_1_PIPE_CLK_SRC (ID 56) has no gate entry, so
clk_get_bulk()/clk_enable_bulk() fail with "unknown clock ID 56"
for any consumer listing it in "clocks".

The mux it represents is actually configured by
clk_phy_mux_enable() as a side effect of enabling
GCC_PCIE_1_PIPE_CLK, so register it as a no-op gate.

Signed-off-by: Senthilkumar <senthilkumar.l@oss.qualcomm.com>
Signed-off-by: Sumit Singh Dhami <sumit.dhami@oss.qualcomm.com>
---
 drivers/clk/qcom/clock-sc7280.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Neil Armstrong Nov. 5, 2026, 10:57 a.m. UTC | #1
On 11/4/26 17:33, Sumit Singh Dhami wrote:
> From: Senthilkumar <senthilkumar.l@oss.qualcomm.com>
> 
> GCC_PCIE_1_PIPE_CLK_SRC (ID 56) has no gate entry, so
> clk_get_bulk()/clk_enable_bulk() fail with "unknown clock ID 56"
> for any consumer listing it in "clocks".
> 
> The mux it represents is actually configured by
> clk_phy_mux_enable() as a side effect of enabling
> GCC_PCIE_1_PIPE_CLK, so register it as a no-op gate.
> 
> Signed-off-by: Senthilkumar <senthilkumar.l@oss.qualcomm.com>
> Signed-off-by: Sumit Singh Dhami <sumit.dhami@oss.qualcomm.com>
> ---
>   drivers/clk/qcom/clock-sc7280.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/clk/qcom/clock-sc7280.c b/drivers/clk/qcom/clock-sc7280.c
> index eddeecfd9b7..fb2a017674f 100644
> --- a/drivers/clk/qcom/clock-sc7280.c
> +++ b/drivers/clk/qcom/clock-sc7280.c
> @@ -206,6 +206,11 @@ static const struct gate_clk sc7280_clks[] = {
>   	GATE_CLK_POLLED(GCC_PCIE_CLKREF_EN, 0x8c004, BIT(0), 0x8c004),
>   
>   	GATE_CLK(GCC_PCIE_1_PIPE_CLK, 0x52000, BIT(30)),
> +	/*
> +	 * No-op gate: actual mux config is done by clk_phy_mux_enable()
> +	 * when GCC_PCIE_1_PIPE_CLK is enabled.
> +	 */
> +	GATE_CLK(GCC_PCIE_1_PIPE_CLK_SRC, PCIE_1_PIPE_CLK_PHY_MUX, 0),
>   	GATE_CLK(GCC_PCIE_1_AUX_CLK, 0x52000, BIT(29)),
>   	GATE_CLK(GCC_PCIE_1_CFG_AHB_CLK, 0x52000, BIT(28)),
>   	GATE_CLK(GCC_PCIE_1_MSTR_AXI_CLK, 0x52000, BIT(27)),

Instead add early check in sc7280_enable for GCC_PCIE_1_PIPE_CLK_SRC which just returns 0.

Neil
diff mbox series

Patch

diff --git a/drivers/clk/qcom/clock-sc7280.c b/drivers/clk/qcom/clock-sc7280.c
index eddeecfd9b7..fb2a017674f 100644
--- a/drivers/clk/qcom/clock-sc7280.c
+++ b/drivers/clk/qcom/clock-sc7280.c
@@ -206,6 +206,11 @@  static const struct gate_clk sc7280_clks[] = {
 	GATE_CLK_POLLED(GCC_PCIE_CLKREF_EN, 0x8c004, BIT(0), 0x8c004),
 
 	GATE_CLK(GCC_PCIE_1_PIPE_CLK, 0x52000, BIT(30)),
+	/*
+	 * No-op gate: actual mux config is done by clk_phy_mux_enable()
+	 * when GCC_PCIE_1_PIPE_CLK is enabled.
+	 */
+	GATE_CLK(GCC_PCIE_1_PIPE_CLK_SRC, PCIE_1_PIPE_CLK_PHY_MUX, 0),
 	GATE_CLK(GCC_PCIE_1_AUX_CLK, 0x52000, BIT(29)),
 	GATE_CLK(GCC_PCIE_1_CFG_AHB_CLK, 0x52000, BIT(28)),
 	GATE_CLK(GCC_PCIE_1_MSTR_AXI_CLK, 0x52000, BIT(27)),