| Message ID | 20261004061826.1028380-2-marek.vasut+renesas@mailbox.org |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [1/2] kbuild: Pass -Eno-node_name_not_empty to DTC if supported | expand |
On Sun, Oct 04, 2026 at 08:17:43AM +0200, Marek Vasut wrote: > DTC commit cba90ce82064 ("checks: Remove check for graph child addresses") > removed -Wno-graph_child_address command line parameter. Apply this option > only to DTC older than 1.8.0. > > This can be triggered on e.g. Debian Testing (as of 2026-09-07) when > using system DTC: > > $ export DTC=/usr/bin/dtc > $ $DTC --version > Version: DTC 1.8.1 > $ r8a779g3_sparrowhawk_defconfig > $ make -j$(nproc) > ... > FATAL ERROR: Unrecognized check name "graph_child_address" > Check /path/to/dts/upstream/src/arm64/renesas/.r8a779g3-sparrow-hawk.dtb.pre.tmp for errors > > Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> > --- We should just drop it unconditionally, both to easier match up with future kernel re-syncs and also because the DTC commit (as I read it) says the check itself was flawed / not useful.
diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index 330ab3892e9..3817115816b 100644 --- a/scripts/Makefile.lib +++ b/scripts/Makefile.lib @@ -357,7 +357,6 @@ DTC_FLAGS += -Wno-unit_address_vs_reg \ -Wno-unit_address_format \ -Wno-avoid_unnecessary_addr_size \ -Wno-alias_paths \ - -Wno-graph_child_address \ -Wno-simple_bus_reg \ -Wno-unique_unit_address \ -Wno-pci_device_reg @@ -391,6 +390,11 @@ dtc-option = $(call try-run,\ # DTC 1.8.0 and newer, add the option conditionally. DTC_FLAGS += $(call dtc-option, -Eno-node_name_not_empty) +# Since cba90ce82064 ("checks: Remove check for graph child addresses") +# the -Wno-graph_child_address is no longer available. Apply the option +# only to DTC older than 1.8.0. +DTC_FLAGS += $(call dtc-option, -Wno-graph_child_address) + # Generate an assembly file to wrap the output of the device tree compiler quiet_cmd_dt_S_dtb= DTBS $@ # Modified for U-Boot
DTC commit cba90ce82064 ("checks: Remove check for graph child addresses") removed -Wno-graph_child_address command line parameter. Apply this option only to DTC older than 1.8.0. This can be triggered on e.g. Debian Testing (as of 2026-09-07) when using system DTC: $ export DTC=/usr/bin/dtc $ $DTC --version Version: DTC 1.8.1 $ r8a779g3_sparrowhawk_defconfig $ make -j$(nproc) ... FATAL ERROR: Unrecognized check name "graph_child_address" Check /path/to/dts/upstream/src/arm64/renesas/.r8a779g3-sparrow-hawk.dtb.pre.tmp for errors Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> --- Cc: David Gibson <david@gibson.dropbear.id.au> Cc: Héctor Orón Martínez <zumbi@debian.org> Cc: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Cc: Rasmus Villemoes <rv@rasmusvillemoes.dk> Cc: Rob Herring (Arm) <robh@kernel.org> Cc: Simon Glass <sjg@chromium.org> Cc: Tom Rini <trini@konsulko.com> Cc: Vagrant Cascadian <vagrant@debian.org> Cc: u-boot@lists.u-boot-project.org --- scripts/Makefile.lib | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)