diff mbox series

video: rockchip: Set return code

Message ID 20251001-video_rockchip-v1-1-4933bdb56990@linaro.org
State Under Review
Delegated to: Quentin Schulz
Headers show
Series video: rockchip: Set return code | expand

Commit Message

Andrew Goodbody Oct. 1, 2025, 10:37 a.m. UTC 
In rk_edp_start_aux_transaction the check for "AUX CH command reply
received" returns ret as the error code but it has not been assigned a
value so this could lead to the calling code silently ignoring the
error. Instead return -EIO.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
---
 drivers/video/rockchip/rk_edp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


---
base-commit: b2d5e46c67002e46ac339ef549ea18cf5adfcd87
change-id: 20251001-video_rockchip-a480d9178ae6

Best regards,
diff mbox series

Patch

diff --git a/drivers/video/rockchip/rk_edp.c b/drivers/video/rockchip/rk_edp.c
index 0ba68dbce3d126f8a3230435ffa0f780c1e08d61..7186abc9c6c93d05e774e61efa136bf98ff727df 100644
--- a/drivers/video/rockchip/rk_edp.c
+++ b/drivers/video/rockchip/rk_edp.c
@@ -216,7 +216,7 @@  static int rk_edp_start_aux_transaction(struct rk3288_edp *regs)
 	/* Is AUX CH command reply received? */
 	if (rk_edp_is_aux_reply(regs)) {
 		debug("AUX CH command reply failed!\n");
-		return ret;
+		return -EIO;
 	}
 
 	/* Clear interrupt source for AUX CH access error */