| Message ID | 20250512155859.145717-1-marek.vasut@mailbox.org |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | image: Fix FIT image loadable section custom processing | expand |
On Mon, 12 May 2025 17:58:39 +0200, Marek Vasut wrote: > The original commit always generated linker list entries with the same > entry variable name, because _function passed to ll_entry_declare() is > not a variable and therefore was interpreted as fixed string. Change it > to _type which is a variable and which does allow generation of multiple > unique linker list entries, one for each U_BOOT_FIT_LOADABLE_HANDLER(). > > > [...] Applied to u-boot/next, thanks! [1/1] image: Fix FIT image loadable section custom processing commit: e15282f943b42647478ec158011656df7cf12ec2
diff --git a/include/image.h b/include/image.h index c1db8383459..f09862b636f 100644 --- a/include/image.h +++ b/include/image.h @@ -2133,7 +2133,7 @@ struct fit_loadable_tbl { * _handler is the handler function to call after this image type is loaded */ #define U_BOOT_FIT_LOADABLE_HANDLER(_type, _handler) \ - ll_entry_declare(struct fit_loadable_tbl, _function, fit_loadable) = { \ + ll_entry_declare(struct fit_loadable_tbl, _type, fit_loadable) = { \ .type = _type, \ .handler = _handler, \ }
The original commit always generated linker list entries with the same entry variable name, because _function passed to ll_entry_declare() is not a variable and therefore was interpreted as fixed string. Change it to _type which is a variable and which does allow generation of multiple unique linker list entries, one for each U_BOOT_FIT_LOADABLE_HANDLER(). Fixes: d7be50921ed3 ("image: Add FIT image loadable section custom processing") Signed-off-by: Marek Vasut <marek.vasut@mailbox.org> --- Cc: Julien Masson <jmasson@baylibre.com> Cc: Mattijs Korpershoek <mkorpershoek@kernel.org> Cc: Paul HENRYS <paul.henrys_ext@softathome.com> Cc: Simon Glass <sjg@chromium.org> Cc: Sughosh Ganu <sughosh.ganu@linaro.org> Cc: Tom Rini <trini@konsulko.com> Cc: u-boot@lists.denx.de --- include/image.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)